Add environment variable that sets the module_scheme [chromium/src : main]
38 views
Skip to first unread message
Benjamin Joyce (Ben) (Gerrit)
Dec 19, 2025, 1:07:39 PM12/19/25
to Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, Nico Weber, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Nico Weber
Benjamin Joyce (Ben) added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4:
Nico Weber . resolved
Benjamin Joyce (Ben)It seems a bit weird that individual tests would need to know about this.
Should we just set this in PRESUBMIT.py instead
So currently, all tests in presubmit are presumed to have a "flat" module scheme and most of them do.
You'd be proposing to
Commit Message
Line 10, Patchset 4:
These tests are ran in presubmit and need to upload as a flat type,Nico Weber . resolved
Benjamin Joyce (Ben)nit: s/are ran/are run/
Done
Related details
Attention is currently required from:
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Joyce (Ben) (Gerrit)
Jan 6, 2026, 4:39:40 PM (10 days ago) Jan 6
to Code Review Nudger, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, Nico Weber, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Nico Weber
Benjamin Joyce (Ben) added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Joyce (Ben) (Gerrit)
Jan 12, 2026, 4:57:00 PM (4 days ago) Jan 12
to Andrew Grieve, Kenneth Russell, Code Review Nudger, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Andrew Grieve and Kenneth Russell
Benjamin Joyce (Ben) added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Benjamin Joyce (Ben) . resolved
Attention is currently required from:
- Andrew Grieve
- Kenneth Russell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenneth Russell (Gerrit)
Jan 12, 2026, 5:15:43 PM (4 days ago) Jan 12
to Benjamin Joyce (Ben), Andrew Grieve, Code Review Nudger, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Andrew Grieve and Benjamin Joyce (Ben)
Kenneth Russell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kenneth Russell
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Andrew Grieve
- Benjamin Joyce (Ben)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Grieve (Gerrit)
Jan 12, 2026, 9:03:01 PM (4 days ago) Jan 12
to Benjamin Joyce (Ben), Kenneth Russell, Andrew Grieve, Code Review Nudger, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Benjamin Joyce (Ben)
Andrew Grieve added 2 comments![]( "Open in Gerrit")
Commit Message
Line 19, Patchset 9 (Latest):
Bug:47777155Andrew Grieve . unresolved
Wrong bug number? (Says invalid ID)
File tools/grit/PRESUBMIT.py
Line 14, Patchset 9 (Latest):
# Needed to prevent an issue with conflicting module schemes when uploadingAndrew Grieve . unresolved
"prevent an issue" begs the question: what is the issue?
Can you describe the issue?
Related details
Attention is currently required from:
- Benjamin Joyce (Ben)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Joyce (Ben) (Gerrit)
Jan 14, 2026, 4:29:04 PM (2 days ago) Jan 14
to Kenneth Russell, Andrew Grieve, Code Review Nudger, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Andrew Grieve
Benjamin Joyce (Ben) added 2 comments![]( "Open in Gerrit")
Commit Message
Wrong bug number? (Says invalid ID)
Benjamin Joyce (Ben)
Done. Should have been: 467777155
File tools/grit/PRESUBMIT.py
Line 14, Patchset 9:
# Needed to prevent an issue with conflicting module schemes when uploadingAndrew Grieve . resolved
"prevent an issue" begs the question: what is the issue?
Can you describe the issue?
Attention is currently required from:
- Andrew Grieve
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Grieve (Gerrit)
Jan 14, 2026, 4:30:45 PM (2 days ago) Jan 14
to Benjamin Joyce (Ben), Andrew Grieve, Kenneth Russell, Code Review Nudger, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Benjamin Joyce (Ben)
Andrew Grieve voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrew Grieve
| Code-Review | +1 |
1 comment
File tools/grit/PRESUBMIT.py
Line 14, Patchset 13 (Latest):
# The presubmit tests are all ran together with the module scheme set toAndrew Grieve . unresolved
nit: s/ran/run/
Related details
Attention is currently required from:
- Benjamin Joyce (Ben)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Joyce (Ben) (Gerrit)
Jan 14, 2026, 4:49:16 PM (2 days ago) Jan 14
to Andrew Grieve, Kenneth Russell, Code Review Nudger, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Benjamin Joyce (Ben) added 1 comment![]( "Open in Gerrit")
File tools/grit/PRESUBMIT.py
Line 14, Patchset 13:
# The presubmit tests are all ran together with the module scheme set toAndrew Grieve . resolved
Benjamin Joyce (Ben)nit: s/ran/run/
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Joyce (Ben) (Gerrit)
Jan 14, 2026, 4:49:21 PM (2 days ago) Jan 14
to Andrew Grieve, Kenneth Russell, Code Review Nudger, Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Benjamin Joyce (Ben) voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Jan 14, 2026, 6:24:35 PM (2 days ago) Jan 14
to Benjamin Joyce (Ben), Andrew Grieve, Kenneth Russell, Code Review Nudger, Raphael Kubo da Costa, Kentaro Hara, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
13 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/build/scripts/PRESUBMIT.py
Insertions: 1, Deletions: 1.
@@ -37,7 +37,7 @@
def _RunTests(input_api, output_api):
- # The presubmit tests are all ran together with the module scheme set to
+ # The presubmit tests are all run together with the module scheme set to
# "flat" at the recipe level. But these presubmit tests run through
# a test runner that parses the test as a "pyunit" test. The environment
# variable forces the test runner to parse the tests as a flat test,
```
```
The name of the file: tools/grit/PRESUBMIT.py
Insertions: 1, Deletions: 1.
@@ -11,7 +11,7 @@
import os
def RunUnittests(input_api, output_api):
- # The presubmit tests are all ran together with the module scheme set to
+ # The presubmit tests are all run together with the module scheme set to
# "flat" at the recipe level. But these presubmit tests run through
# a test runner that parses the test as a "pyunit" test. The environment
# variable forces the test runner to parse the tests as a flat test,
```
```
The name of the file: third_party/blink/renderer/build/scripts/blinkbuild/PRESUBMIT.py
Insertions: 1, Deletions: 1.
@@ -5,7 +5,7 @@
import os
def _RunBindingsTests(input_api, output_api):
- # The presubmit tests are all ran together with the module scheme set to
+ # The presubmit tests are all run together with the module scheme set to
# "flat" at the recipe level. But these presubmit tests run through
# a test runner that parses the test as a "pyunit" test. The environment
# variable forces the test runner to parse the tests as a flat test,
```
```
The name of the file: third_party/blink/renderer/bindings/PRESUBMIT.py
Insertions: 1, Deletions: 1.
@@ -34,7 +34,7 @@
import os
def _RunBindingsTests(input_api, output_api):
- # The presubmit tests are all ran together with the module scheme set to
+ # The presubmit tests are all run together with the module scheme set to
# "flat" at the recipe level. But these presubmit tests run through
# a test runner that parses the test as a "pyunit" test. The environment
# variable forces the test runner to parse the tests as a flat test,
```
Change information
Commit message:
Add environment variable that sets the module_scheme
Sets a module scheme as an environment variable for resultdb upload.
These tests are run in presubmit and need to upload as a flat type,
where as by default, they upload with pyunit.
These tests are called by the presubmit tests and were failing with the resultdb migration in:
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-presubmit/35142/overview
This change will be used when this catapult CL is rolled:
https://chromium-review.googlesource.com/c/catapult/+/7274125
Bug: 467777155
Change-Id: Icd77254b431aa5ea0793d8e3082e38da78f616fc
Reviewed-by: Kenneth Russell <k...@chromium.org>
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Commit-Queue: Benjamin Joyce (Ben) <bjo...@google.com>
Cr-Commit-Position: refs/heads/main@{#1569378}
Files:
- M third_party/blink/renderer/bindings/PRESUBMIT.py
- M third_party/blink/renderer/build/scripts/PRESUBMIT.py
- M third_party/blink/renderer/build/scripts/blinkbuild/PRESUBMIT.py
- M tools/grit/PRESUBMIT.py
Change size: S
Delta: 4 files changed, 33 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrew Grieve, +1 by Kenneth Russell
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages