Add environment variable that sets the module_scheme [chromium/src : main]

0 views

Skip to first unread message

Benjamin Joyce (Ben) (Gerrit)

unread,

Dec 19, 2025, 1:07:39 PM (yesterday) Dec 19

to Raphael Kubo da Costa, Kentaro Hara, AyeAye, Chromium LUCI CQ, Nico Weber, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Nico Weber

Benjamin Joyce (Ben) added 2 comments

Patchset-level comments

File-level comment, Patchset 4:

Nico Weber . resolved

It seems a bit weird that individual tests would need to know about this.
Should we just set this in PRESUBMIT.py instead

Benjamin Joyce (Ben)

So currently, all tests in presubmit are presumed to have a "flat" module scheme and most of them do.

https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7231163/14/recipes/recipe_modules/presubmit/api.py#b38

You'd be proposing to

Commit Message

Line 10, Patchset 4:These tests are ran in presubmit and need to upload as a flat type,

Nico Weber . resolved

nit: s/are ran/are run/

Benjamin Joyce (Ben)

Done

Open in Gerrit

Related details

Attention is currently required from:

Nico Weber

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages