Change scoped_refptr<StringImpl> to String in AtomicString. [chromium/src : main]

0 views
Skip to first unread message

Steinar H Gunderson (Gerrit)

unread,
Jan 13, 2026, 9:59:36 AM (3 days ago) Jan 13
to Michael Lippautz, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, wfh+...@chromium.org, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, lucasrada...@google.com, mac-r...@chromium.org, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Michael Lippautz

Steinar H Gunderson added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Steinar H Gunderson . resolved

Ping on this CL :-) I know everything that's built on top of it is speculative, but this base patch should be reasonably uncontroversial, no?

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I716b8867bf2ce7ae3f089fef3ce3c65711a367ea
Gerrit-Change-Number: 7368547
Gerrit-PatchSet: 7
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 14:59:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Jan 13, 2026, 10:24:37 AM (3 days ago) Jan 13
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, wfh+...@chromium.org, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, lucasrada...@google.com, mac-r...@chromium.org, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Steinar H Gunderson

Michael Lippautz voted and added 1 comment

Votes added by Michael Lippautz

Code-Review+1

1 comment

Patchset-level comments
Michael Lippautz . resolved

lgtm

Sorry, I have really misread and misrememered the CL description here!

Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I716b8867bf2ce7ae3f089fef3ce3c65711a367ea
Gerrit-Change-Number: 7368547
Gerrit-PatchSet: 7
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 15:24:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Steinar H Gunderson (Gerrit)

unread,
Jan 13, 2026, 12:27:22 PM (3 days ago) Jan 13
to Michael Lippautz, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, wfh+...@chromium.org, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, lucasrada...@google.com, mac-r...@chromium.org, nektar...@chromium.org, yuzo+...@chromium.org

Steinar H Gunderson voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I716b8867bf2ce7ae3f089fef3ce3c65711a367ea
Gerrit-Change-Number: 7368547
Gerrit-PatchSet: 7
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Tue, 13 Jan 2026 17:27:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 13, 2026, 1:28:25 PM (3 days ago) Jan 13
to Steinar H Gunderson, Michael Lippautz, Akihiro Ota, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, wfh+...@chromium.org, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, lucasrada...@google.com, mac-r...@chromium.org, nektar...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Change scoped_refptr<StringImpl> to String in AtomicString.

A lot of AtomicString code uses scoped_refptr<StringImpl> when it
actually just wants a String. This makes it harder to change String
internals (I've seen this twice now during different experimental
optimization projects), so clean it up to make it more consistent.
Change-Id: I716b8867bf2ce7ae3f089fef3ce3c65711a367ea
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Steinar H Gunderson <se...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568531}
Files:
  • M third_party/blink/renderer/platform/wtf/text/atomic_string.cc
  • M third_party/blink/renderer/platform/wtf/text/atomic_string.h
  • M third_party/blink/renderer/platform/wtf/text/atomic_string_table.cc
  • M third_party/blink/renderer/platform/wtf/text/atomic_string_table.h
Change size: M
Delta: 4 files changed, 34 insertions(+), 39 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Lippautz
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I716b8867bf2ce7ae3f089fef3ce3c65711a367ea
Gerrit-Change-Number: 7368547
Gerrit-PatchSet: 8
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages