Ensure no pending exception during trivial ScriptPromiseResolver ops [chromium/src : main]

0 views
Skip to first unread message

Andrey Kosyakov (Gerrit)

unread,
Oct 29, 2025, 8:18:43 PM (4 days ago) Oct 29
to AyeAye, jonas de groof, Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ricea...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Nate Chapin

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Nate Chapin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I361163f534aa94dc6461b2653f272f6ca6571448
Gerrit-Change-Number: 7093559
Gerrit-PatchSet: 4
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: jonas de groof <zombieno...@gmail.com>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 00:18:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Chapin (Gerrit)

unread,
Oct 30, 2025, 1:14:27 PM (3 days ago) Oct 30
to Andrey Kosyakov, AyeAye, jonas de groof, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ricea...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Andrey Kosyakov

Nate Chapin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I361163f534aa94dc6461b2653f272f6ca6571448
Gerrit-Change-Number: 7093559
Gerrit-PatchSet: 4
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: jonas de groof <zombieno...@gmail.com>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Oct 2025 17:14:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andrey Kosyakov (Gerrit)

unread,
Oct 30, 2025, 2:01:48 PM (3 days ago) Oct 30
to Nate Chapin, AyeAye, jonas de groof, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ricea...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Andrey Kosyakov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I361163f534aa94dc6461b2653f272f6ca6571448
Gerrit-Change-Number: 7093559
Gerrit-PatchSet: 4
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: jonas de groof <zombieno...@gmail.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 18:01:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 30, 2025, 2:06:23 PM (3 days ago) Oct 30
to Andrey Kosyakov, Nate Chapin, AyeAye, jonas de groof, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ricea...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Ensure no pending exception during trivial ScriptPromiseResolver ops

Trivial V8 API ops like allocating or resolveing a promise would clear a
pending exception, so make sure we're not re-entering V8 with a pending
exception.
Bug: 427166012
Change-Id: I361163f534aa94dc6461b2653f272f6ca6571448
Reviewed-by: Nate Chapin <jap...@chromium.org>
Commit-Queue: Andrey Kosyakov <ca...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1538064}
Files:
  • M third_party/blink/renderer/bindings/core/v8/script_promise_resolver.cc
  • M third_party/blink/renderer/core/streams/transform_stream_default_controller.cc
  • M third_party/blink/renderer/core/streams/writable_stream_default_controller.cc
Change size: S
Delta: 3 files changed, 14 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nate Chapin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I361163f534aa94dc6461b2653f272f6ca6571448
Gerrit-Change-Number: 7093559
Gerrit-PatchSet: 5
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages