[WebCrypto] add encapsulate/decapsulate operations [chromium/src : main]

0 views
Skip to first unread message

Hubert Chao (Gerrit)

unread,
Mar 6, 2026, 4:38:24 PM (6 days ago) Mar 6
to Lily Chen, David Benjamin, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko+...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Lily Chen

Hubert Chao added 1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Hubert Chao . resolved

@chl...@chromium.org for initial review

Open in Gerrit

Related details

Attention is currently required from:
  • Lily Chen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4a61bc20d9bcdfa5d1d996b2df55ac264733e72c
Gerrit-Change-Number: 7609661
Gerrit-PatchSet: 9
Gerrit-Owner: Hubert Chao <hc...@chromium.org>
Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: David Benjamin <davi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Lily Chen <chl...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Mar 2026 21:38:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lily Chen (Gerrit)

unread,
Mar 9, 2026, 2:57:24 PM (3 days ago) Mar 9
to Hubert Chao, Lily Chen, David Benjamin, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko+...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Hubert Chao

Lily Chen voted and added 2 comments

Votes added by Lily Chen

Code-Review+1

2 comments

File third_party/blink/renderer/modules/crypto/subtle_crypto.idl
Line 58, Patchset 11 (Latest):
Lily Chen . unresolved

nit: delete this newline? In the spec it seems that encapsulateKey and encapsulateBits are together, and decapsulateKey and decapsulateBits are together.

File third_party/blink/renderer/platform/exported/web_crypto_algorithm.cc
Line 66, Patchset 11 (Latest): WebCryptoAlgorithmInfo::kUndefined // DecapsulateBits
Lily Chen . unresolved

nit: does the formatter allow you to put a trailing comma here? It might make future additions a bit easier.

Open in Gerrit

Related details

Attention is currently required from:
  • Hubert Chao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4a61bc20d9bcdfa5d1d996b2df55ac264733e72c
    Gerrit-Change-Number: 7609661
    Gerrit-PatchSet: 11
    Gerrit-Owner: Hubert Chao <hc...@chromium.org>
    Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
    Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: David Benjamin <davi...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Hubert Chao <hc...@chromium.org>
    Gerrit-Comment-Date: Mon, 09 Mar 2026 18:57:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hubert Chao (Gerrit)

    unread,
    Mar 11, 2026, 2:31:41 PM (yesterday) Mar 11
    to Lily Chen, David Benjamin, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko+...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Hubert Chao added 2 comments

    File third_party/blink/renderer/modules/crypto/subtle_crypto.idl
    Line 58, Patchset 11:
    Lily Chen . resolved

    nit: delete this newline? In the spec it seems that encapsulateKey and encapsulateBits are together, and decapsulateKey and decapsulateBits are together.

    Hubert Chao

    Done

    File third_party/blink/renderer/platform/exported/web_crypto_algorithm.cc
    Line 66, Patchset 11: WebCryptoAlgorithmInfo::kUndefined // DecapsulateBits
    Lily Chen . resolved

    nit: does the formatter allow you to put a trailing comma here? It might make future additions a bit easier.

    Hubert Chao

    oh hey that does work. that's better, fixed.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4a61bc20d9bcdfa5d1d996b2df55ac264733e72c
      Gerrit-Change-Number: 7609661
      Gerrit-PatchSet: 12
      Gerrit-Owner: Hubert Chao <hc...@chromium.org>
      Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
      Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: David Benjamin <davi...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Comment-Date: Wed, 11 Mar 2026 18:31:35 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Lily Chen <chl...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Daniel Cheng (Gerrit)

      unread,
      2:58 PM (5 hours ago) 2:58 PM
      to Hubert Chao, Daniel Cheng, Lily Chen, David Benjamin, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, asvitkine...@chromium.org, kinuko+...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jbroma...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from Hubert Chao

      Daniel Cheng voted and added 2 comments

      Votes added by Daniel Cheng

      Code-Review+1

      2 comments

      Patchset-level comments
      File third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules.cc
      Line 503, Patchset 12 (Latest): }
      Daniel Cheng . unresolved

      I'm assuming this stuff is all covered by tests somewhere.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Hubert Chao
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4a61bc20d9bcdfa5d1d996b2df55ac264733e72c
      Gerrit-Change-Number: 7609661
      Gerrit-PatchSet: 12
      Gerrit-Owner: Hubert Chao <hc...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
      Gerrit-Reviewer: Lily Chen <chl...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: David Benjamin <davi...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Hubert Chao <hc...@chromium.org>
      Gerrit-Comment-Date: Thu, 12 Mar 2026 18:58:40 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages