Add PaintImageForCurrentFrameWithInfo and apply nit on optional [chromium/src : main]

38 views
Skip to first unread message

Seokho Song (Gerrit)

unread,
Feb 5, 2026, 4:00:24 AM (6 days ago) Feb 5
to Stephen Chenney, Florin Malita, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Kentaro Hara, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, abigailbk...@google.com, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, dcheng+c...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, pdr+svgw...@chromium.org, yuzo+...@chromium.org
Attention needed from Florin Malita and Stephen Chenney

Seokho Song added 1 comment

File third_party/blink/renderer/platform/graphics/bitmap_image.h
Line 97, Patchset 5: PaintImage PaintImageForCurrentFromeWithOptions(ImageNodeAnimationInfo*);
Florin Malita . resolved

typo: frame

Seokho Song

😳 Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Florin Malita
  • Stephen Chenney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2b2e53103796c4a8ebafb79d1d75d313cc18f422
Gerrit-Change-Number: 7531147
Gerrit-PatchSet: 7
Gerrit-Owner: Seokho Song <seo...@chromium.org>
Gerrit-Reviewer: Florin Malita <fma...@chromium.org>
Gerrit-Reviewer: Seokho Song <seo...@chromium.org>
Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Florin Malita <fma...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Feb 2026 09:00:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Florin Malita <fma...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Seokho Song (Gerrit)

unread,
Feb 9, 2026, 11:06:51 PM (2 days ago) Feb 9
to Stephen Chenney, Florin Malita, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Kentaro Hara, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, abigailbk...@google.com, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, dcheng+c...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, pdr+svgw...@chromium.org, yuzo+...@chromium.org
Attention needed from Florin Malita and Stephen Chenney

Seokho Song added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Seokho Song . resolved

Friendly ping :-)

Gerrit-Comment-Date: Tue, 10 Feb 2026 04:06:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephen Chenney (Gerrit)

unread,
Feb 10, 2026, 10:04:11 AM (yesterday) Feb 10
to Seokho Song, Florin Malita, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Kentaro Hara, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, abigailbk...@google.com, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, dcheng+c...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, pdr+svgw...@chromium.org, yuzo+...@chromium.org
Attention needed from Florin Malita and Seokho Song

Stephen Chenney voted and added 2 comments

Votes added by Stephen Chenney

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 5:
Stephen Chenney . resolved

I know I suggested the name, but I'm finding the mismatch between `...WithOption` and `...Info` to be distracting. What do folks thing about `PaintImageForCurrentFrameWithInfo(...)` or `PaintImageForCurrentFrameMaybeAnimated(...)`?

Stephen Chenney

Or `PaintImageForAnimatingFrame`?

Stephen Chenney . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Florin Malita
  • Seokho Song
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2b2e53103796c4a8ebafb79d1d75d313cc18f422
Gerrit-Change-Number: 7531147
Gerrit-PatchSet: 7
Gerrit-Owner: Seokho Song <seo...@chromium.org>
Gerrit-Reviewer: Florin Malita <fma...@chromium.org>
Gerrit-Reviewer: Seokho Song <seo...@chromium.org>
Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Florin Malita <fma...@chromium.org>
Gerrit-Attention: Seokho Song <seo...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Feb 2026 15:04:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Stephen Chenney <sche...@chromium.org>
satisfied_requirement
open
diffy

Florin Malita (Gerrit)

unread,
Feb 10, 2026, 10:10:52 AM (yesterday) Feb 10
to Seokho Song, Stephen Chenney, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Kentaro Hara, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, abigailbk...@google.com, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, dcheng+c...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, pdr+svgw...@chromium.org, yuzo+...@chromium.org
Attention needed from Seokho Song

Florin Malita voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Seokho Song
Gerrit-Attention: Seokho Song <seo...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Feb 2026 15:10:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Seokho Song (Gerrit)

unread,
Feb 10, 2026, 8:40:54 PM (14 hours ago) Feb 10
to Florin Malita, Stephen Chenney, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Kentaro Hara, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, abigailbk...@google.com, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, dcheng+c...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, pdr+svgw...@chromium.org, yuzo+...@chromium.org

Seokho Song voted and added 1 comment

Votes added by Seokho Song

Commit-Queue+2

1 comment

Patchset-level comments
Stephen Chenney . resolved

I know I suggested the name, but I'm finding the mismatch between `...WithOption` and `...Info` to be distracting. What do folks thing about `PaintImageForCurrentFrameWithInfo(...)` or `PaintImageForCurrentFrameMaybeAnimated(...)`?

Stephen Chenney

Or `PaintImageForAnimatingFrame`?

Seokho Song

I slightly prefer the current version! Thanks for the suggestion ;)

Open in Gerrit

Related details

Attention set is empty
Gerrit-Comment-Date: Wed, 11 Feb 2026 01:40:23 +0000
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 10, 2026, 10:50:50 PM (12 hours ago) Feb 10
to Seokho Song, Florin Malita, Stephen Chenney, Akihiro Ota, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Kentaro Hara, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, abigailbk...@google.com, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, dcheng+c...@chromium.org, drott+bl...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jbroma...@chromium.org, josiah...@chromium.org, kainin...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, loading...@chromium.org, lucasrada...@google.com, nektar...@chromium.org, pdr+svgw...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Add PaintImageForCurrentFrameWithInfo and apply nit on optional

This is the following CL from the review after the CL [1].

1. Use value_or instead of if statement
2. Add PaintImageForCurrentFrameWithInfo for bitmap_image.


[1] https://crrev.com/c/7458159


Bug: 429459566
Change-Id: I2b2e53103796c4a8ebafb79d1d75d313cc18f422
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7531147
Commit-Queue: Seokho Song <seo...@chromium.org>
Reviewed-by: Stephen Chenney <sche...@chromium.org>
Reviewed-by: Florin Malita <fma...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1582987}
Files:
  • M third_party/blink/renderer/platform/graphics/bitmap_image.cc
  • M third_party/blink/renderer/platform/graphics/bitmap_image.h
  • M third_party/blink/renderer/platform/graphics/image.cc
Change size: M
Delta: 3 files changed, 26 insertions(+), 29 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Stephen Chenney, +1 by Florin Malita
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2b2e53103796c4a8ebafb79d1d75d313cc18f422
Gerrit-Change-Number: 7531147
Gerrit-PatchSet: 8
Gerrit-Owner: Seokho Song <seo...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Florin Malita <fma...@chromium.org>
Gerrit-Reviewer: Seokho Song <seo...@chromium.org>
Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages