Bump kLastGeneratedScriptWrappableTag by 100 [chromium/src : main]
38 views
Skip to first unread message
Edman Anjos (Gerrit)
Feb 6, 2026, 11:35:36 AM (5 days ago) Feb 6
to Raphael Kubo da Costa, chromium...@chromium.org, Kentaro Hara, kinuko...@chromium.org, blink-revie...@chromium.org, chromium-a...@chromium.org, oshima...@chromium.org, blink-...@chromium.org, extension...@chromium.org, Edman Anjos
Edman Anjos has uploaded the change for review![]( "Open in Gerrit")
Commit message
Bump kLastGeneratedScriptWrappableTag by 100
We're adding a new ScriptWrappable, which hits the current limit of
1500. This change increases kLastGeneratedScriptWrappableTag to 1600.
With that we also need to update gin::kFirstPointerTag, as it shouldn't
overlap with script wrappable tags.
Bug: 480079149
Test: the next CL in this chain compiles
Change-Id: I383d65d55d9586b4132066ffbbb37697e1203e5f
Change diff
Change information
Files:
- M gin/public/wrappable_pointer_tags.h
- M third_party/blink/renderer/platform/bindings/wrapper_type_info.h
Change size: S
Delta: 2 files changed, 10 insertions(+), 4 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Edman Anjos (Gerrit)
Feb 9, 2026, 4:02:59 AM (2 days ago) Feb 9
to Edman Anjos, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Morten Stenshorne
Edman Anjos added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Morten Stenshorne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Morten Stenshorne (Gerrit)
Feb 9, 2026, 4:52:29 AM (2 days ago) Feb 9
to Edman Anjos, Andreas Haas, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Andreas Haas, Edman Anjos and Michael Lippautz
Morten Stenshorne added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Morten Stenshorne . resolved
Reassigning, based on https://chromium-review.googlesource.com/c/chromium/src/+/7116232
Related details
Attention is currently required from:
- Andreas Haas
- Edman Anjos
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Feb 9, 2026, 4:59:45 AM (2 days ago) Feb 9
to Edman Anjos, Morten Stenshorne, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Edman Anjos and Michael Lippautz
Andreas Haas voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andreas Haas
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/platform/bindings/wrapper_type_info.h
Line 56, Patchset 1 (Latest):
// The upper bound of all `ScriptWrappable` tags that we currently generate. IfAndreas Haas . unresolved
Could you introduce an if-this-then-that rule here, to link the constants here and in wrappable_pointer_tags.h?
Related details
Attention is currently required from:
- Edman Anjos
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andreas Haas (Gerrit)
Feb 9, 2026, 5:01:13 AM (2 days ago) Feb 9
to Edman Anjos, Morten Stenshorne, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Edman Anjos and Michael Lippautz
Andreas Haas added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/bindings/wrapper_type_info.h
Line 43, Patchset 1 (Latest):
#include "v8/include/v8-sandbox.h"Andreas Haas . unresolved
Why do you need the new include?
Edman Anjos (Gerrit)
Feb 9, 2026, 6:07:18 AM (2 days ago) Feb 9
to Edman Anjos, Andreas Haas, Morten Stenshorne, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Michael Lippautz
Edman Anjos added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/platform/bindings/wrapper_type_info.h
Line 56, Patchset 1:
// The upper bound of all `ScriptWrappable` tags that we currently generate. IfAndreas Haas . resolved
Could you introduce an if-this-then-that rule here, to link the constants here and in wrappable_pointer_tags.h?
Edman Anjos
Done
Why do you need the new include?
Edman Anjos
the include was missing, this declares `v8::CppHeapPointerTag` used in the line I changed.
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Edman Anjos (Gerrit)
Feb 9, 2026, 6:15:33 AM (2 days ago) Feb 9
to Edman Anjos, Jeremy Roman, Michael Lippautz, Andreas Haas, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Jeremy Roman and Michael Lippautz
Edman Anjos added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Edman Anjos . resolved
Michael to CC as he's OOO
Hi Jeremy, PTAL
Related details
Attention is currently required from:
- Jeremy Roman
- Michael Lippautz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Feb 9, 2026, 11:13:31 AM (2 days ago) Feb 9
to Edman Anjos, Jeremy Roman, Michael Lippautz, Andreas Haas, Morten Stenshorne, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Edman Anjos
Jeremy Roman voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jeremy Roman
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/platform/bindings/wrapper_type_info.h
Line 58, Patchset 3 (Latest):
// that this is too small, bump it up by another 100.Jeremy Roman . unresolved
nit: Why not give ourselves more space than this for now? uint16_t isn't infinite, but it seems like we could bump to like 2000 to make the need to update this a bit less frequent?
Related details
Attention is currently required from:
- Edman Anjos
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages