Emmanuel Romero Ruiz (Gerrit)

unread,

Jul 1, 2025, 8:30:58 PM7/1/25

to Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, Chromium LUCI CQ, Tricium, AyeAye, chromium...@chromium.org, Kentaro Hara, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Attention needed from Camille Lamy

Emmanuel Romero Ruiz added 1 comment

Patchset-level comments

File-level comment, Patchset 5:

Camille Lamy . resolved

Thanks! Could you point me to a discussion about no longer requiring cross-origin isolation for layout and style? This has security implications so I'd like to better understand the context.

Emmanuel Romero Ruiz

We started with an explainer that we published in MSEdgeExplainers https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/ConditionalMarkersExposure/explainer.md
Then, at the same time, we updated the initial Marker & security thread with our proposal https://github.com/WICG/js-self-profiling/issues/61#issuecomment-982872415 and asked Andrew Comminos for feedback and help to land this PR on the JS Self Profiler repo https://github.com/WICG/js-self-profiling/pull/85.
He mentioned that the proposal made sense, but it would be good to have feedback from other people that collaborated on the initial feature.

Camille Lamy

Thanks for the context. I think it would be helpful to explain in more details when the markers are triggered, and why it's already possible to observe them. Right now, it's not clear to me when the layout and style events are added, and whether the occurences would always be observable.

Emmanuel Romero Ruiz

Thanks for the feedback. You're right, I updated the description to include more
detail on why the timing of these events is already visible.

With this change their occurrences would always be observable when the flag for
markers is enabled. I added a section for this.

For this CL, I'll note that implementation is pending spec approval and your
comments would be very valuable in that PR https://github.com/WICG/js-self-profiling/pull/85.

Open in Gerrit

Related details

Attention is currently required from:

Camille Lamy

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Emmanuel Romero Ruiz (Gerrit)

unread,

Mar 23, 2026, 5:45:11 PM (10 days ago) Mar 23

to Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Attention needed from Camille Lamy

Emmanuel Romero Ruiz added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Emmanuel Romero Ruiz . resolved

Bringing some attention to the code change

Open in Gerrit

Related details

Attention is currently required from:

Camille Lamy

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Emmanuel Romero Ruiz (Gerrit)

unread,

Mar 25, 2026, 1:46:51 PM (8 days ago) Mar 25

to Takashi Nakayama, Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Attention needed from Camille Lamy and Takashi Nakayama

Emmanuel Romero Ruiz added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Emmanuel Romero Ruiz . resolved

Adding @tn...@chromium.org as a reviewer as a suggestion from Victor Huang

Open in Gerrit

Related details

Attention is currently required from:

Camille Lamy
Takashi Nakayama

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Emmanuel Romero Ruiz (Gerrit)

unread,

Mar 25, 2026, 5:24:23 PM (8 days ago) Mar 25

to Takashi Toyoshima, Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Attention needed from Camille Lamy and Takashi Toyoshima

Emmanuel Romero Ruiz added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Emmanuel Romero Ruiz . resolved

My bad, adding @toyo...@chromium.org to see if he can help with some comments on the change

Open in Gerrit

Related details

Attention is currently required from:

Camille Lamy
Takashi Toyoshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Takashi Toyoshima (Gerrit)

unread,

Mar 27, 2026, 3:13:18 AM (6 days ago) Mar 27

to Emmanuel Romero Ruiz, Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Attention needed from Camille Lamy and Emmanuel Romero Ruiz

Takashi Toyoshima added 7 comments

File third_party/blink/renderer/bindings/core/v8/profiler_trace_builder.h

Line 140, Patchset 9 (Latest): default:

Takashi Toyoshima . unresolved

adding default in case is not future change proof and discouraged, but as this seems a common pattern in this header, lgtm.

File third_party/blink/renderer/bindings/core/v8/profiler_trace_builder.cc

Line 60, Patchset 9 (Latest): const bool are_markers_enabled =

Takashi Toyoshima . unresolved

used only once. can we just inline?

Line 71, Patchset 9 (Latest): ExecutionContext* execution_context = ExecutionContext::From(script_state_);

Takashi Toyoshima . unresolved

Potentially could be nullptr?

Line 72, Patchset 9 (Latest): const bool is_cross_origin_isolated =

Takashi Toyoshima . unresolved

same, inlined?

Line 75, Patchset 9 (Latest): marker = ProfileMarkerToPublicMarker(*marker);

Takashi Toyoshima . unresolved

may be optimized out, but could be marker->AsEnum() and changed the method to take a V8ProfilerMarker::Enum instead?

File third_party/blink/renderer/bindings/core/v8/profiler_trace_builder_test.cc

Line 32, Patchset 9 (Latest): blink::SetIsCrossOriginIsolated(true);

Takashi Toyoshima . unresolved

should this be reset in TearDown() to avoid cross-test unexpected side-effect?

File third_party/blink/renderer/core/timing/profiler_sample.idl

Line 12, Patchset 9 (Parent): [RuntimeEnabled=ExperimentalJSProfilerMarkers, CrossOriginIsolated] ProfilerMarker marker;

Takashi Toyoshima . unresolved

This part may be also noted in the CL description? Maybe update the last changes part ``` Changes: ...

Check ExperimentalJSProfilerMarkersEnabled flag at runtime
```
to say that the marker is always exposed to JS now?

Open in Gerrit

Related details

Attention is currently required from:

Camille Lamy
Emmanuel Romero Ruiz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Emmanuel Romero Ruiz (Gerrit)

unread,

Mar 27, 2026, 5:13:30 PM (6 days ago) Mar 27

to Takashi Toyoshima, Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, ios-revie...@chromium.org, browser-comp...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Attention needed from Camille Lamy and Takashi Toyoshima

Emmanuel Romero Ruiz added 8 comments

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Emmanuel Romero Ruiz . resolved

Thank you very much for the comments. I just address them all

File third_party/blink/renderer/bindings/core/v8/profiler_trace_builder.h

Line 140, Patchset 9: default:

Takashi Toyoshima . resolved

adding default in case is not future change proof and discouraged, but as this seems a common pattern in this header, lgtm.

Emmanuel Romero Ruiz

Done

File third_party/blink/renderer/bindings/core/v8/profiler_trace_builder.cc

Line 60, Patchset 9: const bool are_markers_enabled =

Takashi Toyoshima . resolved

used only once. can we just inline?

Emmanuel Romero Ruiz

Done

Line 71, Patchset 9: ExecutionContext* execution_context = ExecutionContext::From(script_state_);

Takashi Toyoshima . resolved

Potentially could be nullptr?

Emmanuel Romero Ruiz

Done

Line 72, Patchset 9: const bool is_cross_origin_isolated =

Takashi Toyoshima . resolved

same, inlined?

Emmanuel Romero Ruiz

Done

Line 75, Patchset 9: marker = ProfileMarkerToPublicMarker(*marker);

Takashi Toyoshima . resolved

may be optimized out, but could be marker->AsEnum() and changed the method to take a V8ProfilerMarker::Enum instead?

Emmanuel Romero Ruiz

Done

File third_party/blink/renderer/bindings/core/v8/profiler_trace_builder_test.cc

Line 32, Patchset 9: blink::SetIsCrossOriginIsolated(true);

Takashi Toyoshima . resolved

should this be reset in TearDown() to avoid cross-test unexpected side-effect?

Emmanuel Romero Ruiz

Done

File third_party/blink/renderer/core/timing/profiler_sample.idl

Line 12, Patchset 9 (Parent): [RuntimeEnabled=ExperimentalJSProfilerMarkers, CrossOriginIsolated] ProfilerMarker marker;

Takashi Toyoshima . resolved

This part may be also noted in the CL description? Maybe update the last changes part ``` Changes: ...
Check ExperimentalJSProfilerMarkersEnabled flag at runtime
```
to say that the marker is always exposed to JS now?

Emmanuel Romero Ruiz

Done

Open in Gerrit

Related details

Attention is currently required from:

Camille Lamy
Takashi Toyoshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Takashi Toyoshima (Gerrit)

unread,

Mar 30, 2026, 3:05:02 AM (3 days ago) Mar 30

to Emmanuel Romero Ruiz, Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, ios-revie...@chromium.org, browser-comp...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Attention needed from Camille Lamy and Emmanuel Romero Ruiz

Takashi Toyoshima voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Camille Lamy
Emmanuel Romero Ruiz

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fabio Rocha (Gerrit)

unread,

Mar 30, 2026, 4:02:44 PM (3 days ago) Mar 30

to Emmanuel Romero Ruiz, Takashi Toyoshima, Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, ios-revie...@chromium.org, browser-comp...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Attention needed from Camille Lamy and Emmanuel Romero Ruiz

Fabio Rocha voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Camille Lamy
Emmanuel Romero Ruiz

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Emmanuel Romero Ruiz (Gerrit)

unread,

Mar 30, 2026, 4:34:11 PM (3 days ago) Mar 30

to Fabio Rocha, Takashi Toyoshima, Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, ios-revie...@chromium.org, browser-comp...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Attention needed from Camille Lamy

Emmanuel Romero Ruiz voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Camille Lamy

satisfied_requirement

open

diffy

Liang Zhao (Gerrit)

unread,

Mar 30, 2026, 4:37:42 PM (3 days ago) Mar 30

to Emmanuel Romero Ruiz, Fabio Rocha, Takashi Toyoshima, Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, ios-revie...@chromium.org, browser-comp...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Attention needed from Camille Lamy

Liang Zhao added 1 comment

File third_party/blink/renderer/core/timing/profiler_sample.idl

Line 12, Patchset 17 (Latest): ProfilerMarker marker;

Liang Zhao . unresolved

Do we want to also update /third_party/blink/web_tests/external/wpt/interfaces/js-self-profiling.idl?

And, do we plan to add WPT tests for the change, or test updates to be in some separate CL or spec CL?

Open in Gerrit

Related details

Attention is currently required from:

Camille Lamy

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Emmanuel Romero Ruiz (Gerrit)

unread,

Mar 31, 2026, 1:58:53 PM (2 days ago) Mar 31

to Liang Zhao, Fabio Rocha, Takashi Toyoshima, Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, ios-revie...@chromium.org, browser-comp...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Attention needed from Camille Lamy and Liang Zhao

Emmanuel Romero Ruiz voted and added 1 comment

Votes added by Emmanuel Romero Ruiz

Commit-Queue

+1

1 comment

File third_party/blink/renderer/core/timing/profiler_sample.idl

Line 12, Patchset 17: ProfilerMarker marker;

Liang Zhao . resolved

Do we want to also update /third_party/blink/web_tests/external/wpt/interfaces/js-self-profiling.idl?
And, do we plan to add WPT tests for the change, or test updates to be in some separate CL or spec CL?

Emmanuel Romero Ruiz

This IDL file is auto-generated from the spec by Reffy/webref, so it should not be modified here. It will update automatically once the spec PR lands: https://github.com/WICG/js-self-profiling/pull/85

For WPT tests, I filed https://issues.chromium.org/issues/498095296 to track adding them in a follow-up CL.

Open in Gerrit

Related details

Attention is currently required from:

Camille Lamy
Liang Zhao

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Liang Zhao (Gerrit)

unread,

Mar 31, 2026, 2:04:18 PM (2 days ago) Mar 31

to Emmanuel Romero Ruiz, Fabio Rocha, Takashi Toyoshima, Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, ios-revie...@chromium.org, browser-comp...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Attention needed from Camille Lamy and Emmanuel Romero Ruiz

Liang Zhao voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Camille Lamy
Emmanuel Romero Ruiz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Emmanuel Romero Ruiz (Gerrit)

unread,

Mar 31, 2026, 2:06:13 PM (2 days ago) Mar 31

to Liang Zhao, Fabio Rocha, Takashi Toyoshima, Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, ios-revie...@chromium.org, browser-comp...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Attention needed from Camille Lamy

Emmanuel Romero Ruiz voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Camille Lamy

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 31, 2026, 4:07:14 PM (2 days ago) Mar 31

to Emmanuel Romero Ruiz, Liang Zhao, Fabio Rocha, Takashi Toyoshima, Raphael Kubo da Costa, Camille Lamy, Arthur Sonzogni, AyeAye, chromium...@chromium.org, Kentaro Hara, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, ios-revie...@chromium.org, browser-comp...@chromium.org, speed-metrics...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[JS Self-Profiling] Allow safe markers in non-isolated contexts

This CL moves marker exposure logic from IDL to runtime, enabling layout
and style markers in non-Cross-Origin-Isolated contexts.

Previously, all markers required COI through the IDL attribute. Now
ProfilerTraceBuilder filters markers at runtime based on both the
feature flag and the execution context's isolation status.

Changes:
- Remove [CrossOriginIsolated] IDL attribute from profiler_sample.idl;
  marker field is now always exposed to JS
- Add GetMarker() method for runtime marker filtering
- Implement ProfileMarkerToPublicMarker() for safe marker selection
- Cache COI status in ProfilerTraceBuilder at construction time
- Check ExperimentalJSProfilerMarkersEnabled flag at runtime to filter
  markers

Marker availability:
- COI contexts: All markers (gc, layout, paint, script, style)
- Non-COI contexts: Only layout and style markers
- Feature disabled: No markers exposed

Layout and style markers are safe without COI because their timing is
already observable through:
- Layout: getBoundingClientRect(), offsetHeight, ResizeObserver
- Style: getComputedStyle(), MutationObserver, CSSOM

This provides useful performance data in regular contexts while keeping
sensitive markers behind COI.

Bug: 496907118

Change-Id: I424fdfffaa5d102badc0ecc2c7c19cc7e7c27c34

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6012522

Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>

Reviewed-by: Liang Zhao <lz...@microsoft.com>

Commit-Queue: Emmanuel Romero Ruiz <emro...@microsoft.com>

Reviewed-by: Fabio Rocha <fabio...@microsoft.com>

Cr-Commit-Position: refs/heads/main@{#1608049}

Files:

M third_party/blink/renderer/bindings/core/v8/profiler_trace_builder.cc
M third_party/blink/renderer/bindings/core/v8/profiler_trace_builder.h
M third_party/blink/renderer/bindings/core/v8/profiler_trace_builder_test.cc
M third_party/blink/renderer/core/timing/profiler_sample.idl

Change size: M

Delta: 4 files changed, 141 insertions(+), 8 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Takashi Toyoshima, +1 by Liang Zhao, +1 by Fabio Rocha

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[JS Self-Profiling] Allow safe markers in non-isolated contexts [chromium/src : main]

Emmanuel Romero Ruiz (Gerrit)

Emmanuel Romero Ruiz added 1 comment

Related details

Emmanuel Romero Ruiz (Gerrit)

Emmanuel Romero Ruiz added 1 comment

Related details

Emmanuel Romero Ruiz (Gerrit)

Emmanuel Romero Ruiz added 1 comment

Related details

Emmanuel Romero Ruiz (Gerrit)

Emmanuel Romero Ruiz added 1 comment

Related details

Takashi Toyoshima (Gerrit)

Takashi Toyoshima added 7 comments

Related details

Emmanuel Romero Ruiz (Gerrit)

Emmanuel Romero Ruiz added 8 comments

Related details

Takashi Toyoshima (Gerrit)

Takashi Toyoshima voted Code-Review+1

Related details

Fabio Rocha (Gerrit)

Fabio Rocha voted Code-Review+1

Related details

Emmanuel Romero Ruiz (Gerrit)

Emmanuel Romero Ruiz voted Commit-Queue+2

Related details

Liang Zhao (Gerrit)

Liang Zhao added 1 comment

Related details

Emmanuel Romero Ruiz (Gerrit)

Emmanuel Romero Ruiz voted and added 1 comment

Votes added by Emmanuel Romero Ruiz

1 comment

Related details

Liang Zhao (Gerrit)

Liang Zhao voted Code-Review+1

Related details

Emmanuel Romero Ruiz (Gerrit)

Emmanuel Romero Ruiz voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information