[WebAuthn] Add uiMode to CredentialRequestOptions [chromium/src : main]

0 views
Skip to first unread message

Ken Buchanan (Gerrit)

unread,
Nov 11, 2025, 3:35:03 PM (11 days ago) Nov 11
to Adem Derinel, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Adem Derinel

Ken Buchanan voted and added 1 comment

Votes added by Ken Buchanan

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ken Buchanan . resolved

PTAL?

Open in Gerrit

Related details

Attention is currently required from:
  • Adem Derinel
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If3e6543244624d837b1b0421fad837baf5cd893d
Gerrit-Change-Number: 7143038
Gerrit-PatchSet: 1
Gerrit-Owner: Ken Buchanan <ke...@chromium.org>
Gerrit-Reviewer: Adem Derinel <der...@google.com>
Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Adem Derinel <der...@google.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 20:34:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Adem Derinel (Gerrit)

unread,
Nov 12, 2025, 2:27:25 AM (11 days ago) Nov 12
to Ken Buchanan, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Ken Buchanan

Adem Derinel added 1 comment

File third_party/blink/renderer/modules/credentialmanagement/authentication_credentials_container.cc
Line 1075, Patchset 1 (Latest): if (RuntimeEnabledFeatures::WebAuthenticationUiModeEnabled(&context) &&
options.hasUiMode() &&
options.uiMode() == V8CredentialUiModeRequirement::Enum::kImmediate) {
return true;
}
Adem Derinel . unresolved

Should we consider checking for the mediation here too? I think we should reject the invalid combinations (e.g. mediation: "conditional" && uiMode: "immediate").

Open in Gerrit

Related details

Attention is currently required from:
  • Ken Buchanan
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If3e6543244624d837b1b0421fad837baf5cd893d
    Gerrit-Change-Number: 7143038
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ken Buchanan <ke...@chromium.org>
    Gerrit-Reviewer: Adem Derinel <der...@google.com>
    Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
    Gerrit-Comment-Date: Wed, 12 Nov 2025 07:27:03 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Adem Derinel (Gerrit)

    unread,
    Nov 12, 2025, 3:40:55 AM (11 days ago) Nov 12
    to Ken Buchanan, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
    Attention needed from Ken Buchanan

    Adem Derinel added 1 comment

    File third_party/blink/renderer/platform/runtime_enabled_features.json5
    Line 5648, Patchset 1 (Latest): name: "WebAuthenticationUiMode",
    Adem Derinel . unresolved

    This may be `CredentialManagerUiMode`, but I don't have strong preference.

    Gerrit-Comment-Date: Wed, 12 Nov 2025 08:40:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ken Buchanan (Gerrit)

    unread,
    Nov 12, 2025, 2:08:50 PM (10 days ago) Nov 12
    to Adem Derinel, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
    Attention needed from Adem Derinel

    Ken Buchanan added 2 comments

    File third_party/blink/renderer/modules/credentialmanagement/authentication_credentials_container.cc
    Line 1075, Patchset 1: if (RuntimeEnabledFeatures::WebAuthenticationUiModeEnabled(&context) &&

    options.hasUiMode() &&
    options.uiMode() == V8CredentialUiModeRequirement::Enum::kImmediate) {
    return true;
    }
    Adem Derinel . resolved

    Should we consider checking for the mediation here too? I think we should reject the invalid combinations (e.g. mediation: "conditional" && uiMode: "immediate").

    Ken Buchanan

    I've added a `CHECK` for that, because the check for immediate is after the check for conditional, and there it now throws an exception if someone specified both.

    File third_party/blink/renderer/platform/runtime_enabled_features.json5
    Line 5648, Patchset 1: name: "WebAuthenticationUiMode",
    Adem Derinel . resolved

    This may be `CredentialManagerUiMode`, but I don't have strong preference.

    Ken Buchanan

    I have a slight preference for the current name because it's being developed initially for passkeys primarily, and the flag should be gone by the time there are trials for other types.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adem Derinel
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If3e6543244624d837b1b0421fad837baf5cd893d
      Gerrit-Change-Number: 7143038
      Gerrit-PatchSet: 1
      Gerrit-Owner: Ken Buchanan <ke...@chromium.org>
      Gerrit-Reviewer: Adem Derinel <der...@google.com>
      Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
      Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
      Gerrit-CC: Kaan Icer <ic...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Adem Derinel <der...@google.com>
      Gerrit-Comment-Date: Wed, 12 Nov 2025 19:08:44 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Adem Derinel <der...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Adem Derinel (Gerrit)

      unread,
      Nov 13, 2025, 2:17:52 AM (10 days ago) Nov 13
      to Ken Buchanan, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
      Attention needed from Ken Buchanan

      Adem Derinel voted and added 2 comments

      Votes added by Adem Derinel

      Code-Review+1

      2 comments

      Patchset-level comments
      File-level comment, Patchset 3 (Latest):
      Adem Derinel . resolved

      lgtm, thanks!

      File third_party/blink/renderer/platform/runtime_enabled_features.json5
      Line 5648, Patchset 1: name: "WebAuthenticationUiMode",
      Adem Derinel . resolved

      This may be `CredentialManagerUiMode`, but I don't have strong preference.

      Ken Buchanan

      I have a slight preference for the current name because it's being developed initially for passkeys primarily, and the flag should be gone by the time there are trials for other types.

      Adem Derinel

      sounds good

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Ken Buchanan
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: If3e6543244624d837b1b0421fad837baf5cd893d
        Gerrit-Change-Number: 7143038
        Gerrit-PatchSet: 3
        Gerrit-Owner: Ken Buchanan <ke...@chromium.org>
        Gerrit-Reviewer: Adem Derinel <der...@google.com>
        Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
        Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
        Gerrit-CC: Kaan Icer <ic...@chromium.org>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
        Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
        Gerrit-Comment-Date: Thu, 13 Nov 2025 07:17:31 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Ken Buchanan <ke...@chromium.org>
        Comment-In-Reply-To: Adem Derinel <der...@google.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Ken Buchanan (Gerrit)

        unread,
        Nov 13, 2025, 8:53:31 AM (9 days ago) Nov 13
        to Dave Tapuska, Adem Derinel, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
        Attention needed from Dave Tapuska

        Ken Buchanan added 1 comment

        Patchset-level comments
        Ken Buchanan . resolved

        dtapuska@: PTAL third_party/blink/renderer/platform/runtime_enabled_features.json5?

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Dave Tapuska
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: If3e6543244624d837b1b0421fad837baf5cd893d
        Gerrit-Change-Number: 7143038
        Gerrit-PatchSet: 3
        Gerrit-Owner: Ken Buchanan <ke...@chromium.org>
        Gerrit-Reviewer: Adem Derinel <der...@google.com>
        Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
        Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
        Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
        Gerrit-CC: Kaan Icer <ic...@chromium.org>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
        Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
        Gerrit-Comment-Date: Thu, 13 Nov 2025 13:53:18 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Dave Tapuska (Gerrit)

        unread,
        Nov 13, 2025, 11:37:59 AM (9 days ago) Nov 13
        to Ken Buchanan, Adem Derinel, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
        Attention needed from Ken Buchanan

        Dave Tapuska voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Ken Buchanan
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: If3e6543244624d837b1b0421fad837baf5cd893d
        Gerrit-Change-Number: 7143038
        Gerrit-PatchSet: 3
        Gerrit-Owner: Ken Buchanan <ke...@chromium.org>
        Gerrit-Reviewer: Adem Derinel <der...@google.com>
        Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
        Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
        Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
        Gerrit-CC: Kaan Icer <ic...@chromium.org>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
        Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
        Gerrit-Comment-Date: Thu, 13 Nov 2025 16:37:52 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Ken Buchanan (Gerrit)

        unread,
        Nov 13, 2025, 11:38:39 AM (9 days ago) Nov 13
        to Dave Tapuska, Adem Derinel, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org

        Ken Buchanan voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: If3e6543244624d837b1b0421fad837baf5cd893d
        Gerrit-Change-Number: 7143038
        Gerrit-PatchSet: 3
        Gerrit-Owner: Ken Buchanan <ke...@chromium.org>
        Gerrit-Reviewer: Adem Derinel <der...@google.com>
        Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
        Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
        Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
        Gerrit-CC: Kaan Icer <ic...@chromium.org>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
        Gerrit-Comment-Date: Thu, 13 Nov 2025 16:38:31 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Nov 13, 2025, 12:26:31 PM (9 days ago) Nov 13
        to Ken Buchanan, Dave Tapuska, Adem Derinel, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Kaan Icer, Raphael Kubo da Costa, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        [WebAuthn] Add uiMode to CredentialRequestOptions

        This adds `uiMode` to `CredentialRequestOptions`, which will be the
        mechanism to turn on Immediate FLUX requests. Currently Immediate
        exists as a Mediation value, which will remain valid for the duration
        of the origin trial, but will be switched fully to `uiMode` before
        shipping.

        It is behind a flag, enabled by experimental web platform features.
        Bug: 459517287
        Change-Id: If3e6543244624d837b1b0421fad837baf5cd893d
        Commit-Queue: Ken Buchanan <ke...@chromium.org>
        Reviewed-by: Adem Derinel <der...@google.com>
        Reviewed-by: Dave Tapuska <dtap...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1544326}
        Files:
        • M third_party/blink/public/mojom/webauthn/authenticator.mojom
        • M third_party/blink/renderer/bindings/generated_in_modules.gni
        • M third_party/blink/renderer/modules/credentialmanagement/authentication_credentials_container.cc
        • M third_party/blink/renderer/modules/credentialmanagement/credential_request_options.idl
        • M third_party/blink/renderer/platform/runtime_enabled_features.json5
        Change size: M
        Delta: 5 files changed, 54 insertions(+), 24 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Dave Tapuska, +1 by Adem Derinel
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: If3e6543244624d837b1b0421fad837baf5cd893d
        Gerrit-Change-Number: 7143038
        Gerrit-PatchSet: 4
        Gerrit-Owner: Ken Buchanan <ke...@chromium.org>
        Gerrit-Reviewer: Adem Derinel <der...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
        Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
        Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages