Speculative load measurement API [chromium/src : main]

38 views

Skip to first unread message

Yoav Weiss (@Shopify) (Gerrit)

unread,

Feb 2, 2026, 9:08:40 AMFeb 2

to Hiroshige Hayashizaki, AyeAye, Barry Pollard, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, prerendering-reviews, ashleynewson+w...@chromium.org, android-web...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, tburkar...@chromium.org

Attention needed from Hiroshige Hayashizaki

Yoav Weiss (@Shopify) added 1 comment

Patchset-level comments

File-level comment, Patchset 20 (Latest):

Yoav Weiss (@Shopify) . resolved

Hey hiroshige@! I'd love your thoughts on this, at all levels: from the proposal itself to the feature's design to its implementation.

Let me know if breaking this CL up to smaller chunks can help.

Open in Gerrit

Related details

Attention is currently required from:

Hiroshige Hayashizaki

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kouhei Ueno (Gerrit)

unread,

2:08 AM (22 hours ago) 2:08 AM

to Yoav Weiss (@Shopify), Hiroshige Hayashizaki, AyeAye, Barry Pollard, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, prerendering-reviews, ashleynewson+w...@chromium.org, android-web...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, tburkar...@chromium.org

Attention needed from Hiroshige Hayashizaki and Yoav Weiss (@Shopify)

Kouhei Ueno added 2 comments

Patchset-level comments

File-level comment, Patchset 25 (Latest):

Kouhei Ueno . resolved

Sorry for the slow review. Would you split preload part?

Highlevel:

[non-OT blocking] I don't believe pagehide event is the right place to expose this. However, OT is about testing API, so I'm good proceeding OT for now. I do want to have discussion on this before shipping.
[non-OT blocking, to be discussed on SpeculationRules split CL] I'm very hesitant to expose `use` and duplicating the NVS match logic in renderer side. Barry informed me that the navigation to URL was recently exposed: https://html.spec.whatwg.org/#dom-navigationtransition-to . Can we have web author implement the check themselves if they already have access to?

File third_party/blink/renderer/core/events/preload.h

Line 17, Patchset 25 (Latest):class Preload final : public ScriptWrappable {

Kouhei Ueno . unresolved

Please add class comment referencing this is for https://github.com/yoavweiss/speculative_load_measurement