Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
HeapVector<Member<RTCRtpAcks>> readReceivedAcks(uint32_t maxCount);
Put the web-exposed methods together and add a comment to mark them as such (i.e., `//Implements Foo` or `// Implements foo.idl` or whatever style you prefer).
May apply to other files in the CL.
PostCrossThreadTask(
Does it make sense to call synchronously if you're already in the destination task runner?
// TODO: crbug.com/345101934 - This needs to actually be on some Worker-exposed
nit: Not required, but would be nice to wrap at 80 columns
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
HeapVector<Member<RTCRtpAcks>> readReceivedAcks(uint32_t maxCount);
Put the web-exposed methods together and add a comment to mark them as such (i.e., `//Implements Foo` or `// Implements foo.idl` or whatever style you prefer).
May apply to other files in the CL.
Done here and in rtc_rtp_send.h
PostCrossThreadTask(
Does it make sense to call synchronously if you're already in the destination task runner?
In practice this is always called from the WebRTC worker thread (via InterceptingNetworkController::OnSentPacket), so I don't think it's worth the complexity. Actually, might be better to make that explicit - added a CHECK.
// TODO: crbug.com/345101934 - This needs to actually be on some Worker-exposed
nit: Not required, but would be nice to wrap at 80 columns
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
// TODO(crbug.com/345101934): This needs to actually be on some
super optional nit: keep the new TODO format? (BTW, I like the old one better and AFAIK it's still acceptable).
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
// TODO(crbug.com/345101934): This needs to actually be on some
super optional nit: keep the new TODO format? (BTW, I like the old one better and AFAIK it's still acceptable).
Heh, yeah, I've had this back and forward with a few different people recently. Discovered https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/todos.md explicitly saying `TODO(crbug.com/40192027):` is preferred in chromium (and I prefer it too).
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit-Queue | +2 |
I'll go ahead with landing this to unblock the later prototyping, but feel free to add comments Philip and I can fix them in followup prototype impl cls.
Thanks
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Prototype implementation of RtpTransport::readSentRtp() batch read api
See https://github.com/w3c/webrtc-rtptransport/pull/42 and https://github.com/w3c/webrtc-rtptransport/blob/main/explainer-use-case-2.md.
Would be used to allow BWE JS implementations to listen to the actual
sent times of RTP packets, for comparison with readReceivedRtpAcks().
All guarded by the blink feature RTCRtpTransport.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |