DONOTSUBMIT: prototype of new inline script cache [chromium/src : main]

0 views
Skip to first unread message

Kouhei Ueno (Gerrit)

unread,
Jan 28, 2026, 8:45:30 PMJan 28
to Takashi Nakayama, AyeAye, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, dom+...@chromium.org, dullweb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, msrame...@chromium.org, navigation...@chromium.org
Attention needed from Takashi Nakayama

Kouhei Ueno added 1 comment

File third_party/blink/renderer/bindings/core/v8/v8_code_cache.cc
Line 389, Patchset 1 (Latest): no_cache_reason = v8::ScriptCompiler::kNoCacheBecauseInlineScript;
Kouhei Ueno . unresolved

Sorry this is about the existing code.
Should we add a comment somewhere that this no_cache_reason is only recorded if we actually end up cache miss?

Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Nakayama
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I71d0cd0c669905215a78c1789ba8c7833005bdbc
Gerrit-Change-Number: 7525689
Gerrit-PatchSet: 1
Gerrit-Owner: Takashi Nakayama <tn...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Takashi Nakayama <tn...@chromium.org>
Gerrit-Comment-Date: Thu, 29 Jan 2026 01:44:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

AI Code Reviewer (Gerrit)

unread,
Jan 28, 2026, 8:47:05 PMJan 28
to Takashi Nakayama, Kouhei Ueno, AyeAye, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, dom+...@chromium.org, dullweb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, msrame...@chromium.org, navigation...@chromium.org
Attention needed from Takashi Nakayama

AI Code Reviewer added 2 comments

File third_party/blink/renderer/platform/loader/fetch/code_cache_host.cc
Line 556, Patchset 1 (Latest): base::Lock lock_;
AI Code Reviewer . unresolved

Blink Style Guide: Threading model. A shared memory model (e.g., using mutex locks or atomics) is strongly discouraged in Blink. Cross-thread communication should be done with a message passing model.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

File third_party/blink/renderer/platform/loader/fetch/script_cached_metadata_handler.cc
Line 29, Patchset 1 (Latest):void lookupOrCalculateHash(
AI Code Reviewer . unresolved

Blink Style Guide: Naming - Use 'CamelCase' for all function names. Function names should begin with an uppercase letter (e.g., 'LookupOrCalculateHash').

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Nakayama
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I71d0cd0c669905215a78c1789ba8c7833005bdbc
Gerrit-Change-Number: 7525689
Gerrit-PatchSet: 1
Gerrit-Owner: Takashi Nakayama <tn...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kouhei Ueno <kou...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Takashi Nakayama <tn...@chromium.org>
Gerrit-Comment-Date: Thu, 29 Jan 2026 01:47:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Takashi Nakayama (Gerrit)

unread,
Mar 31, 2026, 12:22:06 PM (2 days ago) Mar 31
to Chromium LUCI CQ, AI Code Reviewer, Kouhei Ueno, AyeAye, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, blink-work...@chromium.org, shimazu...@chromium.org, kinuko...@chromium.org, horo+...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, dom+...@chromium.org, dullweb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, msrame...@chromium.org, navigation...@chromium.org

Takashi Nakayama abandoned this change.

View Change

Abandoned

Takashi Nakayama abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I71d0cd0c669905215a78c1789ba8c7833005bdbc
Gerrit-Change-Number: 7525689
Gerrit-PatchSet: 15
Gerrit-Owner: Takashi Nakayama <tn...@chromium.org>
Gerrit-Reviewer: Takashi Nakayama <tn...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages