Introduce NavigatorStorageBuckets mixin for storageBuckets [chromium/src : main]

0 views
Skip to first unread message

Suyeon Ji (Gerrit)

unread,
Oct 26, 2025, 11:17:16 PM (6 days ago) Oct 26
to Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Suyeon Ji

Message from Suyeon Ji

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Suyeon Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I95648f437ce080da1a87a4e74fd4c712cfd676d0
Gerrit-Change-Number: 7082624
Gerrit-PatchSet: 1
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
Gerrit-Comment-Date: Mon, 27 Oct 2025 03:16:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Suyeon Ji (Gerrit)

unread,
Oct 26, 2025, 11:18:09 PM (6 days ago) Oct 26
to Fergal Daly, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Fergal Daly and Kentaro Hara

Suyeon Ji added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Suyeon Ji . resolved

Hi!, please take a look. Thanks a lot.

Open in Gerrit

Related details

Attention is currently required from:
  • Fergal Daly
  • Kentaro Hara
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I95648f437ce080da1a87a4e74fd4c712cfd676d0
Gerrit-Change-Number: 7082624
Gerrit-PatchSet: 1
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Fergal Daly <fer...@chromium.org>
Gerrit-Comment-Date: Mon, 27 Oct 2025 03:17:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kentaro Hara (Gerrit)

unread,
Oct 26, 2025, 11:33:05 PM (6 days ago) Oct 26
to Suyeon Ji, Fergal Daly, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Fergal Daly and Suyeon Ji

Kentaro Hara voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fergal Daly
  • Suyeon Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I95648f437ce080da1a87a4e74fd4c712cfd676d0
Gerrit-Change-Number: 7082624
Gerrit-PatchSet: 1
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
Gerrit-Attention: Fergal Daly <fer...@chromium.org>
Gerrit-Comment-Date: Mon, 27 Oct 2025 03:32:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fergal Daly (Gerrit)

unread,
Oct 27, 2025, 12:25:09 AM (6 days ago) Oct 27
to Suyeon Ji, Fergal Daly, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Suyeon Ji

Fergal Daly voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Suyeon Ji
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I95648f437ce080da1a87a4e74fd4c712cfd676d0
    Gerrit-Change-Number: 7082624
    Gerrit-PatchSet: 1
    Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
    Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
    Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
    Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
    Gerrit-Comment-Date: Mon, 27 Oct 2025 04:24:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Suyeon Ji (Gerrit)

    unread,
    Oct 27, 2025, 1:15:47 AM (6 days ago) Oct 27
    to Fergal Daly, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

    Suyeon Ji voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I95648f437ce080da1a87a4e74fd4c712cfd676d0
    Gerrit-Change-Number: 7082624
    Gerrit-PatchSet: 1
    Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
    Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
    Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
    Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Comment-Date: Mon, 27 Oct 2025 05:15:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Oct 27, 2025, 2:22:58 AM (6 days ago) Oct 27
    to Suyeon Ji, Fergal Daly, Kentaro Hara, chromium...@chromium.org, Raphael Kubo da Costa, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Introduce NavigatorStorageBuckets mixin for storageBuckets

    This patch migrates partial interfaces to a interface mixin to align
    with the specification.

    Originally, these partial interfaces were introduced as a workaround for
    a layering violation between core/ and modules/, since Blink could not
    include mixins across those layers.

    Now that the IDL compiler supports cross-component mixins[1], the
    workaround is no longer needed, and this patch replaces the partial
    interfaces with an interface mixin to follow the spec[2].

    This CL has no behavior changes.

    [1] https://chromium-review.googlesource.com/c/chromium/src/+/6968299
    [2] https://wicg.github.io/storage-buckets
    Bug: 453570181
    Change-Id: I95648f437ce080da1a87a4e74fd4c712cfd676d0
    Reviewed-by: Kentaro Hara <har...@chromium.org>
    Reviewed-by: Fergal Daly <fer...@chromium.org>
    Commit-Queue: Suyeon Ji <zees...@gmail.com>
    Cr-Commit-Position: refs/heads/main@{#1535748}
    Files:
    • M third_party/blink/renderer/bindings/idl_in_modules.gni
    • M third_party/blink/renderer/modules/buckets/navigator_storage_buckets.idl
    • D third_party/blink/renderer/modules/buckets/worker_navigator_storage_buckets.idl
    Change size: S
    Delta: 3 files changed, 4 insertions(+), 16 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kentaro Hara, +1 by Fergal Daly
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I95648f437ce080da1a87a4e74fd4c712cfd676d0
    Gerrit-Change-Number: 7082624
    Gerrit-PatchSet: 2
    Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fergal Daly <fer...@chromium.org>
    Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
    Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages