Refactor crypto to use WindowOrWorkerGlobalScope partial mixin [chromium/src : main]

0 views
Skip to first unread message

Suyeon Ji (Gerrit)

unread,
Oct 9, 2025, 11:34:20 AMOct 9
to Kentaro Hara, Jinho Bang, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Jinho Bang and Kentaro Hara

Suyeon Ji added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Suyeon Ji . resolved

Hi, Please take a look. Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Jinho Bang
  • Kentaro Hara
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
Gerrit-Change-Number: 7005133
Gerrit-PatchSet: 6
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Jinho Bang <zi...@chromium.org>
Gerrit-Attention: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Oct 2025 15:32:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kentaro Hara (Gerrit)

unread,
Oct 9, 2025, 7:44:43 PMOct 9
to Suyeon Ji, Jinho Bang, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Jinho Bang and Suyeon Ji

Kentaro Hara voted and added 1 comment

Votes added by Kentaro Hara

Code-Review+1

1 comment

Patchset-level comments
Kentaro Hara . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Jinho Bang
  • Suyeon Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
Gerrit-Change-Number: 7005133
Gerrit-PatchSet: 6
Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
Gerrit-Attention: Jinho Bang <zi...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Oct 2025 23:42:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jinho Bang (Gerrit)

unread,
Oct 9, 2025, 11:29:34 PMOct 9
to Suyeon Ji, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Suyeon Ji

Jinho Bang voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Suyeon Ji
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
    Gerrit-Change-Number: 7005133
    Gerrit-PatchSet: 6
    Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
    Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
    Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
    Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
    Gerrit-Comment-Date: Fri, 10 Oct 2025 03:27:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Jinho Bang (Gerrit)

    unread,
    Oct 10, 2025, 1:10:17 AMOct 10
    to Suyeon Ji, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
    Attention needed from Suyeon Ji

    Jinho Bang added 1 comment

    Patchset-level comments
    Gerrit-Comment-Date: Fri, 10 Oct 2025 05:08:12 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Suyeon Ji (Gerrit)

    unread,
    Nov 11, 2025, 1:16:03 PM (11 days ago) Nov 11
    to Jinho Bang, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
    Attention needed from Jinho Bang and Kentaro Hara

    Suyeon Ji added 1 comment

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Suyeon Ji . resolved

    Hi,
    The previous failure was caused by an IDL compiler issue[1], which has been fixed.
    After rebasing, the patch passes successfully now. Could you please take another look and vote again?

    [1] https://chromium-review.googlesource.com/c/chromium/src/+/7109359

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jinho Bang
    • Kentaro Hara
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
      Gerrit-Change-Number: 7005133
      Gerrit-PatchSet: 7
      Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
      Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
      Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
      Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Jinho Bang <zi...@chromium.org>
      Gerrit-Attention: Kentaro Hara <har...@chromium.org>
      Gerrit-Comment-Date: Tue, 11 Nov 2025 18:15:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nate Chapin (Gerrit)

      unread,
      Nov 11, 2025, 2:14:51 PM (11 days ago) Nov 11
      to Suyeon Ji, Jinho Bang, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
      Attention needed from Jinho Bang, Kentaro Hara and Suyeon Ji

      Nate Chapin added 1 comment

      File third_party/blink/renderer/modules/crypto/global_crypto.cc
      Line 45, Patchset 7 (Latest): public Supplement<T> {
      Nate Chapin . unresolved

      Drive-by: Supplement<ExecutionContext> is a good option instead of templating, as it's a parent class of both `LocalDOMWindow` and `WorkerGlobalScope`. You end up implicitly being a Supplement of some other types you don't need (e.g., worklet), but you can use CHECKs to verify that you're only actually registering for the intended `ExecutionContext` subclasses.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Jinho Bang
      • Kentaro Hara
      • Suyeon Ji
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
        Gerrit-Change-Number: 7005133
        Gerrit-PatchSet: 7
        Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
        Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
        Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
        Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
        Gerrit-CC: Nate Chapin <jap...@chromium.org>
        Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
        Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
        Gerrit-Attention: Jinho Bang <zi...@chromium.org>
        Gerrit-Attention: Kentaro Hara <har...@chromium.org>
        Gerrit-Comment-Date: Tue, 11 Nov 2025 19:14:42 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Suyeon Ji (Gerrit)

        unread,
        Nov 13, 2025, 8:12:35 AM (9 days ago) Nov 13
        to Nate Chapin, Jinho Bang, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
        Attention needed from Jinho Bang, Kentaro Hara and Nate Chapin

        Suyeon Ji added 1 comment

        File third_party/blink/renderer/modules/crypto/global_crypto.cc
        Line 45, Patchset 7 (Latest): public Supplement<T> {
        Nate Chapin . resolved

        Drive-by: Supplement<ExecutionContext> is a good option instead of templating, as it's a parent class of both `LocalDOMWindow` and `WorkerGlobalScope`. You end up implicitly being a Supplement of some other types you don't need (e.g., worklet), but you can use CHECKs to verify that you're only actually registering for the intended `ExecutionContext` subclasses.

        Suyeon Ji

        Thanks for the suggestion!
        I want to confirm that I understood your point correctly. My understanding is that you are recommending Supplement<ExecutionContext> to keep the structure simple, while using CHECKs to ensure that it is only used with the intended subclasses such as LocalDOMWindow and WorkerGlobalScope, even though it technically becomes attachable to other ExecutionContext subclasses.

        I also wanted to ask whether this approach is generally preferred in Chromium for this type of supplement. I referenced existing partial mixin implementations that use a templated Supplement<T> pattern, and some of my patches following that style have already landed. If the ExecutionContext-based approach is preferred, I can adjust my upcoming patches accordingly.

        Thanks again!

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Jinho Bang
        • Kentaro Hara
        • Nate Chapin
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
          Gerrit-Change-Number: 7005133
          Gerrit-PatchSet: 7
          Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
          Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
          Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
          Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
          Gerrit-CC: Nate Chapin <jap...@chromium.org>
          Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
          Gerrit-Attention: Jinho Bang <zi...@chromium.org>
          Gerrit-Attention: Nate Chapin <jap...@chromium.org>
          Gerrit-Attention: Kentaro Hara <har...@chromium.org>
          Gerrit-Comment-Date: Thu, 13 Nov 2025 13:12:03 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Nate Chapin <jap...@chromium.org>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Nate Chapin (Gerrit)

          unread,
          Nov 13, 2025, 4:52:20 PM (9 days ago) Nov 13
          to Suyeon Ji, Jinho Bang, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
          Attention needed from Jinho Bang, Kentaro Hara and Suyeon Ji

          Nate Chapin added 1 comment

          File third_party/blink/renderer/modules/crypto/global_crypto.cc
          Line 45, Patchset 7 (Latest): public Supplement<T> {
          Nate Chapin . resolved

          Drive-by: Supplement<ExecutionContext> is a good option instead of templating, as it's a parent class of both `LocalDOMWindow` and `WorkerGlobalScope`. You end up implicitly being a Supplement of some other types you don't need (e.g., worklet), but you can use CHECKs to verify that you're only actually registering for the intended `ExecutionContext` subclasses.

          Suyeon Ji

          Thanks for the suggestion!
          I want to confirm that I understood your point correctly. My understanding is that you are recommending Supplement<ExecutionContext> to keep the structure simple, while using CHECKs to ensure that it is only used with the intended subclasses such as LocalDOMWindow and WorkerGlobalScope, even though it technically becomes attachable to other ExecutionContext subclasses.

          I also wanted to ask whether this approach is generally preferred in Chromium for this type of supplement. I referenced existing partial mixin implementations that use a templated Supplement<T> pattern, and some of my patches following that style have already landed. If the ExecutionContext-based approach is preferred, I can adjust my upcoming patches accordingly.

          Thanks again!

          Nate Chapin

          I think, between the two approaches, I would lean toward `Supplement<ExecutionContext>`.

          However, an effort just started to get rid of Supplement/Supplementable entirely (https://groups.google.com/a/chromium.org/g/blink-dev/c/nbTIoUZW6n0). So probably the optimal thing to do would be to follow the pattern that is being put in to place. Which means you may be able to put this class on `WindowOrWorkerGlobalScope` in C++?(https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/frame/window_or_worker_global_scope.h)

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Jinho Bang
          • Kentaro Hara
          • Suyeon Ji
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
          Gerrit-Change-Number: 7005133
          Gerrit-PatchSet: 7
          Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
          Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
          Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
          Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
          Gerrit-CC: Nate Chapin <jap...@chromium.org>
          Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
          Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
          Gerrit-Attention: Jinho Bang <zi...@chromium.org>
          Gerrit-Attention: Kentaro Hara <har...@chromium.org>
          Gerrit-Comment-Date: Thu, 13 Nov 2025 21:52:10 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Suyeon Ji <zees...@gmail.com>
          Comment-In-Reply-To: Nate Chapin <jap...@chromium.org>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Suyeon Ji (Gerrit)

          unread,
          Nov 19, 2025, 1:58:09 AM (4 days ago) Nov 19
          to AyeAye, Nate Chapin, Jinho Bang, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, kinuko...@chromium.org, blink-work...@chromium.org, blink-revi...@chromium.org, horo+...@chromium.org, shimazu...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
          Attention needed from Jinho Bang, Kentaro Hara and Suyeon Ji

          Message from Suyeon Ji

          Set Ready For Review

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Jinho Bang
          • Kentaro Hara
          • Suyeon Ji
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
          Gerrit-Change-Number: 7005133
          Gerrit-PatchSet: 14
          Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
          Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
          Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
          Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
          Gerrit-CC: Nate Chapin <jap...@chromium.org>
          Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
          Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
          Gerrit-Attention: Jinho Bang <zi...@chromium.org>
          Gerrit-Attention: Kentaro Hara <har...@chromium.org>
          Gerrit-Comment-Date: Wed, 19 Nov 2025 06:57:34 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: No
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Kentaro Hara (Gerrit)

          unread,
          Nov 19, 2025, 3:44:02 AM (4 days ago) Nov 19
          to Suyeon Ji, AyeAye, Nate Chapin, Jinho Bang, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, kinuko...@chromium.org, blink-work...@chromium.org, blink-revi...@chromium.org, horo+...@chromium.org, shimazu...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
          Attention needed from Jinho Bang and Suyeon Ji

          Kentaro Hara voted Code-Review+1

          Code-Review+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Jinho Bang
          • Suyeon Ji
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
          Gerrit-Change-Number: 7005133
          Gerrit-PatchSet: 15
          Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
          Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
          Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
          Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
          Gerrit-CC: Nate Chapin <jap...@chromium.org>
          Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
          Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
          Gerrit-Attention: Jinho Bang <zi...@chromium.org>
          Gerrit-Comment-Date: Wed, 19 Nov 2025 08:43:48 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Jinho Bang (Gerrit)

          unread,
          Nov 19, 2025, 3:48:27 AM (4 days ago) Nov 19
          to Suyeon Ji, Kentaro Hara, AyeAye, Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, kinuko...@chromium.org, blink-work...@chromium.org, blink-revi...@chromium.org, horo+...@chromium.org, shimazu...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
          Attention needed from Suyeon Ji

          Jinho Bang voted and added 1 comment

          Votes added by Jinho Bang

          Code-Review+1

          1 comment

          Patchset-level comments
          File-level comment, Patchset 15 (Latest):
          Jinho Bang . resolved

          lgtm but let's wait for Nate's comment.

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Suyeon Ji
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
            Gerrit-Change-Number: 7005133
            Gerrit-PatchSet: 15
            Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
            Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
            Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
            Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
            Gerrit-CC: Nate Chapin <jap...@chromium.org>
            Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
            Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
            Gerrit-Comment-Date: Wed, 19 Nov 2025 08:47:55 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Suyeon Ji (Gerrit)

            unread,
            Nov 20, 2025, 9:26:00 PM (2 days ago) Nov 20
            to Nate Chapin, Jinho Bang, Kentaro Hara, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, kinuko...@chromium.org, blink-work...@chromium.org, blink-revi...@chromium.org, horo+...@chromium.org, shimazu...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
            Attention needed from Jinho Bang, Kentaro Hara and Nate Chapin

            Suyeon Ji added 1 comment

            Patchset-level comments
            File-level comment, Patchset 16 (Latest):
            Suyeon Ji . resolved

            Gentle ping @jap...@chromium.org
            Hi, would it be okay if I ask you for a review?

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Jinho Bang
            • Kentaro Hara
            • Nate Chapin
            Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement is not satisfiedCode-Review
              • requirement is not satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
              Gerrit-Change-Number: 7005133
              Gerrit-PatchSet: 16
              Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
              Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
              Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
              Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
              Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
              Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
              Gerrit-Attention: Jinho Bang <zi...@chromium.org>
              Gerrit-Attention: Nate Chapin <jap...@chromium.org>
              Gerrit-Attention: Kentaro Hara <har...@chromium.org>
              Gerrit-Comment-Date: Fri, 21 Nov 2025 02:25:34 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: No
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Kentaro Hara (Gerrit)

              unread,
              Nov 20, 2025, 11:37:03 PM (2 days ago) Nov 20
              to Suyeon Ji, Nate Chapin, Jinho Bang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, kinuko...@chromium.org, blink-work...@chromium.org, blink-revi...@chromium.org, horo+...@chromium.org, shimazu...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
              Attention needed from Jinho Bang, Nate Chapin and Suyeon Ji

              Kentaro Hara voted Code-Review+1

              Code-Review+1
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Jinho Bang
              • Nate Chapin
              • Suyeon Ji
              Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement is not satisfiedCode-Review
              • requirement is not satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
              Gerrit-Change-Number: 7005133
              Gerrit-PatchSet: 16
              Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
              Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
              Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
              Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
              Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
              Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
              Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
              Gerrit-Attention: Jinho Bang <zi...@chromium.org>
              Gerrit-Attention: Nate Chapin <jap...@chromium.org>
              Gerrit-Comment-Date: Fri, 21 Nov 2025 04:36:50 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Nate Chapin (Gerrit)

              unread,
              Nov 21, 2025, 1:36:57 PM (yesterday) Nov 21
              to Suyeon Ji, Kentaro Hara, Jinho Bang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, kinuko...@chromium.org, blink-work...@chromium.org, blink-revi...@chromium.org, horo+...@chromium.org, shimazu...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
              Attention needed from Jinho Bang and Suyeon Ji

              Nate Chapin voted Code-Review+1

              Code-Review+1
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Jinho Bang
              • Suyeon Ji
              Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: I2f517fcf0e6171e336b0fdc00b47e76e1bb69741
                Gerrit-Change-Number: 7005133
                Gerrit-PatchSet: 16
                Gerrit-Owner: Suyeon Ji <zees...@gmail.com>
                Gerrit-Reviewer: Jinho Bang <zi...@chromium.org>
                Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
                Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
                Gerrit-Reviewer: Suyeon Ji <zees...@gmail.com>
                Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
                Gerrit-Attention: Suyeon Ji <zees...@gmail.com>
                Gerrit-Attention: Jinho Bang <zi...@chromium.org>
                Gerrit-Comment-Date: Fri, 21 Nov 2025 18:36:44 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                open
                diffy
                Reply all
                Reply to author
                Forward
                0 new messages