Revert "WebGPU: Match WGSL syntax for texture component swizzle" [chromium/src : main]
0 views
Skip to first unread message
Fr (Gerrit)
Sep 25, 2025, 9:22:05 AM (11 days ago) Sep 25
to Corentin Wallez, Rubber Stamper, AyeAye, Chromium LUCI CQ, Kai Ninomiya, Raphael Kubo da Costa, Gregg Tavares, chromium...@chromium.org, Kentaro Hara, jmedle...@chromium.org, blink-...@chromium.org, kainin...@chromium.org, cwalle...@chromium.org, blink-revie...@chromium.org
Attention needed from Corentin Wallez and Kai Ninomiya
Fr added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Corentin Wallez
- Kai Ninomiya
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Sep 25, 2025, 9:22:19 AM (11 days ago) Sep 25
to Fr, Corentin Wallez, AyeAye, Chromium LUCI CQ, Kai Ninomiya, Raphael Kubo da Costa, Gregg Tavares, chromium...@chromium.org, Kentaro Hara, jmedle...@chromium.org, blink-...@chromium.org, kainin...@chromium.org, cwalle...@chromium.org, blink-revie...@chromium.org
Attention needed from Corentin Wallez and Kai Ninomiya
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Corentin Wallez
- Kai Ninomiya
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Corentin Wallez (Gerrit)
Sep 25, 2025, 9:28:52 AM (11 days ago) Sep 25
to Fr, Rubber Stamper, AyeAye, Chromium LUCI CQ, Kai Ninomiya, Raphael Kubo da Costa, Gregg Tavares, chromium...@chromium.org, Kentaro Hara, jmedle...@chromium.org, blink-...@chromium.org, kainin...@chromium.org, cwalle...@chromium.org, blink-revie...@chromium.org
Attention needed from Fr and Kai Ninomiya
Corentin Wallez voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Fr
- Kai Ninomiya
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fr (Gerrit)
Sep 25, 2025, 9:29:44 AM (11 days ago) Sep 25
to Corentin Wallez, Rubber Stamper, AyeAye, Chromium LUCI CQ, Kai Ninomiya, Raphael Kubo da Costa, Gregg Tavares, chromium...@chromium.org, Kentaro Hara, jmedle...@chromium.org, blink-...@chromium.org, kainin...@chromium.org, cwalle...@chromium.org, blink-revie...@chromium.org
Attention needed from Kai Ninomiya
Fr voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Kai Ninomiya
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 25, 2025, 11:00:29 AM (11 days ago) Sep 25
to Fr, Corentin Wallez, Rubber Stamper, AyeAye, Kai Ninomiya, Raphael Kubo da Costa, Gregg Tavares, chromium...@chromium.org, Kentaro Hara, jmedle...@chromium.org, blink-...@chromium.org, kainin...@chromium.org, cwalle...@chromium.org, blink-revie...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "WebGPU: Match WGSL syntax for texture component swizzle"
This reverts commit bc29fd445d6788ddb0dfbe7b97ad1b2045de599d.
Reason for revert: It breaks all WebGPU code that uses createView()
as it always returns null
Original change's description:
> WebGPU: Match WGSL syntax for texture component swizzle
>
> Spec PR: https://github.com/gpuweb/gpuweb/pull/5319
> CTS: https://github.com/gpuweb/cts/pull/4427
>
> Change-Id: Ie398159c52e76839c2cd91bbf3ecf04a77568e19
> Bug: 414312052
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6958569
> Reviewed-by: Kai Ninomiya <kai...@chromium.org>
> Commit-Queue: Fr <beaufort...@gmail.com>
> Cr-Commit-Position: refs/heads/main@{#1519112}
Bug: 414312052
Change-Id: I7c7ce98c8805f2049d217cab9e751a601d8570e8
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Reviewed-by: Corentin Wallez <cwa...@chromium.org>
Commit-Queue: Fr <beaufort...@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1520601}
Files:
- M third_party/blink/renderer/bindings/generated_in_modules.gni
- M third_party/blink/renderer/modules/webgpu/dawn_enum_conversions.cc
- M third_party/blink/renderer/modules/webgpu/dawn_enum_conversions.h
- M third_party/blink/renderer/modules/webgpu/gpu_texture.cc
- M third_party/blink/renderer/modules/webgpu/gpu_texture_view_descriptor.idl
Change size: M
Delta: 5 files changed, 47 insertions(+), 55 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Corentin Wallez, Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter McNeeley (Gerrit)
Sep 25, 2025, 2:21:38 PM (10 days ago) Sep 25
to Fr, Chromium LUCI CQ, Corentin Wallez, Rubber Stamper, AyeAye, Kai Ninomiya, Raphael Kubo da Costa, Gregg Tavares, chromium...@chromium.org, Kentaro Hara, jmedle...@chromium.org, blink-...@chromium.org, kainin...@chromium.org, cwalle...@chromium.org, blink-revie...@chromium.org
Peter McNeeley has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages