[v8/metrics] Add some GC metrics split by input mode to UMA [chromium/src : main]

0 views
Skip to first unread message

Michael Lippautz (Gerrit)

unread,
4:21 AM (20 hours ago) 4:21 AM
to Thiabaud Engelbrecht, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Thiabaud Engelbrecht

Michael Lippautz added 4 comments

File tools/metrics/histograms/metadata/v8/histograms.xml
Line 610, Patchset 2 (Latest): enum="GarbageCollectionReason" expires_after="M154">
Michael Lippautz . unresolved

The unit is off here?

Line 612, Patchset 2 (Latest): <owner>etie...@chromium.org</owner>
Michael Lippautz . unresolved

Here and elsewhere: Please also add v8-memory...@google.com here as we want to maintain ownership here when refactoring/moving around metrics.

Line 612, Patchset 2 (Latest): <owner>etie...@chromium.org</owner>
Michael Lippautz . unresolved

Please also add v8-memory...@google.com here as we want to maintain ownership here when refactoring/moving around metrics.

Line 904, Patchset 2 (Latest): enum="GarbageCollectionReason" expires_after="M154">
Michael Lippautz . unresolved

The unit is off here?

Open in Gerrit

Related details

Attention is currently required from:
  • Thiabaud Engelbrecht
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1a4533dffdfd90105b0e92cfcf8cbdbea02e859
Gerrit-Change-Number: 7656532
Gerrit-PatchSet: 2
Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Comment-Date: Thu, 12 Mar 2026 08:21:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Thiabaud Engelbrecht (Gerrit)

unread,
10:14 AM (14 hours ago) 10:14 AM
to Michael Lippautz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Michael Lippautz

Thiabaud Engelbrecht added 4 comments

File tools/metrics/histograms/metadata/v8/histograms.xml
Line 610, Patchset 2: enum="GarbageCollectionReason" expires_after="M154">
Michael Lippautz . resolved

The unit is off here?

Thiabaud Engelbrecht

Done

Line 612, Patchset 2: <owner>etie...@chromium.org</owner>
Michael Lippautz . resolved

Here and elsewhere: Please also add v8-memory...@google.com here as we want to maintain ownership here when refactoring/moving around metrics.

Thiabaud Engelbrecht

Done

Line 612, Patchset 2: <owner>etie...@chromium.org</owner>
Michael Lippautz . resolved

Please also add v8-memory...@google.com here as we want to maintain ownership here when refactoring/moving around metrics.

Thiabaud Engelbrecht

Done

Line 904, Patchset 2: enum="GarbageCollectionReason" expires_after="M154">
Michael Lippautz . resolved

The unit is off here?

Thiabaud Engelbrecht

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1a4533dffdfd90105b0e92cfcf8cbdbea02e859
    Gerrit-Change-Number: 7656532
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Michael Lippautz <mlip...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 14:14:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Michael Lippautz <mlip...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Michael Lippautz (Gerrit)

    unread,
    10:19 AM (14 hours ago) 10:19 AM
    to Thiabaud Engelbrecht, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Thiabaud Engelbrecht

    Michael Lippautz voted and added 3 comments

    Votes added by Michael Lippautz

    Code-Review+1

    3 comments

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Michael Lippautz . resolved

    lgtm

    File tools/metrics/histograms/metadata/v8/histograms.xml
    Line 609, Patchset 3 (Latest):<histogram name="V8.GC.Cycle{Priority}.Full{InputState}" units="MB"
    Michael Lippautz . unresolved

    ms?

    Line 904, Patchset 3 (Latest):<histogram name="V8.GC.Cycle{Priority}.MainThread.Full{InputState}" units="MB"
    Michael Lippautz . unresolved

    ms?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Thiabaud Engelbrecht
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1a4533dffdfd90105b0e92cfcf8cbdbea02e859
    Gerrit-Change-Number: 7656532
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 14:19:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Thiabaud Engelbrecht (Gerrit)

    unread,
    10:23 AM (14 hours ago) 10:23 AM
    to Michael Lippautz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

    Thiabaud Engelbrecht added 2 comments

    File tools/metrics/histograms/metadata/v8/histograms.xml
    Line 609, Patchset 3 (Latest):<histogram name="V8.GC.Cycle{Priority}.Full{InputState}" units="MB"
    Michael Lippautz . resolved

    ms?

    Thiabaud Engelbrecht

    Done

    Line 904, Patchset 3 (Latest):<histogram name="V8.GC.Cycle{Priority}.MainThread.Full{InputState}" units="MB"
    Michael Lippautz . resolved

    ms?

    Thiabaud Engelbrecht

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1a4533dffdfd90105b0e92cfcf8cbdbea02e859
      Gerrit-Change-Number: 7656532
      Gerrit-PatchSet: 3
      Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
      Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Comment-Date: Thu, 12 Mar 2026 14:23:37 +0000
      satisfied_requirement
      open
      diffy

      Thiabaud Engelbrecht (Gerrit)

      unread,
      10:23 AM (14 hours ago) 10:23 AM
      to Michael Lippautz, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

      Thiabaud Engelbrecht voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1a4533dffdfd90105b0e92cfcf8cbdbea02e859
      Gerrit-Change-Number: 7656532
      Gerrit-PatchSet: 3
      Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
      Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Comment-Date: Thu, 12 Mar 2026 14:23:43 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      11:27 AM (13 hours ago) 11:27 AM
      to Thiabaud Engelbrecht, Michael Lippautz, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [v8/metrics] Add some GC metrics split by input mode to UMA
      Bug: 444705203
      Change-Id: Ie1a4533dffdfd90105b0e92cfcf8cbdbea02e859
      Reviewed-by: Michael Lippautz <mlip...@chromium.org>
      Commit-Queue: Thiabaud Engelbrecht <thia...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1598446}
      Files:
      • M third_party/blink/renderer/bindings/core/v8/v8_metrics.cc
      • M tools/metrics/histograms/metadata/v8/histograms.xml
      Change size: M
      Delta: 2 files changed, 77 insertions(+), 0 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Michael Lippautz
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie1a4533dffdfd90105b0e92cfcf8cbdbea02e859
      Gerrit-Change-Number: 7656532
      Gerrit-PatchSet: 4
      Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
      Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages