Revert "Speculative load measurement API - preload tracking" [chromium/src : main]

0 views
Skip to first unread message

Blink W3C Test Autoroller (Gerrit)

unread,
Mar 31, 2026, 5:46:49 AM (2 days ago) Mar 31
to Yoav Weiss (@Shopify), AyeAye, Rubber Stamper, Chromium LUCI CQ, Hiroshige Hayashizaki, Kouhei Ueno, Barry Pollard, Raphael Kubo da Costa, Olga Gerchikov, chromium...@chromium.org, Nate Chapin, Menard, Alexis, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, ashleynewson+w...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Kouhei Ueno

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/58871.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:
  • Hiroshige Hayashizaki
  • Kouhei Ueno
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8e75956bb84a9efb6f0145ccf46baefd6a7099a7
Gerrit-Change-Number: 7714920
Gerrit-PatchSet: 1
Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Barry Pollard <barryp...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
Gerrit-Comment-Date: Tue, 31 Mar 2026 09:46:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Kouhei Ueno (Gerrit)

unread,
Mar 31, 2026, 7:41:55 AM (2 days ago) Mar 31
to Yoav Weiss (@Shopify), AyeAye, Rubber Stamper, Chromium LUCI CQ, Hiroshige Hayashizaki, Blink W3C Test Autoroller, Barry Pollard, Raphael Kubo da Costa, Olga Gerchikov, chromium...@chromium.org, Nate Chapin, Menard, Alexis, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, ashleynewson+w...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Yoav Weiss (@Shopify)

Kouhei Ueno voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hiroshige Hayashizaki
  • Yoav Weiss (@Shopify)
Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Comment-Date: Tue, 31 Mar 2026 11:41:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Yoav Weiss (@Shopify) (Gerrit)

unread,
Mar 31, 2026, 7:51:20 AM (2 days ago) Mar 31
to Kouhei Ueno, AyeAye, Rubber Stamper, Chromium LUCI CQ, Hiroshige Hayashizaki, Blink W3C Test Autoroller, Barry Pollard, Raphael Kubo da Costa, Olga Gerchikov, chromium...@chromium.org, Nate Chapin, Menard, Alexis, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, ashleynewson+w...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, loading...@chromium.org

Yoav Weiss (@Shopify) abandoned this change.

View Change

Abandoned Eventually we're changing this in place https://chromium-review.googlesource.com/c/chromium/src/+/7715319

Yoav Weiss (@Shopify) abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
open
diffy

Yoav Weiss (@Shopify) (Gerrit)

unread,
Mar 31, 2026, 7:52:09 AM (2 days ago) Mar 31
to Kouhei Ueno, AyeAye, Rubber Stamper, Chromium LUCI CQ, Hiroshige Hayashizaki, Blink W3C Test Autoroller, Barry Pollard, Raphael Kubo da Costa, Olga Gerchikov, chromium...@chromium.org, Nate Chapin, Menard, Alexis, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, ashleynewson+w...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, loading...@chromium.org

Yoav Weiss (@Shopify) restored this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: restore
satisfied_requirement
open
diffy

Yoav Weiss (@Shopify) (Gerrit)

unread,
Mar 31, 2026, 7:54:54 AM (2 days ago) Mar 31
to Kouhei Ueno, AyeAye, Rubber Stamper, Chromium LUCI CQ, Hiroshige Hayashizaki, Blink W3C Test Autoroller, Barry Pollard, Raphael Kubo da Costa, Olga Gerchikov, chromium...@chromium.org, Nate Chapin, Menard, Alexis, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, ashleynewson+w...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, loading...@chromium.org

Yoav Weiss (@Shopify) added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Yoav Weiss (@Shopify) . resolved

Given that this was already reviewed, I'll land this and rebase https://chromium-review.googlesource.com/c/chromium/src/+/7715319

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8e75956bb84a9efb6f0145ccf46baefd6a7099a7
Gerrit-Change-Number: 7714920
Gerrit-PatchSet: 1
Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Barry Pollard <barryp...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Tue, 31 Mar 2026 11:54:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Yoav Weiss (@Shopify) (Gerrit)

unread,
Mar 31, 2026, 7:54:57 AM (2 days ago) Mar 31
to Kouhei Ueno, AyeAye, Rubber Stamper, Chromium LUCI CQ, Hiroshige Hayashizaki, Blink W3C Test Autoroller, Barry Pollard, Raphael Kubo da Costa, Olga Gerchikov, chromium...@chromium.org, Nate Chapin, Menard, Alexis, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, ashleynewson+w...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, loading...@chromium.org

Yoav Weiss (@Shopify) voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Tue, 31 Mar 2026 11:54:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Mar 31, 2026, 8:19:51 AM (2 days ago) Mar 31
to Yoav Weiss (@Shopify), Kouhei Ueno, AyeAye, Rubber Stamper, Hiroshige Hayashizaki, Blink W3C Test Autoroller, Barry Pollard, Raphael Kubo da Costa, Olga Gerchikov, chromium...@chromium.org, Nate Chapin, Menard, Alexis, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, ashleynewson+w...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, loading...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Revert "Speculative load measurement API - preload tracking"

This reverts commit cd66861b870367aa6ca969ec4c3e2c34c3b8909f.

Reason for revert: We are taking a different approach to tackle the use case.

Original change's description:
> Speculative load measurement API - preload tracking
>
> This CL implements the preload tracking portion of the Speculative Load
> Measurement API, exposing preload information on the pagehide event.
>
> Introduces PageHideEvent (extending PageTransitionEvent) with a
> SpeculationData attribute containing preload information. ResourceFetcher
> tracks all preloads and their usage state, which is collected at
> pagehide time.
>
> The feature is gated behind the PageHideSpeculations runtime flag.
>
> Explainer: https://github.com/yoavweiss/speculative_load_measurement
> Change-Id: I18d0bfe97e7a117fe298b65a5fbbcd177b2b8e40
> Bug: 481590676
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7581757
> Commit-Queue: Yoav Weiss (@Shopify) <yoav...@chromium.org>
> Reviewed-by: Kouhei Ueno <kou...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1601978}
Bug: 481590676
Change-Id: I8e75956bb84a9efb6f0145ccf46baefd6a7099a7
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1607793}
Files:
  • M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
  • M third_party/blink/renderer/bindings/generated_in_core.gni
  • M third_party/blink/renderer/bindings/idl_in_core.gni
  • M third_party/blink/renderer/core/dom/document.cc
  • M third_party/blink/renderer/core/events/build.gni
  • D third_party/blink/renderer/core/events/page_hide_event.cc
  • D third_party/blink/renderer/core/events/page_hide_event.h
  • D third_party/blink/renderer/core/events/page_hide_event.idl
  • D third_party/blink/renderer/core/events/page_hide_event_init.idl
  • M third_party/blink/renderer/core/events/page_transition_event.cc
  • M third_party/blink/renderer/core/events/page_transition_event.h
  • D third_party/blink/renderer/core/events/preload.cc
  • D third_party/blink/renderer/core/events/preload.h
  • D third_party/blink/renderer/core/events/preload.idl
  • D third_party/blink/renderer/core/events/speculation_data.cc
  • D third_party/blink/renderer/core/events/speculation_data.h
  • D third_party/blink/renderer/core/events/speculation_data.idl
  • M third_party/blink/renderer/core/frame/local_dom_window.cc
  • M third_party/blink/renderer/core/frame/local_dom_window.h
  • M third_party/blink/renderer/platform/loader/fetch/resource.cc
  • M third_party/blink/renderer/platform/loader/fetch/resource.h
  • M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
  • M third_party/blink/renderer/platform/loader/fetch/resource_fetcher.h
  • M third_party/blink/renderer/platform/runtime_enabled_features.json5
  • D third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-preload.tentative.https.html
  • D third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations-used-preload.tentative.html
  • D third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/pagehide-speculations.tentative.html
  • D third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/blank.html
  • D third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-pagehide-reporter.html
  • D third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-unused-preload-and-reporter.html
  • D third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/page-with-used-preload-and-reporter.html
  • D third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/preload-stash.py
  • D third_party/blink/web_tests/external/wpt/html/browsers/browsing-the-web/unloading-documents/support/preloaded-script.js
  • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
Change size: L
Delta: 34 files changed, 32 insertions(+), 914 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kouhei Ueno, Bot-Commit+1 by Rubber Stamper
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8e75956bb84a9efb6f0145ccf46baefd6a7099a7
Gerrit-Change-Number: 7714920
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,
Mar 31, 2026, 8:55:16 AM (2 days ago) Mar 31
to Chromium LUCI CQ, Yoav Weiss (@Shopify), Kouhei Ueno, AyeAye, Rubber Stamper, Hiroshige Hayashizaki, Barry Pollard, Raphael Kubo da Costa, Olga Gerchikov, chromium...@chromium.org, Nate Chapin, Menard, Alexis, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, android-web...@chromium.org, blink-revie...@chromium.org, ashleynewson+w...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org, loading-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, loading...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/58871

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8e75956bb84a9efb6f0145ccf46baefd6a7099a7
Gerrit-Change-Number: 7714920
Gerrit-PatchSet: 2
Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Barry Pollard <barryp...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Tue, 31 Mar 2026 12:55:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages