Empty implementation of the RTCRtpSendStream interface from RtpTransport [chromium/src : main]

0 views
Skip to first unread message

Tony Herre (Gerrit)

unread,
Jun 24, 2024, 7:49:55 AM (5 days ago) Jun 24
to Philip Eliasson, Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, servicewor...@chromium.org, shimazu+se...@chromium.org, kinuko+ser...@chromium.org, jsbell+ser...@chromium.org, horo+...@chromium.org, kenjibah...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, video-networking...@google.com
Attention needed from Philip Eliasson

Tony Herre voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Philip Eliasson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc96b5c016cc163ff51d3415d537c6500caa6a91
Gerrit-Change-Number: 5642640
Gerrit-PatchSet: 13
Gerrit-Owner: Tony Herre <top...@chromium.org>
Gerrit-Reviewer: Philip Eliasson <phil...@chromium.org>
Gerrit-Reviewer: Tony Herre <top...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Philip Eliasson <phil...@chromium.org>
Gerrit-Comment-Date: Mon, 24 Jun 2024 11:49:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tony Herre (Gerrit)

unread,
Jun 26, 2024, 3:38:40 AM (4 days ago) Jun 26
to Palak Agarwal, Philip Eliasson, Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, servicewor...@chromium.org, shimazu+se...@chromium.org, kinuko+ser...@chromium.org, jsbell+ser...@chromium.org, horo+...@chromium.org, kenjibah...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, video-networking...@google.com
Attention needed from Palak Agarwal and Philip Eliasson

Tony Herre voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Palak Agarwal
  • Philip Eliasson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc96b5c016cc163ff51d3415d537c6500caa6a91
Gerrit-Change-Number: 5642640
Gerrit-PatchSet: 14
Gerrit-Owner: Tony Herre <top...@chromium.org>
Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
Gerrit-Reviewer: Philip Eliasson <phil...@chromium.org>
Gerrit-Reviewer: Tony Herre <top...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Palak Agarwal <agp...@chromium.org>
Gerrit-Attention: Philip Eliasson <phil...@chromium.org>
Gerrit-Comment-Date: Wed, 26 Jun 2024 07:38:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Eliasson (Gerrit)

unread,
Jun 26, 2024, 4:59:43 AM (3 days ago) Jun 26
to Tony Herre, Palak Agarwal, Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, servicewor...@chromium.org, shimazu+se...@chromium.org, kinuko+ser...@chromium.org, jsbell+ser...@chromium.org, horo+...@chromium.org, kenjibah...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, video-networking...@google.com
Attention needed from Palak Agarwal and Tony Herre

Philip Eliasson added 1 comment

Patchset-level comments
File-level comment, Patchset 14 (Latest):
Philip Eliasson . resolved

LGTM, but I don't have the power to +1.

I will have to become a Chrome commiter.

Open in Gerrit

Related details

Attention is currently required from:
  • Palak Agarwal
  • Tony Herre
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc96b5c016cc163ff51d3415d537c6500caa6a91
Gerrit-Change-Number: 5642640
Gerrit-PatchSet: 14
Gerrit-Owner: Tony Herre <top...@chromium.org>
Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
Gerrit-Reviewer: Philip Eliasson <phil...@chromium.org>
Gerrit-Reviewer: Tony Herre <top...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Palak Agarwal <agp...@chromium.org>
Gerrit-Attention: Tony Herre <top...@chromium.org>
Gerrit-Comment-Date: Wed, 26 Jun 2024 08:59:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Guido Urdaneta (Gerrit)

unread,
Jun 26, 2024, 9:06:41 AM (3 days ago) Jun 26
to Tony Herre, Palak Agarwal, Philip Eliasson, Hiroki Nakagawa, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, servicewor...@chromium.org, shimazu+se...@chromium.org, kinuko+ser...@chromium.org, jsbell+ser...@chromium.org, horo+...@chromium.org, kenjibah...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, video-networking...@google.com
Attention needed from Palak Agarwal and Tony Herre

Guido Urdaneta voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Palak Agarwal
  • Tony Herre
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc96b5c016cc163ff51d3415d537c6500caa6a91
Gerrit-Change-Number: 5642640
Gerrit-PatchSet: 14
Gerrit-Owner: Tony Herre <top...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
Gerrit-Reviewer: Philip Eliasson <phil...@chromium.org>
Gerrit-Reviewer: Tony Herre <top...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Palak Agarwal <agp...@chromium.org>
Gerrit-Attention: Tony Herre <top...@chromium.org>
Gerrit-Comment-Date: Wed, 26 Jun 2024 13:06:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 26, 2024, 10:08:18 AM (3 days ago) Jun 26
to Tony Herre, Guido Urdaneta, Palak Agarwal, Philip Eliasson, Hiroki Nakagawa, AyeAye, chromium...@chromium.org, Kentaro Hara, servicewor...@chromium.org, shimazu+se...@chromium.org, kinuko+ser...@chromium.org, jsbell+ser...@chromium.org, horo+...@chromium.org, kenjibah...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, jmedle...@chromium.org, video-networking...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
Empty implementation of the RTCRtpSendStream interface from RtpTransport

Initial empty impl of the interface types around RTCRtpSendStream,
see https://github.com/w3c/webrtc-rtptransport/blob/main/api-outline.md

Should allow for prototyping of the lowerlevel libwebrtc interface for
actually sending RTP packets from JS.

All guarded by the blink feature RTCRtpTransport.
Bug: 345101934
Change-Id: Idc96b5c016cc163ff51d3415d537c6500caa6a91
Auto-Submit: Tony Herre <top...@chromium.org>
Reviewed-by: Guido Urdaneta <gui...@chromium.org>
Commit-Queue: Guido Urdaneta <gui...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1319727}
Files:
  • M third_party/blink/renderer/bindings/generated_in_modules.gni
  • M third_party/blink/renderer/bindings/idl_in_modules.gni
  • M third_party/blink/renderer/modules/peerconnection/BUILD.gn
  • A third_party/blink/renderer/modules/peerconnection/rtc_rtp_header_extension_init.idl
  • A third_party/blink/renderer/modules/peerconnection/rtc_rtp_packet_init.idl
  • A third_party/blink/renderer/modules/peerconnection/rtc_rtp_send_result.cc
  • A third_party/blink/renderer/modules/peerconnection/rtc_rtp_send_result.h
  • A third_party/blink/renderer/modules/peerconnection/rtc_rtp_send_result.idl
  • A third_party/blink/renderer/modules/peerconnection/rtc_rtp_send_stream.cc
  • A third_party/blink/renderer/modules/peerconnection/rtc_rtp_send_stream.h
  • A third_party/blink/renderer/modules/peerconnection/rtc_rtp_send_stream.idl
  • M third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.h
  • M third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.idl
  • A third_party/blink/renderer/modules/peerconnection/rtc_rtp_sent.cc
  • A third_party/blink/renderer/modules/peerconnection/rtc_rtp_sent.h
  • A third_party/blink/renderer/modules/peerconnection/rtc_rtp_sent.idl
  • M third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
  • M third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
  • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
  • M third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt
Change size: L
Delta: 20 files changed, 292 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Guido Urdaneta
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idc96b5c016cc163ff51d3415d537c6500caa6a91
Gerrit-Change-Number: 5642640
Gerrit-PatchSet: 15
Gerrit-Owner: Tony Herre <top...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Palak Agarwal <agp...@chromium.org>
Gerrit-Reviewer: Philip Eliasson <phil...@chromium.org>
Gerrit-Reviewer: Tony Herre <top...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages