Expose GPUTexture.textureBindingViewDimension [chromium/src : main]

0 views
Skip to first unread message

Gregg Tavares (Gerrit)

unread,
Dec 19, 2025, 8:31:44 PM (17 hours ago) Dec 19
to Corentin Wallez, Stephen White, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org
Attention needed from Corentin Wallez and Stephen White

Gregg Tavares voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Corentin Wallez
  • Stephen White
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib1d04b83dae1b40b952cae53b90a9f520a5cb1c6
Gerrit-Change-Number: 7281961
Gerrit-PatchSet: 1
Gerrit-Owner: Gregg Tavares <gm...@google.com>
Gerrit-Reviewer: Corentin Wallez <cwa...@chromium.org>
Gerrit-Reviewer: Gregg Tavares <gm...@google.com>
Gerrit-Reviewer: Stephen White <senor...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Corentin Wallez <cwa...@chromium.org>
Gerrit-Attention: Stephen White <senor...@chromium.org>
Gerrit-Comment-Date: Sat, 20 Dec 2025 01:31:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

AI Code Reviewer (Gerrit)

unread,
Dec 19, 2025, 8:37:58 PM (17 hours ago) Dec 19
to Gregg Tavares, Chromium LUCI CQ, Corentin Wallez, Stephen White, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org
Attention needed from Corentin Wallez, Gregg Tavares and Stephen White

AI Code Reviewer added 1 comment

File third_party/blink/renderer/modules/webgpu/gpu_texture.h
Line 106, Patchset 1 (Latest): wgpu::TextureViewDimension textureBindingViewDimension_;
AI Code Reviewer . unresolved

nit: Variable 'textureBindingViewDimension_' should use snake_case (e.g. 'texture_binding_view_dimension_'). (Blink Style Guide: Naming)

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:
  • Corentin Wallez
  • Gregg Tavares
  • Stephen White
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib1d04b83dae1b40b952cae53b90a9f520a5cb1c6
    Gerrit-Change-Number: 7281961
    Gerrit-PatchSet: 1
    Gerrit-Owner: Gregg Tavares <gm...@google.com>
    Gerrit-Reviewer: Corentin Wallez <cwa...@chromium.org>
    Gerrit-Reviewer: Gregg Tavares <gm...@google.com>
    Gerrit-Reviewer: Stephen White <senor...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Gregg Tavares <gm...@google.com>
    Gerrit-Attention: Corentin Wallez <cwa...@chromium.org>
    Gerrit-Attention: Stephen White <senor...@chromium.org>
    Gerrit-Comment-Date: Sat, 20 Dec 2025 01:37:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gregg Tavares (Gerrit)

    unread,
    Dec 19, 2025, 8:47:50 PM (17 hours ago) Dec 19
    to AI Code Reviewer, Chromium LUCI CQ, Corentin Wallez, Stephen White, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, jmedle...@chromium.org, kainin...@chromium.org
    Attention needed from Corentin Wallez, Gregg Tavares and Stephen White

    Gregg Tavares voted and added 1 comment

    Votes added by Gregg Tavares

    Commit-Queue+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Gregg Tavares . resolved

    oh, haha, dawn needs to roll before this can land.

    BTW, I have no clue how this all works in the blink side with v8 etc. I tried to copy other getters but AFAICT, no other getter does the enum or undefined thing. I asked duckie to help me through it and together we got here which works.

    Gerrit-Comment-Date: Sat, 20 Dec 2025 01:47:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages