[compile hints] Integrate crowdsourced and local compile hints [chromium/src : main]
0 views
Skip to first unread message
Marja Hölttä (Gerrit)
Jun 24, 2024, 1:34:07 PM (5 days ago) Jun 24
to Leszek Swirski, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org
Attention needed from Leszek Swirski
Marja Hölttä added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Jun 26, 2024, 11:04:04 AM (3 days ago) Jun 26
to Marja Hölttä, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org
Attention needed from Marja Hölttä
Leszek Swirski voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Marja Hölttä
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marja Hölttä (Gerrit)
Jun 26, 2024, 11:14:28 AM (3 days ago) Jun 26
to Leszek Swirski, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org
Marja Hölttä voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 26, 2024, 12:30:57 PM (3 days ago) Jun 26
to Marja Hölttä, Leszek Swirski, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[compile hints] Integrate crowdsourced and local compile hints
If crowdsourced hints are available, use them instead of (producing)
local compile hints.
We cannot consume and produce compile hints at the same time, since
compile hints are only produced during lazy function compilation,
and if we already consumed compile hints, the functions aren't lazy
any more.
A possible follow-up would be to have local compile hints augment
crowdsourced compile hints; 1) enable producing compile hints
and consuming them at the same time and 2) enable consuming both
kinds of compile hints at the same time.
Bug: 40286622
Change-Id: I38b63c9007d902ffadee2648fedc08ac3eebcd64
Reviewed-by: Leszek Swirski <les...@chromium.org>
Commit-Queue: Marja Hölttä <ma...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1319823}
Files:
- M third_party/blink/renderer/bindings/core/v8/v8_code_cache.cc
- M third_party/blink/renderer/bindings/core/v8/v8_code_cache.h
- M third_party/blink/renderer/bindings/core/v8/v8_compile_hints_for_streaming.cc
- M third_party/blink/renderer/bindings/core/v8/v8_compile_hints_for_streaming_test.cc
- M third_party/blink/renderer/bindings/core/v8/v8_script_runner.cc
- M third_party/blink/renderer/bindings/core/v8/v8_script_runner.h
Change size: L
Delta: 6 files changed, 160 insertions(+), 98 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Leszek Swirski
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages