Hook up bookmark_page_action_controller and add feature flag [chromium/src : main]

0 views
Skip to first unread message

Kaan Alsan (Gerrit)

unread,
Nov 18, 2025, 11:05:30 AM (4 days ago) Nov 18
to CJ DiMeglio, Raphael Kubo da Costa, Hu, Ningxin, James Su, Mirko Bonadei, Ale Bzk, Xida Chen, Stephen Chenney, Sophie Chang, Sam Zackrisson, James Maclean, Kaan Icer, Hongchan Choi, Hiroki Nakagawa, Enterprise Policy Reviews, Avi Drissman, David Bokan, Per Åhgren, Peter Beverloo, Sadrul Chowdhury, Heron Yang, Jerome Jiang, Gyuyoung Kim, Peter Collingbourne, Dirk Schulze, Jiewei Qian, Yoav Weiss (@Shopify), Menard, Alexis, Daniel Cheng, Reid Kleckner, Andrew Rayskiy, srirama chandra sekhar, Mike Taylor, Hirokazu Honda, Olga Gerchikov, Victor Tan, Zijie He, Simon Hangl, Mathias Bynens, Nico Weber, Kevin McNee, Alex Keng, Wanming Lin, Mangesh Ghiware, Nikhil Nayunigari, Lei Zhang, Javier Fernandez, Peter Williamson, Hans Wennborg, Kevin Babbitt, Chromium Metrics Reviews, Ilya Biryukov, Kentaro Hara, Christian Biesinger, Tommy Li, Fredrik Söderquist, Nate Chapin, Rijubrata Bhaumik, (Julie)Jeongeun Kim, AyeAye, AyeAye Python Dispatcher, chromium...@chromium.org, yfriedm...@chromium.org, language...@chromium.org, hirokisa...@chromium.org, chromiumme...@microsoft.com, grt+...@chromium.org, dmurph+watching...@chromium.org, lighthouse-eng-extern...@google.com, steimel+watch...@chromium.org, mbarowsky+watc...@chromium.org, penghuan...@chromium.org, kouhei...@chromium.org, jiajunz+wa...@google.com, mcasas+med...@chromium.org, christia...@chromium.org, ejcaruso+wa...@chromium.org, loading...@chromium.org, yhiran...@chromium.org, dimich...@chromium.org, johnche...@chromium.org, wnwen...@chromium.org, rkgibso...@chromium.org, blink-re...@chromium.org, jonmann+wa...@chromium.org, ios-rev...@chromium.org, davidj...@chromium.org, niharm...@google.com, mkwst+w...@chromium.org, dmurph+wat...@chromium.org, mattsimm...@chromium.org, yhanada+...@chromium.org, mfoltz+wa...@chromium.org, devtools-re...@chromium.org, andysjl...@chromium.org, webauthn...@chromium.org, cfredri...@chromium.org, tbarzi...@chromium.org, csharris...@chromium.org, max+watc...@igalia.com, crisrael+w...@google.com, chadduffin+w...@chromium.org, translat...@chromium.org, pasko...@chromium.org, blink-revie...@chromium.org, estali...@chromium.org, bmcquad...@chromium.org, khorimoto+w...@chromium.org, iclella...@chromium.org, dom+...@chromium.org, jiajunz+wat...@google.com, ashleynewson+w...@chromium.org, lcwu+...@chromium.org, shuche...@chromium.org, chrome-intell...@chromium.org, cros-ed...@google.com, derinel+wat...@google.com, jiajunz+wat...@google.com, blink-rev...@chromium.org, ios-r...@chromium.org, anastas...@google.com, mar...@chromium.org, cros-print...@google.com, drott+bl...@chromium.org, pdf-r...@chromium.org, siyua+aut...@chromium.org, zackha...@chromium.org, shimazu...@chromium.org, arthursonzog...@chromium.org, gavin...@chromium.org, tracing...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, boujan...@google.com, thesals...@google.com, video-networking...@google.com, ayman...@chromium.org, dtseng...@chromium.org, mercer...@google.com, cwalle...@chromium.org, siashah+au...@chromium.org, edgesto...@microsoft.com, pushi+wat...@google.com, dominicc+...@chromium.org, hsuregan+wa...@chromium.org, yuezhang...@chromium.org, kmg+...@google.com, dtraino...@chromium.org, npm+...@chromium.org, katie...@chromium.org, vsavu...@google.com, meilian...@chromium.org, mdjone...@chromium.org, dkrahn...@chromium.org, ios-revie...@chromium.org, chromeos-kio...@google.com, chadduffin+w...@chromium.org, fenced-fra...@chromium.org, geoffla...@chromium.org, roagarw...@chromium.org, dcheng+c...@chromium.org, apaselti...@chromium.org, ukai+...@chromium.org, jinsukk...@chromium.org, ydago...@chromium.org, lizeb+watch...@chromium.org, shannc...@chromium.org, alexmt...@chromium.org, ntp-dev...@chromium.org, jdeblas...@chromium.org, rsleev...@chromium.org, dmurph+watch...@chromium.org, dullweb...@chromium.org, srahim...@chromium.org, kenjibah...@chromium.org, cros-report...@google.com, media-cro...@chromium.org, dibyapal+wa...@chromium.org, lizeb...@chromium.org, tranbaod...@chromium.org, marinacio...@chromium.org, croissant-...@chromium.org, mbarowsky+watc...@chromium.org, dtapuska+ch...@chromium.org, agriev...@chromium.org, chromium-a...@chromium.org, dtapuska+...@chromium.org, loading-rev...@chromium.org, arc-review...@google.com, josiah...@chromium.org, yigu+...@chromium.org, ajwong...@chromium.org, michaelchec...@google.com, permissio...@chromium.org, aashna...@google.com, gcasto+w...@chromium.org, johnyki...@google.com, oilpan-rev...@chromium.org, jkarli...@chromium.org, nyquis...@chromium.org, blink-...@chromium.org, navigation...@chromium.org, eric.c...@apple.com, scheduler-...@chromium.org, chrome-waff...@google.com, creis...@chromium.org, torne...@chromium.org, kinuko+ser...@chromium.org, crostin...@chromium.org, nickdiego+wa...@igalia.com, jasonrobe...@google.com, android-web...@chromium.org, khmel...@chromium.org, feature-v...@chromium.org, tburkar...@chromium.org, shgar+aut...@google.com, dfried...@chromium.org, cblume...@chromium.org, marq+...@chromium.org, chasej...@chromium.org, fgorsk...@chromium.org, lens-chrome...@google.com, blink-revi...@chromium.org, peilinwa...@google.com, xlythe+wa...@google.com, cbe-cep-eng...@google.com, jz...@chromium.org, droger+w...@chromium.org, dmurph+watch...@chromium.org, blink-re...@chromium.org, rginda...@chromium.org, chromium-...@engflow.com, ender...@chromium.org, glider...@chromium.org, jackshira+w...@google.com, kinuko...@chromium.org, ios-web-view...@google.com, borealis-re...@google.com, martijn...@martijnc.be, jimmyxgong+f...@chromium.org, kyungjunle...@google.com, drott...@chromium.org, feature-me...@chromium.org, loading-re...@chromium.org, headless...@chromium.org, jackshira+wa...@google.com, print-rev...@chromium.org, kinuko+...@chromium.org, druber...@chromium.org, joeantonetti+wa...@google.com, subresource-f...@chromium.org, speed-metr...@chromium.org, nwoked...@chromium.org, core-timi...@chromium.org, hansberry+wa...@chromium.org, zelin+watch-we...@chromium.org, blink-work...@chromium.org, chikamu...@chromium.org, mattreyno...@chromium.org, pkotwic...@chromium.org, bartek...@chromium.org, kouhe...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, apavlo...@chromium.org, nona+...@chromium.org, gavin...@chromium.org, hansberry+w...@chromium.org, hanxi...@chromium.org, stanfie...@google.com, jshin...@chromium.org, cc-...@chromium.org, yhanada+...@chromium.org, blink-revi...@chromium.org, dewitt...@chromium.org, nicolas...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, hsuregan+wat...@chromium.org, scheduler...@chromium.org, lucasrada...@google.com, enne...@chromium.org, browser-comp...@chromium.org, dmurph+watc...@chromium.org, shimazu+se...@chromium.org, antoniosarto...@chromium.org, blink-rev...@chromium.org, toyosh...@chromium.org, chfreme...@chromium.org, spang...@chromium.org, suetfei+wa...@google.com, owenzhang+audio...@google.com, blink-rev...@chromium.org, vinnypersky+...@google.com, mgiuca...@chromium.org, chromeos-gfx-...@google.com, hidehik...@chromium.org, chrstn...@google.com, jonmann+watc...@chromium.org, fgal...@chromium.org, trewin...@google.com, wfh+...@chromium.org, ajayramamurthy+w...@google.com, ozone-...@chromium.org, odejesu...@chromium.org, cambickel...@google.com, gavinp...@chromium.org, webapks-...@chromium.org, emircan+watch...@chromium.org, silv...@chromium.org, horo+...@chromium.org, rmcelra...@chromium.org, xinghui...@chromium.org, ejcaruso+wa...@chromium.org, erickun...@chromium.org, fuzzin...@chromium.org, hsuregan+wa...@chromium.org, alexmo...@chromium.org, philli...@chromium.org, chromotin...@chromium.org, dclasson+w...@google.com, jophba...@chromium.org, kainin...@chromium.org, sloboda...@chromium.org, cblume+im...@chromium.org, rrsilva+wat...@google.com, tommyw+w...@chromium.org, blink-revi...@chromium.org, blink-isola...@chromium.org, blink-revie...@chromium.org, michaelcheco+aud...@google.com, blink-re...@chromium.org, zol...@webkit.org, ortuno...@chromium.org, mfoltz+wa...@chromium.org, nator...@chromium.org, jbauma...@chromium.org, nektar...@chromium.org, yhanad...@chromium.org, blink-rev...@chromium.org, devtools...@chromium.org, extension...@chromium.org, gl...@chromium.org, chadduffin+wa...@chromium.org, ricea...@chromium.org, chili...@chromium.org, cros-setti...@google.com, michaelcheco+...@google.com, telemetr...@chromium.org, network-ser...@chromium.org, security-...@chromium.org, francisjp...@google.com, halliwe...@chromium.org, armalhotra+a...@google.com, abigailbk...@google.com, yongshun+...@google.com, msrame...@chromium.org, fuchsia...@chromium.org, dmurph+wa...@chromium.org, hiroshig...@chromium.org, kenok...@google.com, servicewor...@chromium.org, speed-metrics...@chromium.org, fmalit...@chromium.org, rayanka...@chromium.org, chrome-intelligence-te...@google.com, storage...@chromium.org, tmartino+tran...@chromium.org, moqati-team+chr...@google.com, vasilii+watchlis...@chromium.org, stevenjb+wa...@chromium.org, hais+wat...@google.com, hashimo...@chromium.org, dmurph+watchi...@chromium.org, asvitkine...@chromium.org, jackshira+w...@google.com, gavinp...@chromium.org, prerenderi...@chromium.org, hansberry+wat...@chromium.org, keithle...@chromium.org, yuzo+...@chromium.org, thegreenf...@chromium.org, ajayramamurth...@google.com, jbroma...@chromium.org, media-wi...@chromium.org, print-revi...@chromium.org, blink-reviews-p...@chromium.org, lize...@chromium.org, osaul+aut...@google.com, roblia...@chromium.org, hayato...@chromium.org, nikhilcn+wat...@google.com, blink-re...@chromium.org, giovax...@chromium.org, oshima...@chromium.org, khorimoto+wa...@chromium.org, cros-essential...@chromium.org, jatapiaro+wat...@google.com, blink-revie...@chromium.org, bnc+...@chromium.org, jackshira+wat...@google.com, kuragin+web-ap...@chromium.org, mlcui+watch-os-s...@google.com, sky+...@chromium.org, filesapp...@chromium.org, twifka...@chromium.org, fserb...@chromium.org, rizvis...@google.com, gogeral...@chromium.org, olka+...@chromium.org, xiaochen...@chromium.org, khorimoto+wa...@chromium.org, wychen...@chromium.org, loading-rev...@chromium.org, hansenmichael...@google.com, ananyasee...@google.com, eic+...@google.com, chrome-gr...@chromium.org, chrome-tab-group-en...@google.com, eugeni...@chromium.org, penghu...@chromium.org, yusufo...@chromium.org, performance-m...@chromium.org, lwinston+watc...@google.com, asvitki...@chromium.org, jdonnel...@chromium.org, jmedle...@chromium.org, omnibox-...@chromium.org

Kaan Alsan abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5751b999206f86e7585319e6f1b419bf5e3e7ebe
Gerrit-Change-Number: 7162133
Gerrit-PatchSet: 2
Gerrit-Owner: Kaan Alsan <al...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Ale Bzk <ales...@chromium.org>
Gerrit-CC: Alex Keng <shi...@microsoft.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Avi Drissman <a...@chromium.org>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: CJ DiMeglio <lethala...@chromium.org>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Frank Liberato <libe...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Gyuyoung Kim <gyuyou...@chromium.org>
Gerrit-CC: Hans Wennborg <ha...@chromium.org>
Gerrit-CC: Heron Yang <hero...@google.com>
Gerrit-CC: Hirokazu Honda <hi...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Ilya Biryukov <ibir...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Javier Fernandez <jfern...@igalia.com>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Mangesh Ghiware <mghi...@google.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Mike Taylor <mike...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Nico Weber <tha...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Per Åhgren <pe...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Peter Collingbourne <p...@chromium.org>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Reid Kleckner <r...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Sam Zackrisson <sa...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-CC: Victor Tan <vict...@chromium.org>
Gerrit-CC: Wanming Lin <wanmi...@intel.com>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-CC: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages