PromiseAll should support both "wait for all" and "get a promise for waiting for all" [chromium/src : main]

38 views
Skip to first unread message

Noam Rosenthal (Gerrit)

unread,
Apr 20, 2026, 11:47:49 AMApr 20
to Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org

New activity on the change

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6f44ade1ff8acadd9fbc1b25f83823a80373924d
Gerrit-Change-Number: 7098960
Gerrit-PatchSet: 1
Gerrit-Owner: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Mon, 20 Apr 2026 15:47:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Noam Rosenthal (Gerrit)

unread,
Apr 21, 2026, 5:50:35 AMApr 21
to Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org
Attention needed from Nate Chapin

Noam Rosenthal voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nate Chapin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6f44ade1ff8acadd9fbc1b25f83823a80373924d
Gerrit-Change-Number: 7098960
Gerrit-PatchSet: 3
Gerrit-Owner: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Apr 2026 09:50:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Chapin (Gerrit)

unread,
May 7, 2026, 5:37:07 PM (12 days ago) May 7
to Andrey Kosyakov, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Code Review Nudger, Noam Rosenthal, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org
Attention needed from Andrey Kosyakov and Noam Rosenthal

Nate Chapin added 2 comments

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Nate Chapin . resolved

caseq: please review bindings/

File third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/navigate-204-205-download-then-same-document-expected.txt
Line 3, Patchset 9 (Latest): assert_array_equals: expected property 7 to be "committed fulfilled 2" but got "navigatesuccess" (expected array ["navigate", "AbortSignal abort", "navigateerror", "navigate", "currententrychange", "committed rejected 1", "finished rejected 1", "committed fulfilled 2", "promise microtask", "navigatesuccess", "finished fulfilled 2"] got ["navigate", "AbortSignal abort", "navigateerror", "navigate", "currententrychange", "committed rejected 1", "finished rejected 1", "navigatesuccess", "committed fulfilled 2", "promise microtask", "finished fulfilled 2"])
Nate Chapin . unresolved

This looks like a test that got missed in the WPT update.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6f44ade1ff8acadd9fbc1b25f83823a80373924d
Gerrit-Change-Number: 7098960
Gerrit-PatchSet: 9
Gerrit-Owner: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Thu, 07 May 2026 21:36:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrey Kosyakov (Gerrit)

unread,
May 7, 2026, 6:31:18 PM (12 days ago) May 7
to Nate Chapin, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Code Review Nudger, Noam Rosenthal, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org
Attention needed from Nate Chapin and Noam Rosenthal

Andrey Kosyakov added 5 comments

File third_party/blink/renderer/bindings/core/v8/promise_all.h
Line 225, Patchset 9: base::OnceCallback<void(const VectorType&)> resolve_callback_;
Andrey Kosyakov . unresolved

These would be mutually exclusive, right? Can we do with just one instead of two resolve callbacks and define the type conditionally of the underlying value type?

Line 210, Patchset 9: values_.clear();
Andrey Kosyakov . unresolved

Consider making callback accept values vector by value and std::move()'ing here.

Line 88, Patchset 9: std::move(resolve_undefined_callback).Run();
Andrey Kosyakov . unresolved

Note that per // https://webidl.spec.whatwg.org/#wait-for-all

Step 6:
```
If total is 0, then:

Queue a microtask to perform successSteps given « ».
```

Line 57, Patchset 9: resolver->Resolve();
Andrey Kosyakov . unresolved

We don't really need a lambda here, do we? Can we just bind `ScriptPromiseResolver<IDLUndefined>::Resolve` directly?
Also, wanna give [HeapBind](third_party/blink/renderer/platform/heap/heap_bind.h) a try?

Line 31, Patchset 9: static ScriptPromise<ResolverType> GetPromiseForWaitingForAll(
Andrey Kosyakov . unresolved

nit: s/Get/Create/?

Open in Gerrit

Related details

Attention is currently required from:
  • Nate Chapin
  • Noam Rosenthal
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Thu, 07 May 2026 22:31:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Chapin (Gerrit)

unread,
May 7, 2026, 7:38:38 PM (11 days ago) May 7
to Andrey Kosyakov, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Code Review Nudger, Noam Rosenthal, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org
Attention needed from Andrey Kosyakov and Noam Rosenthal

Nate Chapin added 5 comments

File third_party/blink/renderer/bindings/core/v8/promise_all.h
Line 225, Patchset 9: base::OnceCallback<void(const VectorType&)> resolve_callback_;
Andrey Kosyakov . resolved

These would be mutually exclusive, right? Can we do with just one instead of two resolve callbacks and define the type conditionally of the underlying value type?

Nate Chapin

Done

Line 210, Patchset 9: values_.clear();
Andrey Kosyakov . resolved

Consider making callback accept values vector by value and std::move()'ing here.

Nate Chapin

Done

Line 88, Patchset 9: std::move(resolve_undefined_callback).Run();
Andrey Kosyakov . resolved

Note that per // https://webidl.spec.whatwg.org/#wait-for-all

Step 6:
```
If total is 0, then:

Queue a microtask to perform successSteps given « ».
```

Nate Chapin

Done

Line 57, Patchset 9: resolver->Resolve();
Andrey Kosyakov . resolved

We don't really need a lambda here, do we? Can we just bind `ScriptPromiseResolver<IDLUndefined>::Resolve` directly?
Also, wanna give [HeapBind](third_party/blink/renderer/platform/heap/heap_bind.h) a try?

Nate Chapin

HeapBind: Done
No lambdas: Doesn't work because of function name overloads.

Line 31, Patchset 9: static ScriptPromise<ResolverType> GetPromiseForWaitingForAll(
Andrey Kosyakov . unresolved

nit: s/Get/Create/?

Nate Chapin

`Get` matches the spec text - i agree that normally we'd prefee `Create`, but I think in this case it's worth sticking with the spec name.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6f44ade1ff8acadd9fbc1b25f83823a80373924d
Gerrit-Change-Number: 7098960
Gerrit-PatchSet: 11
Gerrit-Owner: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Thu, 07 May 2026 23:38:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrey Kosyakov <ca...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrey Kosyakov (Gerrit)

unread,
May 7, 2026, 8:31:51 PM (11 days ago) May 7
to Nate Chapin, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Code Review Nudger, Noam Rosenthal, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org
Attention needed from Nate Chapin and Noam Rosenthal

Andrey Kosyakov voted and added 3 comments

Votes added by Andrey Kosyakov

Code-Review+1

3 comments

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Andrey Kosyakov . resolved

bindings lgtm

File third_party/blink/renderer/bindings/core/v8/promise_all.h
Line 31, Patchset 9: static ScriptPromise<ResolverType> GetPromiseForWaitingForAll(
Andrey Kosyakov . resolved

nit: s/Get/Create/?

Nate Chapin

`Get` matches the spec text - i agree that normally we'd prefee `Create`, but I think in this case it's worth sticking with the spec name.

Andrey Kosyakov

Acknowledged

File third_party/blink/renderer/bindings/core/v8/promise_all_test.cc
File-level comment, Patchset 11 (Latest):
Andrey Kosyakov . unresolved

nit: perhaps add some explicit coverage for WaitForAll() too?

Open in Gerrit

Related details

Attention is currently required from:
  • Nate Chapin
  • Noam Rosenthal
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6f44ade1ff8acadd9fbc1b25f83823a80373924d
    Gerrit-Change-Number: 7098960
    Gerrit-PatchSet: 11
    Gerrit-Owner: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
    Gerrit-Comment-Date: Fri, 08 May 2026 00:31:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Andrey Kosyakov <ca...@chromium.org>
    Comment-In-Reply-To: Nate Chapin <jap...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nate Chapin (Gerrit)

    unread,
    May 8, 2026, 2:23:12 PM (11 days ago) May 8
    to Andrey Kosyakov, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Code Review Nudger, Noam Rosenthal, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org
    Attention needed from Noam Rosenthal

    Nate Chapin added 1 comment

    File third_party/blink/renderer/bindings/core/v8/promise_all_test.cc
    File-level comment, Patchset 11:
    Andrey Kosyakov . resolved

    nit: perhaps add some explicit coverage for WaitForAll() too?

    Nate Chapin

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Noam Rosenthal
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6f44ade1ff8acadd9fbc1b25f83823a80373924d
    Gerrit-Change-Number: 7098960
    Gerrit-PatchSet: 12
    Gerrit-Owner: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
    Gerrit-Comment-Date: Fri, 08 May 2026 18:22:58 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Noam Rosenthal (Gerrit)

    unread,
    May 8, 2026, 2:28:34 PM (11 days ago) May 8
    to Nate Chapin, Andrey Kosyakov, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org
    Attention needed from Nate Chapin

    Noam Rosenthal voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nate Chapin
    Gerrit-Attention: Nate Chapin <jap...@chromium.org>
    Gerrit-Comment-Date: Fri, 08 May 2026 18:28:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrey Kosyakov (Gerrit)

    unread,
    May 8, 2026, 2:31:56 PM (11 days ago) May 8
    to Nate Chapin, Noam Rosenthal, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org
    Attention needed from Nate Chapin

    Andrey Kosyakov voted and added 2 comments

    Votes added by Andrey Kosyakov

    Code-Review+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 12 (Latest):
    Andrey Kosyakov . resolved

    still lgtm

    File third_party/blink/renderer/bindings/core/v8/promise_all_test.cc
    Line 281, Patchset 12 (Latest): EXPECT_EQ(wait_for_all_result->resolve_value[0], "first");
    Andrey Kosyakov . unresolved

    nit: this can be just `EXPECT_THAT(wait_for_all_result->resolve_value, testing::ValuesAre("first", "second", "third"));`

    Gerrit-Comment-Date: Fri, 08 May 2026 18:31:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nate Chapin (Gerrit)

    unread,
    May 8, 2026, 4:27:05 PM (11 days ago) May 8
    to Noam Rosenthal, Andrey Kosyakov, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org

    Nate Chapin added 2 comments

    File third_party/blink/renderer/bindings/core/v8/promise_all_test.cc
    Line 281, Patchset 12: EXPECT_EQ(wait_for_all_result->resolve_value[0], "first");
    Andrey Kosyakov . resolved

    nit: this can be just `EXPECT_THAT(wait_for_all_result->resolve_value, testing::ValuesAre("first", "second", "third"));`

    Nate Chapin

    s/ValuesAre/ElementsAre/ done 😊

    Also fixed the case that I copied this logic from.

    File third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/navigate-204-205-download-then-same-document-expected.txt
    Line 3, Patchset 9: assert_array_equals: expected property 7 to be "committed fulfilled 2" but got "navigatesuccess" (expected array ["navigate", "AbortSignal abort", "navigateerror", "navigate", "currententrychange", "committed rejected 1", "finished rejected 1", "committed fulfilled 2", "promise microtask", "navigatesuccess", "finished fulfilled 2"] got ["navigate", "AbortSignal abort", "navigateerror", "navigate", "currententrychange", "committed rejected 1", "finished rejected 1", "navigatesuccess", "committed fulfilled 2", "promise microtask", "finished fulfilled 2"])
    Nate Chapin . resolved

    This looks like a test that got missed in the WPT update.

    Nate Chapin

    Acknowledged

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6f44ade1ff8acadd9fbc1b25f83823a80373924d
      Gerrit-Change-Number: 7098960
      Gerrit-PatchSet: 13
      Gerrit-Owner: Nate Chapin <jap...@chromium.org>
      Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
      Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
      Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Comment-Date: Fri, 08 May 2026 20:26:56 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Andrey Kosyakov <ca...@chromium.org>
      Comment-In-Reply-To: Nate Chapin <jap...@chromium.org>
      satisfied_requirement
      open
      diffy

      Nate Chapin (Gerrit)

      unread,
      May 11, 2026, 6:41:21 PM (8 days ago) May 11
      to Noam Rosenthal, Andrey Kosyakov, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org

      Nate Chapin voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6f44ade1ff8acadd9fbc1b25f83823a80373924d
      Gerrit-Change-Number: 7098960
      Gerrit-PatchSet: 14
      Gerrit-Owner: Nate Chapin <jap...@chromium.org>
      Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
      Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
      Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Comment-Date: Mon, 11 May 2026 22:41:07 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      May 11, 2026, 6:47:18 PM (8 days ago) May 11
      to Nate Chapin, Noam Rosenthal, Andrey Kosyakov, Menard, Alexis, Olga Gerchikov, android-bu...@system.gserviceaccount.com, Code Review Nudger, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ricea...@chromium.org

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      12 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: third_party/blink/renderer/bindings/core/v8/promise_all_test.cc
      Insertions: 4, Deletions: 6.

      The diff is too large to show. Please review the diff.
      ```

      Change information

      Commit message:
      PromiseAll should support both "wait for all" and "get a promise for waiting for all"
      Change-Id: I6f44ade1ff8acadd9fbc1b25f83823a80373924d
      Reviewed-by: Noam Rosenthal <nrose...@google.com>
      Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
      Commit-Queue: Nate Chapin <jap...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1628871}
      Files:
      • M third_party/blink/renderer/bindings/core/v8/promise_all.h
      • M third_party/blink/renderer/bindings/core/v8/promise_all_test.cc
      • M third_party/blink/renderer/core/navigation_api/navigate_event.cc
      • M third_party/blink/renderer/core/navigation_api/navigate_event.h
      • M third_party/blink/renderer/core/streams/pipe_to_engine.cc
      • M third_party/blink/renderer/core/streams/transferable_streams.cc
      • M third_party/blink/renderer/modules/clipboard/clipboard_promise.cc
      • M third_party/blink/renderer/modules/clipboard/clipboard_promise.h
      • M third_party/blink/web_tests/external/wpt/navigation-api/focus-reset/autofocus_same-checkpoint-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/anchor-download-intercept-reject_currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/anchor-download-intercept-reject_no-currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/anchor-download-intercept_currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/anchor-download-intercept_no-currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/location-href-intercept-reject_currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/location-href-intercept-reject_no-currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/location-href-intercept_currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/location-href-intercept_no-currententrychange-expected.txt
      • A third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/navigate-204-205-download-then-same-document-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/navigate-in-transition-finished_currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/navigate-in-transition-finished_no-currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/navigate-intercept_currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/navigate-intercept_no-currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/navigate-same-document-intercept-reject_currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/navigate-same-document-intercept-reject_no-currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/navigate-same-document_currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/navigate-same-document_no-currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/reload-intercept-reject_currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/reload-intercept-reject_no-currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/reload-intercept_currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/reload-intercept_no-currententrychange-expected.txt
      • D third_party/blink/web_tests/external/wpt/navigation-api/ordering-and-transition/reload-no-popstate-expected.txt
      Change size: L
      Delta: 31 files changed, 296 insertions(+), 314 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Noam Rosenthal, +1 by Andrey Kosyakov
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6f44ade1ff8acadd9fbc1b25f83823a80373924d
      Gerrit-Change-Number: 7098960
      Gerrit-PatchSet: 15
      Gerrit-Owner: Nate Chapin <jap...@chromium.org>
      Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
      Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages