Require fewer string copies in DOMException. [chromium/src : main]
72 views
Skip to first unread message
Kevin McNee (Gerrit)
Jun 18, 2024, 5:07:16 PM (11 days ago) Jun 18
to Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Jeremy Roman
Kevin McNee voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Jun 18, 2024, 5:09:37 PM (11 days ago) Jun 18
to Jeremy Roman, Kevin McNee, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Jeremy Roman voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin McNee (Gerrit)
Jun 18, 2024, 5:10:11 PM (11 days ago) Jun 18
to Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Kevin McNee added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
Line 119, Patchset 1 (Latest):
static String ExtractMessageForConsole(v8::Isolate* isolate,Kevin McNee . unresolved
Optional nit: Oh while we're here, consider moving this into the anonymous namespace.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin McNee (Gerrit)
Jun 18, 2024, 5:12:39 PM (11 days ago) Jun 18
to Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Jeremy Roman
Kevin McNee voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kevin McNee
| Commit-Queue | +2 |
1 comment
File third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
Line 119, Patchset 1 (Latest):
static String ExtractMessageForConsole(v8::Isolate* isolate,Kevin McNee . resolved
Optional nit: Oh while we're here, consider moving this into the anonymous namespace.
Attention is currently required from:
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin McNee (Gerrit)
Jun 18, 2024, 6:39:14 PM (11 days ago) Jun 18
to Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Jeremy Roman
Kevin McNee voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kevin McNee
Related details
Attention is currently required from:
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin McNee (Gerrit)
Jun 20, 2024, 3:01:25 PM (9 days ago) Jun 20
to Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Jeremy Roman
Kevin McNee voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Jun 25, 2024, 1:34:54 PM (4 days ago) Jun 25
to Jeremy Roman, Kevin McNee, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Jeremy Roman voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 25, 2024, 2:40:15 PM (4 days ago) Jun 25
to Jeremy Roman, Kevin McNee, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Require fewer string copies in DOMException.
Just noticed that this is a little more than necessary. Not a big deal,
but might be nice to have.
Change-Id: I1868a7d90ea57e4f29eaa98888031227ebf95873
Reviewed-by: Kevin McNee <mc...@chromium.org>
Commit-Queue: Jeremy Roman <jbr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1319308}
Files:
- M third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
- M third_party/blink/renderer/core/dom/dom_exception.cc
- M third_party/blink/renderer/core/dom/dom_exception.h
- M third_party/blink/renderer/core/inspector/thread_debugger_common_impl.cc
Change size: S
Delta: 4 files changed, 23 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kevin McNee
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages