Lei Zhang (Gerrit)

unread,

Nov 14, 2025, 12:01:56 PM (8 days ago) Nov 14

to Lei Zhang, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Dale Curtis

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Lei Zhang . resolved

PTAL at //media.

Open in Gerrit

Related details

Attention is currently required from:

Dale Curtis

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dale Curtis (Gerrit)

unread,

Nov 14, 2025, 1:02:16 PM (8 days ago) Nov 14

to Lei Zhang, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Lei Zhang

Dale Curtis voted and added 1 comment

Votes added by Dale Curtis

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Dale Curtis . resolved

Spot checked several including the constructor changes, lgtm

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 14, 2025, 1:33:46 PM (8 days ago) Nov 14

to Lei Zhang, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Lei Zhang

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 3:

Dale Curtis . resolved

Spot checked several including the constructor changes, lgtm

Lei Zhang

Thanks. Somehow I thought I got all the bots, but the Chromecast ones are still red. Will fix those up.

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 14, 2025, 9:05:01 PM (8 days ago) Nov 14

to Lei Zhang, Nico Weber, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Nico Weber

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Lei Zhang . resolved

Please OO+1.

Open in Gerrit

Related details

Attention is currently required from:

Nico Weber

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nico Weber (Gerrit)

unread,

Nov 15, 2025, 1:52:23 PM (7 days ago) Nov 15

to Lei Zhang, Nico Weber, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Lei Zhang

Nico Weber added 3 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Nico Weber . resolved

media/base/audio_buffer.h looks like rebase mistake or something, the rest lg

File chrome/services/speech/audio_source_fetcher_unittest.cc

Line 5, Patchset 6 (Parent):#include "chrome/services/speech/audio_source_fetcher_impl.h"

Nico Weber . unresolved

(this was probably here intentionally)

File media/base/audio_buffer.h

Line 315, Patchset 6 (Latest): int alignment);

Nico Weber . unresolved

?

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 15, 2025, 5:32:12 PM (7 days ago) Nov 15

to Lei Zhang, Nico Weber, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Nico Weber

Lei Zhang added 1 comment

File media/base/audio_buffer.h

Line 315, Patchset 6 (Latest): int alignment);

Nico Weber . resolved

?

Lei Zhang

It's in the CL desc. "To make forward declarations possible
in audio_buffer.h, slightly tweak the AudioBufferMemoryPool constructors
to avoid having a default argument."

Open in Gerrit

Related details

Attention is currently required from:

Nico Weber

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 15, 2025, 5:34:38 PM (7 days ago) Nov 15

to Lei Zhang, Nico Weber, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Nico Weber

Lei Zhang added 1 comment

File chrome/services/speech/audio_source_fetcher_unittest.cc

Line 5, Patchset 6 (Parent):#include "chrome/services/speech/audio_source_fetcher_impl.h"

Nico Weber . resolved

(this was probably here intentionally)

Lei Zhang

Either tools/add_header.py or clang-format moved it and I didn't put it back. It's back here.

Open in Gerrit

Related details

Attention is currently required from:

Nico Weber

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 15, 2025, 5:36:32 PM (7 days ago) Nov 15

to Lei Zhang, Nico Weber, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Nico Weber

Lei Zhang added 1 comment

File chrome/services/speech/audio_source_fetcher_unittest.cc

Line 5, Patchset 6 (Parent):#include "chrome/services/speech/audio_source_fetcher_impl.h"

Nico Weber . resolved

(this was probably here intentionally)

Lei Zhang

Either tools/add_header.py or clang-format moved it and I didn't put it back. It's back here.

Lei Zhang

Oh, it's clang-format and it stops me during the CL upload presubmit to ask if I meant it.

satisfied_requirement

unsatisfied_requirement

open

diffy

Nico Weber (Gerrit)

unread,

Nov 15, 2025, 6:04:39 PM (7 days ago) Nov 15

to Lei Zhang, Nico Weber, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Lei Zhang

Nico Weber added 1 comment

File media/base/audio_buffer.h

Line 315, Patchset 6: int alignment);

Nico Weber . unresolved

?

Lei Zhang

It's in the CL desc. "To make forward declarations possible
in audio_buffer.h, slightly tweak the AudioBufferMemoryPool constructors
to avoid having a default argument."

Nico Weber

The ctors are fine, but as far as I can tell you're adding a CreateWithAlignmentForTesting declaration that doesn't have a definition yet, and you're also not adding one. Or am I looking in the wrong place?

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 15, 2025, 9:09:39 PM (7 days ago) Nov 15

to Lei Zhang, Nico Weber, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Nico Weber

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Auto-Submit

+1

1 comment

File media/base/audio_buffer.h

Line 315, Patchset 6: int alignment);

Nico Weber . resolved

?

Lei Zhang

It's in the CL desc. "To make forward declarations possible
in audio_buffer.h, slightly tweak the AudioBufferMemoryPool constructors
to avoid having a default argument."

Nico Weber

The ctors are fine, but as far as I can tell you're adding a CreateWithAlignmentForTesting declaration that doesn't have a definition yet, and you're also not adding one. Or am I looking in the wrong place?

Lei Zhang

Oh, I must have changed directions and failed to delete this. Done.

Open in Gerrit

Related details

Attention is currently required from:

Nico Weber

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nico Weber (Gerrit)

unread,

Nov 15, 2025, 9:42:52 PM (7 days ago) Nov 15

to Lei Zhang, Nico Weber, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Lei Zhang

Nico Weber voted

Code-Review	+1
Commit-Queue	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 16, 2025, 1:24:59 AM (7 days ago) Nov 16

to Lei Zhang, Nico Weber, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, Chromium LUCI CQ, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Attention needed from Nico Weber

Lei Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Nico Weber

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Nov 16, 2025, 1:54:52 AM (7 days ago) Nov 16

to Lei Zhang, Nico Weber, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

Forward declare media::AudioBus more

Avoid including audio_bus.h in a couple of headers, as that transitively
spread to a ~2K translation units. To make forward declarations possible


in audio_buffer.h, slightly tweak the AudioBufferMemoryPool constructors

to avoid having a default argument. Then do IWYU to fix the build.

Change-Id: Ic4cb216f968541bc19a65c3869987f93c51e059a

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7155307

Owners-Override: Nico Weber <tha...@chromium.org>

Auto-Submit: Lei Zhang <the...@chromium.org>

Reviewed-by: Nico Weber <tha...@chromium.org>

Commit-Queue: Lei Zhang <the...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1545547}

Files:

M chrome/browser/ui/views/media_preview/mic_preview/audio_stream_coordinator_browsertest.cc
M chrome/services/speech/audio_source_fetcher_unittest.cc
M chromecast/media/audio/capture_service/BUILD.gn
M chromecast/media/audio/capture_service/message_parsing_utils.cc
M chromecast/media/audio/capture_service/message_parsing_utils_unittest.cc
M chromecast/media/audio/cast_audio_input_stream.cc
M chromecast/media/audio/cast_audio_manager_unittest.cc
M chromecast/media/audio/cast_audio_mixer.cc
M chromecast/media/audio/cast_audio_mixer_unittest.cc
M chromecast/media/audio/cast_audio_output_stream.cc
M chromecast/media/audio/cast_audio_output_stream_unittest.cc
M chromeos/ash/components/audio/public/cpp/sounds/test_data.cc
M chromeos/ash/services/recording/audio_capture_test_base.cc
M chromeos/services/tts/tts_player_unittest.cc
M chromeos/services/tts/tts_service_unittest.cc
M components/mirroring/service/openscreen_session_host.cc
M content/browser/speech/speech_recognition_browsertest.cc
M content/renderer/media/renderer_webaudiodevice_impl_unittest.cc
M fuchsia_web/webengine/renderer/web_engine_audio_output_device.cc
M media/audio/alsa/alsa_input.cc
M media/audio/alsa/alsa_output.cc
M media/audio/alsa/alsa_output_unittest.cc
M media/audio/android/audio_track_output_stream.cc
M media/audio/android/opensles_output.cc
M media/audio/apple/audio_auhal.cc
M media/audio/apple/audio_auhal_unittest.cc
M media/audio/apple/audio_input.cc
M media/audio/audio_encoders_unittest.cc
M media/audio/audio_input_stream_data_interceptor_unittest.cc
M media/audio/audio_io.h
M media/audio/audio_low_latency_input_output_unittest.cc
M media/audio/audio_manager_unittest.cc
M media/audio/audio_opus_encoder.cc
M media/audio/audio_output_proxy_unittest.cc
M media/audio/audio_output_resampler.cc
M media/audio/clockless_audio_sink.cc
M media/audio/cras/cras_input.cc
M media/audio/cras/cras_unified.cc
M media/audio/fake_audio_output_stream.cc
M media/audio/fuchsia/audio_input_stream_fuchsia.cc
M media/audio/fuchsia/audio_input_stream_fuchsia_test.cc
M media/audio/fuchsia/audio_output_stream_fuchsia.cc
M media/audio/mac/audio_loopback_input_mac_impl.mm
M media/audio/mac/avfoundation_output_stream.mm
M media/audio/mac/catap_audio_input_stream.mm
M media/audio/null_audio_sink.cc
M media/audio/pulse/pulse_output.cc
M media/audio/win/audio_low_latency_output_win.cc
M media/audio/win/audio_low_latency_output_win_unittest.cc
M media/audio/win/audio_output_win_unittest.cc
M media/audio/win/waveout_output_win.cc
M media/base/amplitude_peak_detector_unittest.cc
M media/base/audio_block_fifo.cc
M media/base/audio_buffer.cc
M media/base/audio_buffer.h
M media/base/audio_converter_perftest.cc
M media/base/audio_converter_unittest.cc
M media/base/audio_fifo.cc
M media/base/audio_fifo_unittest.cc
M media/base/audio_limiter.cc
M media/base/audio_limiter_perftest.cc
M media/base/audio_push_fifo.cc
M media/base/silent_sink_suspender.cc
M media/base/silent_sink_suspender_unittest.cc
M media/cast/encoding/audio_encoder.cc
M media/filters/mac/audio_toolbox_audio_decoder.cc
M media/mojo/clients/mojo_audio_encoder_unittest.cc
M media/webrtc/audio_processor.cc
M services/audio/device_listener_output_stream_unittest.cc
M services/audio/input_controller_unittest.cc
M services/audio/input_sync_writer.cc
M services/audio/loopback_mixin.cc
M services/audio/loopback_reference_manager_unittest.cc
M services/audio/mixing_graph_input_unittest.cc
M services/audio/output_device_mixer_impl_unittest.cc
M services/audio/processing_audio_fifo_unittest.cc
M services/audio/public/cpp/output_device_unittest.cc
A third_party/blink/renderer/bindings/modules/v8/serialization/DEPS
M third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules_test.cc
M third_party/blink/renderer/modules/ai/DEPS
M third_party/blink/renderer/modules/ai/language_model_prompt_builder.cc
M third_party/blink/renderer/modules/breakout_box/media_stream_audio_track_underlying_source_test.cc
M third_party/blink/renderer/modules/breakout_box/pushable_media_stream_audio_source_test.cc
M third_party/blink/renderer/modules/media/audio/audio_renderer_mixer_input_test.cc
M third_party/blink/renderer/modules/media/audio/audio_renderer_mixer_test.cc
M third_party/blink/renderer/modules/mediacapturefromelement/html_audio_element_capturer_source_unittest.cc
M third_party/blink/renderer/modules/mediarecorder/audio_track_mojo_encoder_unittest.cc
M third_party/blink/renderer/modules/mediarecorder/audio_track_opus_encoder.cc
M third_party/blink/renderer/modules/mediarecorder/audio_track_recorder_unittest.cc
M third_party/blink/renderer/modules/mediastream/track_audio_renderer_test.cc
M third_party/blink/renderer/modules/mediastream/webaudio_media_stream_audio_sink.cc
M third_party/blink/renderer/modules/webaudio/audio_node_input.cc
M third_party/blink/renderer/modules/webaudio/audio_node_output.cc
M third_party/blink/renderer/modules/webaudio/audio_param_handler.cc
M third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope_test.cc
M third_party/blink/renderer/modules/webaudio/audio_worklet_handler.cc
M third_party/blink/renderer/modules/webaudio/base_audio_context.cc
M third_party/blink/renderer/modules/webaudio/convolver_handler.cc
M third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_handler.cc
M third_party/blink/renderer/modules/webaudio/media_stream_audio_destination_handler_test.cc
M third_party/blink/renderer/modules/webaudio/offline_audio_destination_handler.cc
M third_party/blink/renderer/modules/webaudio/realtime_analyser.cc
M third_party/blink/renderer/modules/webaudio/script_processor_handler.cc
M third_party/blink/renderer/platform/audio/audio_bus.cc
M third_party/blink/renderer/platform/audio/audio_destination_test.cc
M third_party/blink/renderer/platform/audio/hrtf_elevation.cc
M third_party/blink/renderer/platform/audio/push_pull_fifo.cc
M third_party/blink/renderer/platform/audio/push_pull_fifo_multithread_test.cc
M third_party/blink/renderer/platform/audio/push_pull_fifo_test.cc
M third_party/blink/renderer/platform/audio/reverb.cc
M third_party/blink/renderer/platform/audio/sinc_resampler.cc
M third_party/blink/renderer/platform/exported/DEPS
M third_party/blink/renderer/platform/exported/web_audio_bus.cc
M third_party/blink/renderer/platform/media/web_audio_source_provider_impl.cc
M third_party/blink/renderer/platform/media/web_audio_source_provider_impl_test.cc
M third_party/blink/renderer/platform/mediastream/webaudio_media_stream_source.cc
M third_party/blink/renderer/platform/peerconnection/webrtc_audio_sink_test.cc

Change size: M

Delta: 117 files changed, 132 insertions(+), 10 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Nico Weber

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Fumitoshi Ukai (Gerrit)

unread,

Nov 16, 2025, 7:27:23 PM (6 days ago) Nov 16

to Lei Zhang, Chromium LUCI CQ, Fumitoshi Ukai, Nico Weber, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Fumitoshi Ukai added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Fumitoshi Ukai . resolved

failing chrome build?
https://issuetracker.google.com/461299465 error: incomplete type 'media::AudioBus' named in nested name specifier

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 16, 2025, 7:48:05 PM (6 days ago) Nov 16

to Lei Zhang, Chromium LUCI CQ, Fumitoshi Ukai, Nico Weber, Dale Curtis, Ale Bzk, chromium...@chromium.org, Kentaro Hara, Hongchan Choi, Raphael Kubo da Costa, Per Åhgren, Sam Zackrisson, Zijie He, blink-revie...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, emircan+watch...@chromium.org, feature-me...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, jasonrobe...@google.com, jbroma...@chromium.org, jophba...@chromium.org, jshin...@chromium.org, kinuko...@chromium.org, lcwu+...@chromium.org, mac-r...@chromium.org, marinacio...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+aud...@google.com, olka+...@chromium.org, oshima...@chromium.org, owenzhang+audio...@google.com, tommyw+w...@chromium.org, video-networking...@google.com

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Fumitoshi Ukai . resolved

failing chrome build?
https://issuetracker.google.com/461299465 error: incomplete type 'media::AudioBus' named in nested name specifier

Lei Zhang

On it. Sorry, I already landed some more CLs chained to this. It's easier to make a 1 line fix than to revert 3 CLs. Just need some OWNERS to approve.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Forward declare media::AudioBus more [chromium/src : main]

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Dale Curtis (Gerrit)

Dale Curtis voted and added 1 comment

Votes added by Dale Curtis

1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

1 comment

Related details

Nico Weber (Gerrit)

Nico Weber added 3 comments

Related details

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Nico Weber (Gerrit)

Nico Weber added 1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

1 comment

Related details

Nico Weber (Gerrit)

Nico Weber voted

Related details

Lei Zhang (Gerrit)

Lei Zhang voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Fumitoshi Ukai (Gerrit)

Fumitoshi Ukai added 1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang added 1 comment