Set Ready For Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
lgtm
It would be good to have web platform tests added that verify that a WebTransport session can still be established when `congestionControl` is specified in the constructor.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
connection.sent_packet_manager().SetSendAlgorithm(quic::kBBR);This might not be a good choice. I am looking for someone who knows.
connection.sent_packet_manager().SetSendAlgorithm(quic::kBBR);This might not be a good choice. I am looking for someone who knows.
Okay, I've confirmed that BBRv1 is not a good choice. Switch to kBBRv2 for now. We may have something better in future.
connection.sent_packet_manager().SetSendAlgorithm(quic::kBBR);Adam RiceThis might not be a good choice. I am looking for someone who knows.
Okay, I've confirmed that BBRv1 is not a good choice. Switch to kBBRv2 for now. We may have something better in future.
I will replace this BBR1 with BBRV2 and create a todo for the same so that we can track this and update whenever we have something better available for low latency than bbrv2.
For the wpt If I'm right, I think constructor.https.sub.any.js already tests session establishment with the congestionControl values in the constructor. I've also added a new congestion-control.https.any.js that verifies the attribute is readable after connection and returns the expected value.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
connection.sent_packet_manager().SetSendAlgorithm(quic::kBBR);Adam RiceThis might not be a good choice. I am looking for someone who knows.
Himanshu PanwarOkay, I've confirmed that BBRv1 is not a good choice. Switch to kBBRv2 for now. We may have something better in future.
I will replace this BBR1 with BBRV2 and create a todo for the same so that we can track this and update whenever we have something better available for low latency than bbrv2.
For the wpt If I'm right, I think constructor.https.sub.any.js already tests session establishment with the congestionControl values in the constructor. I've also added a new congestion-control.https.any.js that verifies the attribute is readable after connection and returns the expected value.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
LGTM; I did not look at anything other than the mojom files and runtime_enabled_features.json5.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59463.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +2 |
WebTransport: Add congestionControl hint (W3C spec compliance)
Implement the WebTransportCongestionControl enum, constructor option,
and readonly attribute per the W3C WebTransport spec.
The spec defines congestionControl as a hint for the preferred
congestion control algorithm — an enum {"default", "throughput",
"low-latency"} passed via WebTransportOptions and readable as a readonly
attribute on WebTransport.
Plumbing through all layers:
- Blink: New enum IDL, option, getter, Blink→Mojo conversion
- Mojo IPC: New enum + parameter on Connect() and CreateWebTransport()
- Browser: Thread through throttle/security callback chain
- Network service: Convert Mojo enum → net::CongestionControlHint
- net/QUIC: AdjustSendAlgorithm() maps "throughput" → BBR v2,
"low-latency" → BBR v1, "default" → no change (Cubic)
A global kWebTransportCongestionControl feature flag overrides
per-connection hints for Chrome-wide experiments.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59463
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |