import text: support for importing text modules (3/3) [chromium/src : main]

0 views
Skip to first unread message

Olivier Flückiger (Gerrit)

unread,
Jun 16, 2026, 2:32:24 PM (13 days ago) Jun 16
to Rakina Zata Amni, Kouhei Ueno, (Julie)Jeongeun Kim, James Maclean, Kevin McNee, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, francisjp...@google.com, dtseng+c...@chromium.org, anastas...@google.com, yuzo+...@chromium.org, feature-v...@chromium.org, dtseng...@chromium.org, katie...@chromium.org, nektar...@chromium.org, kyungjunle...@google.com, abigailbk...@google.com, josiah...@chromium.org, blink-re...@chromium.org, ipc-securi...@chromium.org, antoniosarto...@chromium.org, mkwst+w...@chromium.org, arthursonzog...@chromium.org, devtools-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, dmurph+watching...@chromium.org, storage...@chromium.org, chromium-a...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, network-ser...@chromium.org, loading-re...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading...@chromium.org
Attention needed from Kouhei Ueno and Rakina Zata Amni

Olivier Flückiger voted and added 1 comment

Votes added by Olivier Flückiger

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 48 (Latest):
Olivier Flückiger . resolved

ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Kouhei Ueno
  • Rakina Zata Amni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3b7fcb979a15888b2908770d060e7d0ae22130ec
Gerrit-Change-Number: 7844556
Gerrit-PatchSet: 48
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Jun 2026 18:32:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rakina Zata Amni (Gerrit)

unread,
Jun 17, 2026, 4:08:38 AM (13 days ago) Jun 17
to Olivier Flückiger, Kouhei Ueno, (Julie)Jeongeun Kim, James Maclean, Kevin McNee, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, francisjp...@google.com, dtseng+c...@chromium.org, anastas...@google.com, yuzo+...@chromium.org, feature-v...@chromium.org, dtseng...@chromium.org, katie...@chromium.org, nektar...@chromium.org, kyungjunle...@google.com, abigailbk...@google.com, josiah...@chromium.org, blink-re...@chromium.org, ipc-securi...@chromium.org, antoniosarto...@chromium.org, mkwst+w...@chromium.org, arthursonzog...@chromium.org, devtools-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, dmurph+watching...@chromium.org, storage...@chromium.org, chromium-a...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, network-ser...@chromium.org, loading-re...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading...@chromium.org
Attention needed from Kouhei Ueno and Olivier Flückiger

Rakina Zata Amni voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kouhei Ueno
  • Olivier Flückiger
Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Jun 2026 08:08:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kouhei Ueno (Gerrit)

unread,
Jun 24, 2026, 7:47:09 PM (5 days ago) Jun 24
to Olivier Flückiger, Rakina Zata Amni, (Julie)Jeongeun Kim, James Maclean, Kevin McNee, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, francisjp...@google.com, dtseng+c...@chromium.org, anastas...@google.com, yuzo+...@chromium.org, feature-v...@chromium.org, dtseng...@chromium.org, katie...@chromium.org, nektar...@chromium.org, kyungjunle...@google.com, abigailbk...@google.com, josiah...@chromium.org, blink-re...@chromium.org, ipc-securi...@chromium.org, antoniosarto...@chromium.org, mkwst+w...@chromium.org, arthursonzog...@chromium.org, devtools-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, dmurph+watching...@chromium.org, storage...@chromium.org, chromium-a...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, network-ser...@chromium.org, loading-re...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading...@chromium.org
Attention needed from Olivier Flückiger

Kouhei Ueno voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Olivier Flückiger
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3b7fcb979a15888b2908770d060e7d0ae22130ec
Gerrit-Change-Number: 7844556
Gerrit-PatchSet: 48
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Jun 2026 23:46:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 24, 2026, 9:11:22 PM (5 days ago) Jun 24
to Olivier Flückiger, Kouhei Ueno, Rakina Zata Amni, Akihiro Ota, (Julie)Jeongeun Kim, James Maclean, Kevin McNee, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, francisjp...@google.com, dtseng+c...@chromium.org, anastas...@google.com, yuzo+...@chromium.org, feature-v...@chromium.org, dtseng...@chromium.org, katie...@chromium.org, nektar...@chromium.org, kyungjunle...@google.com, abigailbk...@google.com, josiah...@chromium.org, blink-re...@chromium.org, ipc-securi...@chromium.org, antoniosarto...@chromium.org, mkwst+w...@chromium.org, arthursonzog...@chromium.org, devtools-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, dmurph+watching...@chromium.org, storage...@chromium.org, chromium-a...@chromium.org, edgesto...@microsoft.com, extension...@chromium.org, network-ser...@chromium.org, loading-re...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, loading...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
import text: support for importing text modules (3/3)

Wire up text module imports with the V8 support for importing them.
Add a feature flag and update test expectations.

Remaining failing WPT errors caused by WPT server (wptserve)
limitations, see
https://github.com/web-platform-tests/wpt/issues/51928.

See https://github.com/tc39/proposal-import-text

V8 side in https://crrev.com/c/7844854
Bug: 494350643
Change-Id: I3b7fcb979a15888b2908770d060e7d0ae22130ec
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Commit-Queue: Kouhei Ueno <kou...@chromium.org>
Auto-Submit: Olivier Flückiger <ol...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1652105}
Files:
  • M content/public/common/content_switch_dependent_feature_overrides.cc
  • M content/renderer/render_process_impl.cc
  • M testing/variations/fieldtrial_testing_config.json
  • M third_party/blink/renderer/core/loader/modulescript/module_script_creation_params.cc
  • M third_party/blink/renderer/core/loader/modulescript/module_script_creation_params.h
  • M third_party/blink/renderer/core/loader/modulescript/module_script_fetcher.cc
  • M third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc
  • M third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc
  • M third_party/blink/renderer/core/loader/resource/script_resource.cc
  • M third_party/blink/renderer/core/script/modulator_impl_base.cc
  • M third_party/blink/renderer/core/script/value_wrapper_synthetic_module_script.cc
  • M third_party/blink/renderer/core/script/value_wrapper_synthetic_module_script.h
  • M third_party/blink/renderer/platform/runtime_enabled_features.json5
  • D third_party/blink/web_tests/external/wpt/content-security-policy/connect-src/connect-src-text-import-allowed.sub-expected.txt
  • M third_party/blink/web_tests/external/wpt/fetch/api/request/destination/fetch-destination.https-expected.txt
  • D third_party/blink/web_tests/external/wpt/fetch/metadata/generated/script-text-module-import-static.https.sub-expected.txt
  • D third_party/blink/web_tests/external/wpt/fetch/metadata/generated/script-text-module-import-static.sub-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/charset-2-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/charset-bom.any-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/charset-bom.any.sharedworker-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/charset-bom.any.worker-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/charset-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/cors-crossorigin-requests-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/credentials.sub-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/http-accept-header.sub-expected.txt
  • M third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/ignore-content-type.any-expected.txt
  • M third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/ignore-content-type.any.sharedworker-expected.txt
  • M third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/ignore-content-type.any.worker-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/ignore-extension.any-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/ignore-extension.any.sharedworker-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/ignore-extension.any.worker-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/integrity-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/load-error-events-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/module-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/referrer-policies.sub-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/repeated-imports.any-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/repeated-imports.any.sharedworker-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/repeated-imports.any.worker-expected.txt
  • D third_party/blink/web_tests/external/wpt/html/semantics/scripting-1/the-script-element/text-module/service-worker-test.https-expected.txt
Change size: L
Delta: 39 files changed, 114 insertions(+), 853 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kouhei Ueno, +1 by Rakina Zata Amni
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3b7fcb979a15888b2908770d060e7d0ae22130ec
Gerrit-Change-Number: 7844556
Gerrit-PatchSet: 49
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages