[blink/bindings] Do not use bitfields in ParkableStringMetadata [chromium/src : main]
0 views
Skip to first unread message
Benoit Lize (Gerrit)
Oct 27, 2025, 10:03:22 AM (6 days ago) Oct 27
to Kouhei Ueno, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kouhei Ueno
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Kouhei Ueno
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Oct 27, 2025, 7:55:01 PM (6 days ago) Oct 27
to Benoit Lize, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Benoit Lize
Kouhei Ueno voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Benoit Lize
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benoit Lize (Gerrit)
Oct 28, 2025, 4:50:40 AM (5 days ago) Oct 28
to Kouhei Ueno, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Benoit Lize voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 28, 2025, 4:53:39 AM (5 days ago) Oct 28
to Benoit Lize, Kouhei Ueno, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[blink/bindings] Do not use bitfields in ParkableStringMetadata
While the current use of bitfield in ParkableStringMetadata is fine in
the absence of partial writes (which are not guaranteed by the
standard), it confuses prevention tools. Remove it, as the space savings
are very small.
Bug: 452863693
Change-Id: I5dfb3605d0340ce59bd7a8b1ee7fa37f311c98e1
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Commit-Queue: Benoit Lize <li...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1536519}
Files:
- M third_party/blink/renderer/platform/bindings/parkable_string.h
Change size: S
Delta: 1 file changed, 4 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kouhei Ueno
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages