[fedcm] Introduce the <federation> element (Blink Skeleton) [chromium/src : main]

0 views
Skip to first unread message

Sam Goto (Gerrit)

unread,
Feb 2, 2026, 8:24:11 PM (9 days ago) Feb 2
to Christian Biesinger, Dominic Farolino, Philip Jägenstedt, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Christian Biesinger, Dominic Farolino and Philip Jägenstedt

Sam Goto added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Sam Goto . resolved

@christian, could you take a look at this CL overall and its dependency chain?

@domfarolino and @foolip, could you take a look at the following files specifically:

  • third_party/blink/renderer/core/html/ build.gni
  • third_party/blink/renderer/core/html/ html_federation_element.h
  • third_party/blink/renderer/core/html/ html_federation_element.cc
  • third_party/blink/renderer/core/html/ html_federation_element.idl
  • third_party/blink/renderer/core/html/ html_tag_names.json5

But also sanity check more generally the different architectural approaches I explored here [1] and here [2]?

There are 5 CLs that build on top of this one to implement [2] incrementally, and I could use some high level guidance if this is directionally correct.

[1] Implementation options https://docs.google.com/document/d/1Zevn7l93U8Kj3hqr_AanifIRMDuJMy4mMyExGVY96v8/edit?resourcekey=0-Bwk0c3EyEKP3p0NtDFR1fw&tab=t.0#heading=h.gpzmcty9cy9a
[2] Web Platform API options https://github.com/fedidcg/federation-element

Open in Gerrit

Related details

Attention is currently required from:
  • Christian Biesinger
  • Dominic Farolino
  • Philip Jägenstedt
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2a3d98afa8e7b288ac27dfd6e0dea584ca702065
Gerrit-Change-Number: 7539468
Gerrit-PatchSet: 2
Gerrit-Owner: Sam Goto <go...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Reviewer: Sam Goto <go...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: Dominic Farolino <d...@chromium.org>
Gerrit-Attention: Christian Biesinger <cbies...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Feb 2026 01:24:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Christian Biesinger (Gerrit)

unread,
Feb 3, 2026, 12:56:27 PM (8 days ago) Feb 3
to Sam Goto, Christian Biesinger, Dominic Farolino, Philip Jägenstedt, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dominic Farolino, Philip Jägenstedt and Sam Goto

Christian Biesinger voted and added 1 comment

Votes added by Christian Biesinger

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Christian Biesinger . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
  • Philip Jägenstedt
  • Sam Goto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2a3d98afa8e7b288ac27dfd6e0dea584ca702065
Gerrit-Change-Number: 7539468
Gerrit-PatchSet: 4
Gerrit-Owner: Sam Goto <go...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Reviewer: Sam Goto <go...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: Dominic Farolino <d...@chromium.org>
Gerrit-Attention: Sam Goto <go...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Feb 2026 17:56:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Christian Biesinger (Gerrit)

unread,
Feb 3, 2026, 12:58:13 PM (8 days ago) Feb 3
to Sam Goto, Christian Biesinger, Dominic Farolino, Philip Jägenstedt, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dominic Farolino, Philip Jägenstedt and Sam Goto

Christian Biesinger added 1 comment

Patchset-level comments
Christian Biesinger . resolved

although I would have added the html_tag_names.json5 change to this CL as well

Gerrit-Comment-Date: Tue, 03 Feb 2026 17:58:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Christian Biesinger (Gerrit)

unread,
Feb 4, 2026, 12:27:35 PM (7 days ago) Feb 4
to Sam Goto, Christian Biesinger, Dominic Farolino, Philip Jägenstedt, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Dominic Farolino, Philip Jägenstedt and Sam Goto

Christian Biesinger voted and added 1 comment

Votes added by Christian Biesinger

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Christian Biesinger . resolved

lgtm but probably best to let someone who knows this better than me review this as well (maybe mason?)

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
  • Philip Jägenstedt
  • Sam Goto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2a3d98afa8e7b288ac27dfd6e0dea584ca702065
Gerrit-Change-Number: 7539468
Gerrit-PatchSet: 7
Gerrit-Owner: Sam Goto <go...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Reviewer: Sam Goto <go...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
Gerrit-Attention: Dominic Farolino <d...@chromium.org>
Gerrit-Attention: Sam Goto <go...@chromium.org>
Gerrit-Comment-Date: Wed, 04 Feb 2026 17:27:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Dominic Farolino (Gerrit)

unread,
Feb 4, 2026, 3:30:31 PM (7 days ago) Feb 4
to Sam Goto, Christian Biesinger, Philip Jägenstedt, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Philip Jägenstedt and Sam Goto

Dominic Farolino voted and added 2 comments

Votes added by Dominic Farolino

Code-Review+1

2 comments

Patchset-level comments
Dominic Farolino . resolved

LGTM

File third_party/blink/renderer/core/html/html_federation_element.idl
Line 5, Patchset 7 (Latest):[
Dominic Farolino . unresolved

Can you add a link to the public proposal right above here?

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Jägenstedt
  • Sam Goto
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2a3d98afa8e7b288ac27dfd6e0dea584ca702065
    Gerrit-Change-Number: 7539468
    Gerrit-PatchSet: 7
    Gerrit-Owner: Sam Goto <go...@chromium.org>
    Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
    Gerrit-Reviewer: Sam Goto <go...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
    Gerrit-Attention: Sam Goto <go...@chromium.org>
    Gerrit-Comment-Date: Wed, 04 Feb 2026 20:30:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sam Goto (Gerrit)

    unread,
    Feb 4, 2026, 3:35:43 PM (7 days ago) Feb 4
    to Dominic Farolino, Christian Biesinger, Philip Jägenstedt, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Philip Jägenstedt

    Sam Goto added 1 comment

    File third_party/blink/renderer/core/html/html_federation_element.idl
    Dominic Farolino . resolved

    Can you add a link to the public proposal right above here?

    Sam Goto

    Oh yeah, that's a great idea, done!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Philip Jägenstedt
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2a3d98afa8e7b288ac27dfd6e0dea584ca702065
      Gerrit-Change-Number: 7539468
      Gerrit-PatchSet: 7
      Gerrit-Owner: Sam Goto <go...@chromium.org>
      Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
      Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
      Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-Reviewer: Sam Goto <go...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-Comment-Date: Wed, 04 Feb 2026 20:35:33 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Dominic Farolino <d...@chromium.org>
      satisfied_requirement
      open
      diffy

      Sam Goto (Gerrit)

      unread,
      Feb 4, 2026, 3:37:52 PM (7 days ago) Feb 4
      to Dominic Farolino, Christian Biesinger, Philip Jägenstedt, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from Philip Jägenstedt

      Sam Goto voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Philip Jägenstedt
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2a3d98afa8e7b288ac27dfd6e0dea584ca702065
      Gerrit-Change-Number: 7539468
      Gerrit-PatchSet: 8
      Gerrit-Owner: Sam Goto <go...@chromium.org>
      Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
      Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
      Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-Reviewer: Sam Goto <go...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-Comment-Date: Wed, 04 Feb 2026 20:37:42 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Sam Goto (Gerrit)

      unread,
      Feb 4, 2026, 6:36:23 PM (7 days ago) Feb 4
      to Dominic Farolino, Christian Biesinger, Philip Jägenstedt, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Gerrit-Comment-Date: Wed, 04 Feb 2026 23:36:05 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Sam Goto (Gerrit)

      unread,
      Feb 4, 2026, 6:51:47 PM (7 days ago) Feb 4
      to Dominic Farolino, Christian Biesinger, Philip Jägenstedt, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from Philip Jägenstedt

      Sam Goto voted Commit-Queue+0

      Commit-Queue+0
      Gerrit-Comment-Date: Wed, 04 Feb 2026 23:51:36 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Sam Goto (Gerrit)

      unread,
      Feb 4, 2026, 7:52:21 PM (7 days ago) Feb 4
      to Dominic Farolino, Christian Biesinger, Philip Jägenstedt, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from Philip Jägenstedt

      Sam Goto voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Philip Jägenstedt
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2a3d98afa8e7b288ac27dfd6e0dea584ca702065
      Gerrit-Change-Number: 7539468
      Gerrit-PatchSet: 9
      Gerrit-Owner: Sam Goto <go...@chromium.org>
      Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
      Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
      Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-Reviewer: Sam Goto <go...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-Comment-Date: Thu, 05 Feb 2026 00:52:10 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Feb 4, 2026, 10:23:21 PM (7 days ago) Feb 4
      to Sam Goto, Dominic Farolino, Christian Biesinger, Philip Jägenstedt, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

      Chromium LUCI CQ submitted the change with unreviewed changes

      Unreviewed changes

      7 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: third_party/blink/renderer/core/html/html_federation_element.idl
      Insertions: 1, Deletions: 0.

      @@ -2,6 +2,7 @@
       // Use of this source code is governed by a BSD-style license that can be
       // found in the LICENSE file.
       
      +// Proposal https://github.com/fedidcg/federation-element
       [
           Exposed=Window,
           RuntimeEnabled=FederationElement
      ```

      Change information

      Commit message:
      [fedcm] Introduce the <federation> element (Blink Skeleton)

      This CL adds the minimal plumbing for the <federation> element in Blink,
      including the runtime feature flag, tag registration, and basic
      HTMLFederationElement class.

      Explainer:

      https://github.com/fedidcg/federation-element

      Intent To Prototype:

      https://groups.google.com/a/chromium.org/g/blink-dev/c/uXmdPPN2NUI/m/DpbG_eKBCQAJ

      Design Doc:

      https://docs.google.com/document/d/1Zevn7l93U8Kj3hqr_AanifIRMDuJMy4mMyExGVY96v8/edit?resourcekey=0-Bwk0c3EyEKP3p0NtDFR1fw&tab=t.0

      This is the first in a series of CLs to introduce a native <federation> element.
      Bug: none
      Change-Id: I2a3d98afa8e7b288ac27dfd6e0dea584ca702065
      Reviewed-by: Christian Biesinger <cbies...@chromium.org>
      Reviewed-by: Dominic Farolino <d...@chromium.org>
      Commit-Queue: Sam Goto <go...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1579854}
      Files:
      • M third_party/blink/renderer/bindings/generated_in_core.gni
      • M third_party/blink/renderer/bindings/idl_in_core.gni
      • M third_party/blink/renderer/core/html/build.gni
      • A third_party/blink/renderer/core/html/html_federation_element.cc
      • A third_party/blink/renderer/core/html/html_federation_element.h
      • A third_party/blink/renderer/core/html/html_federation_element.idl
      • M third_party/blink/renderer/core/html/html_tag_names.json5
      • M third_party/blink/renderer/core/sanitizer/builtins_generate_config.py
      • M third_party/blink/renderer/platform/runtime_enabled_features.json5
      • M third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
      • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
      Change size: M
      Delta: 11 files changed, 68 insertions(+), 1 deletion(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Christian Biesinger, +1 by Dominic Farolino
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2a3d98afa8e7b288ac27dfd6e0dea584ca702065
      Gerrit-Change-Number: 7539468
      Gerrit-PatchSet: 10
      Gerrit-Owner: Sam Goto <go...@chromium.org>
      Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
      Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>
      Gerrit-Reviewer: Sam Goto <go...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages