[gin] Delete DeprecatedWrappable [chromium/src : main]

71 views
Skip to first unread message

Andreas Haas (Gerrit)

unread,
May 12, 2026, 6:39:33 AM (7 days ago) May 12
to Michael Lippautz, Chromium LUCI CQ, Raphael Kubo da Costa, Kentaro Hara, android-bu...@system.gserviceaccount.com, kinuko...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Michael Lippautz

Andreas Haas added 1 comment

Patchset-level comments
File-level comment, Patchset 3:
Andreas Haas . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I172974edf007dd29810830b4f5ee18a5437a35ae
Gerrit-Change-Number: 7837883
Gerrit-PatchSet: 3
Gerrit-Owner: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Tue, 12 May 2026 10:39:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
May 12, 2026, 11:29:44 AM (7 days ago) May 12
to Andreas Haas, Chromium LUCI CQ, Raphael Kubo da Costa, Kentaro Hara, android-bu...@system.gserviceaccount.com, kinuko...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Andreas Haas

Michael Lippautz voted and added 2 comments

Votes added by Michael Lippautz

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Michael Lippautz . resolved

lgtm!

File third_party/blink/renderer/platform/bindings/v8_dom_wrapper.cc
Line 77, Patchset 4 (Parent): // TODO(b/328117814): this works as long as other embedders within the
Michael Lippautz . unresolved

Is this done now? Maybe attach the bug as well

Open in Gerrit

Related details

Attention is currently required from:
  • Andreas Haas
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I172974edf007dd29810830b4f5ee18a5437a35ae
    Gerrit-Change-Number: 7837883
    Gerrit-PatchSet: 4
    Gerrit-Owner: Andreas Haas <ah...@chromium.org>
    Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Andreas Haas <ah...@chromium.org>
    Gerrit-Comment-Date: Tue, 12 May 2026 15:29:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andreas Haas (Gerrit)

    unread,
    May 13, 2026, 3:06:58 AM (6 days ago) May 13
    to Kentaro Hara, Michael Lippautz, Chromium LUCI CQ, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, kinuko...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
    Attention needed from Kentaro Hara

    Andreas Haas added 2 comments

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    Andreas Haas . resolved

    Kentaro, could you please take a look at content/*

    File third_party/blink/renderer/platform/bindings/v8_dom_wrapper.cc
    Line 77, Patchset 4 (Parent): // TODO(b/328117814): this works as long as other embedders within the
    Michael Lippautz . resolved

    Is this done now? Maybe attach the bug as well

    Andreas Haas

    Yes, this is now done in `ToWrapperTypeInfo`

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kentaro Hara
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I172974edf007dd29810830b4f5ee18a5437a35ae
      Gerrit-Change-Number: 7837883
      Gerrit-PatchSet: 5
      Gerrit-Owner: Andreas Haas <ah...@chromium.org>
      Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>
      Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
      Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
      Gerrit-Attention: Kentaro Hara <har...@chromium.org>
      Gerrit-Comment-Date: Wed, 13 May 2026 07:06:39 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Michael Lippautz <mlip...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages