[CoCE] Implement media constraints support for HTMLUserMediaElement [chromium/src : main]

0 views

Skip to first unread message

Thomas Nguyen (Gerrit)

unread,

Mar 11, 2026, 6:47:10 AM (yesterday) Mar 11

to Raphael Kubo da Costa, Kentaro Hara, Mason Freed, AI Code Reviewer, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, srirama chandra sekhar, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, jmedle...@chromium.org, tommyw+w...@chromium.org

Attention needed from Mason Freed

Thomas Nguyen added 1 comment

File third_party/blink/renderer/modules/mediastream/user_media_element_constraints.idl

Line 5, Patchset 4:[RuntimeEnabled=UserMediaElement]

Mason Freed . resolved

Does this need `ImplementedAs=UserMediaElementConstraints` or something?
Also, shouldn't this file get added to a GNI file (like `idl_in_modules.gni`)?
Does this patch compile?

Thomas Nguyen

Oh, did not find that as the compile still succeeded. I left the idl change in another CL in chain. Let's move it here, it makes more sense.

Thomas Nguyen

Also, moved the change in generated_in_modules.gni from next CL to here.

Open in Gerrit

Related details

Attention is currently required from:

Mason Freed

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages