[M138-LTS][bindings] Perform detach check when passing span instead of retaining underlying array buffer [chromium/src : refs/branch-heads/7204]

0 views
Skip to first unread message

Tiago Vignatti (xWF) (Gerrit)

unread,
Apr 1, 2026, 10:47:42 AM (20 hours ago) Apr 1
to Victor Gabriel Savu, Andrey Kosyakov, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Attention needed from Andrey Kosyakov and Victor Gabriel Savu

Tiago Vignatti (xWF) added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tiago Vignatti (xWF) . resolved

The bug was approved for M138 LTS. PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Victor Gabriel Savu
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7204
Gerrit-Change-Id: I17603e4f4345beb6959f1f578a73ec540795811f
Gerrit-Change-Number: 7716642
Gerrit-PatchSet: 1
Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Victor Gabriel Savu <vs...@google.com>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 14:47:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Victor Gabriel Savu (Gerrit)

unread,
Apr 1, 2026, 10:59:04 AM (20 hours ago) Apr 1
to Tiago Vignatti (xWF), Andrey Kosyakov, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
Attention needed from Andrey Kosyakov and Tiago Vignatti (xWF)

Victor Gabriel Savu added 1 comment

Commit Message
Line 13, Patchset 1 (Latest):(cherry picked from commit 0e84e9b32b74e72de294c58fa03042cb6cffc715)
Victor Gabriel Savu . unresolved

Did you create this cherry-pick by hand? Can you use gerrit instead to add the right tags to make it clear that this is a clean cherry-pick?

Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Tiago Vignatti (xWF)
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedLint
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7204
    Gerrit-Change-Id: I17603e4f4345beb6959f1f578a73ec540795811f
    Gerrit-Change-Number: 7716642
    Gerrit-PatchSet: 1
    Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
    Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
    Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Attention: Tiago Vignatti (xWF) <vign...@google.com>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 14:58:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Tiago Vignatti (xWF) (Gerrit)

    unread,
    Apr 1, 2026, 11:16:18 AM (19 hours ago) Apr 1
    to Victor Gabriel Savu, Andrey Kosyakov, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
    Attention needed from Andrey Kosyakov and Victor Gabriel Savu

    Tiago Vignatti (xWF) added 1 comment

    Commit Message
    Line 13, Patchset 1 (Latest):(cherry picked from commit 0e84e9b32b74e72de294c58fa03042cb6cffc715)
    Victor Gabriel Savu . resolved

    Did you create this cherry-pick by hand? Can you use gerrit instead to add the right tags to make it clear that this is a clean cherry-pick?

    Tiago Vignatti (xWF)

    I didn't know how to create a chain of cherry-picked CLs in Gerrit UI, so I've used the following instructions to do by hand: https://chromium.googlesource.com/chromium/src.git/+/refs/heads/main/docs/process/merge_request.md#using-git-manual

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrey Kosyakov
    • Victor Gabriel Savu
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedLint
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7204
      Gerrit-Change-Id: I17603e4f4345beb6959f1f578a73ec540795811f
      Gerrit-Change-Number: 7716642
      Gerrit-PatchSet: 1
      Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
      Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
      Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
      Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
      Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Victor Gabriel Savu <vs...@google.com>
      Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
      Gerrit-Comment-Date: Wed, 01 Apr 2026 15:16:08 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Victor Gabriel Savu <vs...@google.com>
      unsatisfied_requirement
      open
      diffy

      Andrey Kosyakov (Gerrit)

      unread,
      Apr 1, 2026, 2:39:44 PM (16 hours ago) Apr 1
      to Tiago Vignatti (xWF), Victor Gabriel Savu, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jshin...@chromium.org
      Attention needed from Tiago Vignatti (xWF) and Victor Gabriel Savu

      Andrey Kosyakov voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Tiago Vignatti (xWF)
      • Victor Gabriel Savu
      Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedLint
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7204
      Gerrit-Change-Id: I17603e4f4345beb6959f1f578a73ec540795811f
      Gerrit-Change-Number: 7716642
      Gerrit-PatchSet: 1
      Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
      Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
      Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
      Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
      Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Victor Gabriel Savu <vs...@google.com>
      Gerrit-Attention: Tiago Vignatti (xWF) <vign...@google.com>
      Gerrit-Comment-Date: Wed, 01 Apr 2026 18:39:29 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages