Make PromiseAll::resolver_ not fail the ScriptPromiseResolver detach check [chromium/src : main]
0 views
Skip to first unread message
Nate Chapin (Gerrit)
Jan 14, 2026, 5:14:27 PM (2 days ago) Jan 14
to Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Andrey Kosyakov
Nate Chapin added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/bindings/core/v8/promise_all.h
Line 51, Patchset 1 (Latest):
resolver_->SuppressDetachCheck();Nate Chapin . unresolved
Which is better: this, or holding `promises` as a class member to prevent GC (i.e., potentially leak for the lifetime of the window)?
Related details
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Jan 14, 2026, 5:17:20 PM (2 days ago) Jan 14
to Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Nate Chapin
Andrey Kosyakov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/renderer/bindings/core/v8/promise_all.h
Which is better: this, or holding `promises` as a class member to prevent GC (i.e., potentially leak for the lifetime of the window)?
Attention is currently required from:
- Nate Chapin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Chapin (Gerrit)
Jan 14, 2026, 5:17:47 PM (2 days ago) Jan 14
to Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Nate Chapin voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 14, 2026, 7:04:45 PM (2 days ago) Jan 14
to Nate Chapin, Andrey Kosyakov, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Make PromiseAll::resolver_ not fail the ScriptPromiseResolver detach check
The promises given to PromiseAll might not be under blink's control,
and can hang or be GCed without ever resolving.
Fixed: 475251679
Change-Id: Ib078ed2dd20497d780e9adc795bac62055b12fc9
Commit-Queue: Nate Chapin <jap...@chromium.org>
Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1569410}
Files:
- M third_party/blink/renderer/bindings/core/v8/promise_all.h
Change size: XS
Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrey Kosyakov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages