Privatize some member functions in StyleAdjuster. [chromium/src : main]

0 views
Skip to first unread message

Steinar H Gunderson (Gerrit)

unread,
Apr 1, 2026, 10:09:43 AM (21 hours ago) Apr 1
to Raphael Kubo da Costa, Kenneth Rohde Christiansen, Stephen Chenney, srirama chandra sekhar, Olga Gerchikov, chromium...@chromium.org, Fredrik Söderquist, Menard, Alexis, Kentaro Hara, Dirk Schulze, blink-re...@chromium.org, dbaro...@chromium.org, blink-rev...@chromium.org, dgroga...@chromium.org, gl...@chromium.org, fmalit...@chromium.org, silv...@chromium.org, apavlo...@chromium.org, pdr+svgw...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, eric.c...@apple.com, blink-revie...@chromium.org, blink-...@chromium.org, kouhe...@chromium.org, dominicc+...@chromium.org, dom+...@chromium.org

Steinar H Gunderson has uploaded the change for review

Commit message

Privatize some member functions in StyleAdjuster.
Change-Id: I7a5f1021f1f11f6a0bccbded03fcdf4f6874eba1

Change diff

diff --git a/third_party/blink/renderer/core/css/resolver/style_adjuster.h b/third_party/blink/renderer/core/css/resolver/style_adjuster.h
index ff18c876..1c1f4bd6 100644
--- a/third_party/blink/renderer/core/css/resolver/style_adjuster.h
+++ b/third_party/blink/renderer/core/css/resolver/style_adjuster.h
@@ -44,20 +44,21 @@
  public:
   CORE_EXPORT static void AdjustComputedStyle(StyleResolverState&, Element*);
   static void AdjustStyleForCombinedText(ComputedStyleBuilder&);
-  static void AdjustStyleForEditing(ComputedStyleBuilder&, Element*);
   static void AdjustStyleForTextCombine(ComputedStyleBuilder&);
+  static void AdjustStyleForEditing(ComputedStyleBuilder&, Element*);
+  static void AdjustStyleForDisplay(ComputedStyleBuilder&,
+                                    const ComputedStyle& layout_parent_style,
+                                    const Element*,
+                                    Document*);
+
+ private:
   static void AdjustStyleForSvgElement(
       const SVGElement& element,
       const SVGElement* styled_element,
       ComputedStyleBuilder& builder,
       const ComputedStyle& layout_parent_style);
-  static void AdjustStyleForDisplay(ComputedStyleBuilder&,
-                                    const ComputedStyle& layout_parent_style,
-                                    const Element*,
-                                    Document*);
   static void AdjustStyleForHTMLElement(ComputedStyleBuilder&, HTMLElement&);
 
- private:
   static bool IsEditableElement(Element*, const ComputedStyleBuilder&);
   static bool IsPasswordFieldWithUnrevealedPassword(Element*);
   static void AdjustEffectiveTouchAction(ComputedStyleBuilder&,

Change information

Files:
  • M third_party/blink/renderer/core/css/resolver/style_adjuster.h
Change size: S
Delta: 1 file changed, 7 insertions(+), 6 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a5f1021f1f11f6a0bccbded03fcdf4f6874eba1
Gerrit-Change-Number: 7721142
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
Apr 1, 2026, 10:22:21 AM (20 hours ago) Apr 1
to Steinar H Gunderson, Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Kentaro Hara, Kenneth Rohde Christiansen, Raphael Kubo da Costa, Stephen Chenney, srirama chandra sekhar, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dbaro...@chromium.org, dgroga...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, fmalit...@chromium.org, gl...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, silv...@chromium.org
Attention needed from Steinar H Gunderson

Rune Lillesveen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a5f1021f1f11f6a0bccbded03fcdf4f6874eba1
    Gerrit-Change-Number: 7721142
    Gerrit-PatchSet: 1
    Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Fredrik Söderquist <f...@opera.com>
    Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 14:22:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Steinar H Gunderson (Gerrit)

    unread,
    Apr 1, 2026, 10:30:25 AM (20 hours ago) Apr 1
    to Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Kentaro Hara, Kenneth Rohde Christiansen, Raphael Kubo da Costa, Stephen Chenney, srirama chandra sekhar, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dbaro...@chromium.org, dgroga...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, fmalit...@chromium.org, gl...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, silv...@chromium.org

    Steinar H Gunderson voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a5f1021f1f11f6a0bccbded03fcdf4f6874eba1
    Gerrit-Change-Number: 7721142
    Gerrit-PatchSet: 2
    Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Fredrik Söderquist <f...@opera.com>
    Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 14:30:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 1, 2026, 11:35:40 AM (19 hours ago) Apr 1
    to Steinar H Gunderson, Rune Lillesveen, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, Kentaro Hara, Kenneth Rohde Christiansen, Raphael Kubo da Costa, Stephen Chenney, srirama chandra sekhar, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dbaro...@chromium.org, dgroga...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, fmalit...@chromium.org, gl...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, pdr+svgw...@chromium.org, silv...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Privatize some member functions in StyleAdjuster.
    Change-Id: I7a5f1021f1f11f6a0bccbded03fcdf4f6874eba1
    Reviewed-by: Rune Lillesveen <fut...@chromium.org>
    Commit-Queue: Steinar H Gunderson <se...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1608553}
    Files:
    • M third_party/blink/renderer/core/css/resolver/style_adjuster.h
    Change size: S
    Delta: 1 file changed, 7 insertions(+), 6 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Rune Lillesveen
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a5f1021f1f11f6a0bccbded03fcdf4f6874eba1
    Gerrit-Change-Number: 7721142
    Gerrit-PatchSet: 3
    Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages