Add WebTransportSendStream interface with sendGroup/sendOrder [chromium/src : main]

33 views
Skip to first unread message

Mayur Patil (Gerrit)

unread,
Mar 25, 2026, 1:57:29 AM (8 days ago) Mar 25
to krishna dheeraj Pannala, Himanshu Panwar, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Himanshu Panwar and krishna dheeraj Pannala

Mayur Patil added 1 comment

File third_party/blink/renderer/modules/webtransport/web_transport.cc
Line 1676, Patchset 10 (Latest): WritableStream* writable_stream;
Mayur Patil . unresolved
nit: Per Chromium convention, local pointer variables should be initialized
```
WritableStream* writable_stream = nullptr;
OutgoingStream* outgoing_stream = nullptr;
```
Open in Gerrit

Related details

Attention is currently required from:
  • Himanshu Panwar
  • krishna dheeraj Pannala
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c16f6f2e5729b4beac6f4b1fa520ef2ff2e4ba9
Gerrit-Change-Number: 7679612
Gerrit-PatchSet: 10
Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-Reviewer: Himanshu Panwar <himp...@microsoft.com>
Gerrit-Reviewer: Mayur Patil <patil...@microsoft.com>
Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Himanshu Panwar <himp...@microsoft.com>
Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-Comment-Date: Wed, 25 Mar 2026 05:57:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nidhi Jaju (Gerrit)

unread,
Mar 26, 2026, 9:56:44 PM (6 days ago) Mar 26
to krishna dheeraj Pannala, Adam Rice, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Adam Rice and krishna dheeraj Pannala

Nidhi Jaju added 2 comments

File third_party/blink/renderer/modules/webtransport/bidirectional_stream.cc
Line 48, Patchset 10 (Latest): outgoing_stream_->InitWithExistingWritableStream(send_stream_.Get(),
Nidhi Jaju . unresolved

This breaks encapsulation, as BidirectionalStream should not need to orchestrate the internal wiring of its child stream. Can we use `DynamicTo<>` to resolve the exact type at runtime and call its respective Init() method? This will allow us to remove the `outgoing_stream_` member variable from this class.

File third_party/blink/web_tests/external/wpt/webtransport/sendorder.https.any-expected.txt
Line 4, Patchset 10 (Latest):[FAIL] WebTransport client should be able to modify unset sendOrder after stream creation
Nidhi Jaju . unresolved

It looks like we should update the WPT since https://github.com/w3c/webtransport/pull/548 made sendOrder no longer nullable.

Can we update the tests in https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/webtransport/sendorder.https.any.js to match the spec?

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • krishna dheeraj Pannala
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c16f6f2e5729b4beac6f4b1fa520ef2ff2e4ba9
Gerrit-Change-Number: 7679612
Gerrit-PatchSet: 10
Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Comment-Date: Fri, 27 Mar 2026 01:56:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

krishna dheeraj Pannala (Gerrit)

unread,
Mar 27, 2026, 6:26:05 AM (6 days ago) Mar 27
to Nidhi Jaju, Adam Rice, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Adam Rice and Nidhi Jaju

krishna dheeraj Pannala added 2 comments

File third_party/blink/renderer/modules/webtransport/bidirectional_stream.cc
Line 48, Patchset 10: outgoing_stream_->InitWithExistingWritableStream(send_stream_.Get(),
Nidhi Jaju . resolved

This breaks encapsulation, as BidirectionalStream should not need to orchestrate the internal wiring of its child stream. Can we use `DynamicTo<>` to resolve the exact type at runtime and call its respective Init() method? This will allow us to remove the `outgoing_stream_` member variable from this class.

krishna dheeraj Pannala

Done. `Init()` and `GetOutgoingStream()` now use `DynamicTo<WebTransportSendStream>` to resolve the concrete type at runtime and dispatch to the child's own `Init()/GetOutgoingStream()`. The `outgoing_stream_` member has been removed from `BidirectionalStream`.

Note: SendStream lacks `DowncastTraits` (it has no IDL binding), so `DynamicTo<SendStream>` isn't available for the fallback path. We `CHECK` non-null and rely on the constructor-established type invariant for the static_cast there.

File third_party/blink/web_tests/external/wpt/webtransport/sendorder.https.any-expected.txt
Line 4, Patchset 10:[FAIL] WebTransport client should be able to modify unset sendOrder after stream creation
Nidhi Jaju . resolved

It looks like we should update the WPT since https://github.com/w3c/webtransport/pull/548 made sendOrder no longer nullable.

Can we update the tests in https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/webtransport/sendorder.https.any.js to match the spec?

krishna dheeraj Pannala

Done. Updated sendorder.https.any.js to match the spec change

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Nidhi Jaju
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c16f6f2e5729b4beac6f4b1fa520ef2ff2e4ba9
Gerrit-Change-Number: 7679612
Gerrit-PatchSet: 11
Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Comment-Date: Fri, 27 Mar 2026 10:25:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nidhi Jaju <nidh...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Nidhi Jaju (Gerrit)

unread,
Mar 30, 2026, 1:54:14 AM (3 days ago) Mar 30
to krishna dheeraj Pannala, Adam Rice, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Adam Rice and krishna dheeraj Pannala

Nidhi Jaju voted and added 1 comment

Votes added by Nidhi Jaju

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • krishna dheeraj Pannala
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c16f6f2e5729b4beac6f4b1fa520ef2ff2e4ba9
Gerrit-Change-Number: 7679612
Gerrit-PatchSet: 11
Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-Attention: Adam Rice <ri...@chromium.org>
Gerrit-Comment-Date: Mon, 30 Mar 2026 05:53:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Adam Rice (Gerrit)

unread,
Apr 1, 2026, 3:22:18 AM (yesterday) Apr 1
to krishna dheeraj Pannala, Nidhi Jaju, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from krishna dheeraj Pannala

Adam Rice voted and added 1 comment

Votes added by Adam Rice

Code-Review+1

1 comment

Patchset-level comments
Adam Rice . resolved

lgtm, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • krishna dheeraj Pannala
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c16f6f2e5729b4beac6f4b1fa520ef2ff2e4ba9
Gerrit-Change-Number: 7679612
Gerrit-PatchSet: 11
Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>
Gerrit-Comment-Date: Wed, 01 Apr 2026 07:21:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

krishna dheeraj Pannala (Gerrit)

unread,
Apr 1, 2026, 4:46:47 AM (yesterday) Apr 1
to Adam Rice, Nidhi Jaju, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
Attention needed from Adam Rice and Nidhi Jaju

krishna dheeraj Pannala added 1 comment

File third_party/blink/renderer/modules/webtransport/web_transport.cc
Line 1676, Patchset 10: WritableStream* writable_stream;
Mayur Patil . resolved
nit: Per Chromium convention, local pointer variables should be initialized
```
WritableStream* writable_stream = nullptr;
OutgoingStream* outgoing_stream = nullptr;
```
krishna dheeraj Pannala

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Rice
  • Nidhi Jaju
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1c16f6f2e5729b4beac6f4b1fa520ef2ff2e4ba9
    Gerrit-Change-Number: 7679612
    Gerrit-PatchSet: 12
    Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>
    Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
    Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-Attention: Adam Rice <ri...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 08:46:21 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Mayur Patil <patil...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    suresh potti (Gerrit)

    unread,
    Apr 1, 2026, 4:47:57 AM (yesterday) Apr 1
    to krishna dheeraj Pannala, Adam Rice, Nidhi Jaju, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
    Attention needed from Adam Rice, Nidhi Jaju and krishna dheeraj Pannala

    suresh potti voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adam Rice
    • Nidhi Jaju
    • krishna dheeraj Pannala
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1c16f6f2e5729b4beac6f4b1fa520ef2ff2e4ba9
    Gerrit-Change-Number: 7679612
    Gerrit-PatchSet: 12
    Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>
    Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
    Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>
    Gerrit-Reviewer: suresh potti <sures...@microsoft.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>
    Gerrit-Attention: Adam Rice <ri...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 08:47:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Adam Rice (Gerrit)

    unread,
    12:53 AM (6 hours ago) 12:53 AM
    to krishna dheeraj Pannala, suresh potti, Nidhi Jaju, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
    Attention needed from Nidhi Jaju and krishna dheeraj Pannala

    Adam Rice voted and added 1 comment

    Votes added by Adam Rice

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 12 (Latest):
    Adam Rice . resolved

    PS12 still lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nidhi Jaju
    • krishna dheeraj Pannala
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1c16f6f2e5729b4beac6f4b1fa520ef2ff2e4ba9
      Gerrit-Change-Number: 7679612
      Gerrit-PatchSet: 12
      Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>
      Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
      Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
      Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>
      Gerrit-Reviewer: suresh potti <sures...@microsoft.com>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
      Gerrit-Attention: krishna dheeraj Pannala <kpan...@microsoft.com>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 04:52:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      krishna dheeraj Pannala (Gerrit)

      unread,
      12:53 AM (6 hours ago) 12:53 AM
      to Adam Rice, suresh potti, Nidhi Jaju, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
      Attention needed from Nidhi Jaju

      krishna dheeraj Pannala voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Nidhi Jaju
      Gerrit-Comment-Date: Thu, 02 Apr 2026 04:53:30 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Blink W3C Test Autoroller (Gerrit)

      unread,
      12:57 AM (6 hours ago) 12:57 AM
      to krishna dheeraj Pannala, Adam Rice, suresh potti, Nidhi Jaju, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org
      Attention needed from Nidhi Jaju

      Message from Blink W3C Test Autoroller

      Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/58935.

      When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

      WPT Export docs:
      https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Nidhi Jaju
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1c16f6f2e5729b4beac6f4b1fa520ef2ff2e4ba9
      Gerrit-Change-Number: 7679612
      Gerrit-PatchSet: 12
      Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>
      Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
      Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
      Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>
      Gerrit-Reviewer: suresh potti <sures...@microsoft.com>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 04:56:50 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      1:21 AM (5 hours ago) 1:21 AM
      to krishna dheeraj Pannala, Blink W3C Test Autoroller, Adam Rice, suresh potti, Nidhi Jaju, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Add WebTransportSendStream interface with sendGroup/sendOrder

      Introduce the WebTransportSendStream interface a WritableStream subclass
      with sendGroup and sendOrder attributes per the W3C WebTransport spec.

      When the WebTransportSendGroup runtime flag is enabled,
      createUnidirectionalStream() and createBidirectionalStream() now return
      WebTransportSendStream objects instead of plain
      WritableStream/SendStream. When the flag is off, behavior is unchanged.

      This CL also extracts the duplicated OutgoingStreamClient into a shared
      header used by both SendStream and WebTransportSendStream.

      Setters are local-only stubs — Mojo plumbing for network-side priority
      updates will be added in a follow-up CL.
      Bug: 487117768
      Change-Id: I1c16f6f2e5729b4beac6f4b1fa520ef2ff2e4ba9
      Reviewed-by: suresh potti <sures...@microsoft.com>
      Reviewed-by: Adam Rice <ri...@chromium.org>
      Commit-Queue: krishna dheeraj Pannala <kpan...@microsoft.com>
      Cr-Commit-Position: refs/heads/main@{#1608979}
      Files:
      • M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
      • M third_party/blink/renderer/bindings/generated_in_modules.gni
      • M third_party/blink/renderer/bindings/idl_in_modules.gni
      • M third_party/blink/renderer/modules/webtransport/BUILD.gn
      • M third_party/blink/renderer/modules/webtransport/bidirectional_stream.cc
      • M third_party/blink/renderer/modules/webtransport/bidirectional_stream.h
      • A third_party/blink/renderer/modules/webtransport/outgoing_stream_client.h
      • M third_party/blink/renderer/modules/webtransport/send_stream.cc
      • M third_party/blink/renderer/modules/webtransport/web_transport.cc
      • M third_party/blink/renderer/modules/webtransport/web_transport_send_group.h
      • A third_party/blink/renderer/modules/webtransport/web_transport_send_stream.cc
      • A third_party/blink/renderer/modules/webtransport/web_transport_send_stream.h
      • A third_party/blink/renderer/modules/webtransport/web_transport_send_stream.idl
      • M third_party/blink/renderer/modules/webtransport/web_transport_test.cc
      • M third_party/blink/web_tests/external/wpt/webtransport/idlharness.https.sub.any-expected.txt
      • M third_party/blink/web_tests/external/wpt/webtransport/idlharness.https.sub.any.serviceworker-expected.txt
      • M third_party/blink/web_tests/external/wpt/webtransport/idlharness.https.sub.any.sharedworker-expected.txt
      • M third_party/blink/web_tests/external/wpt/webtransport/idlharness.https.sub.any.worker-expected.txt
      • M third_party/blink/web_tests/external/wpt/webtransport/sendorder.https.any-expected.txt
      • M third_party/blink/web_tests/external/wpt/webtransport/sendorder.https.any.js
      • M third_party/blink/web_tests/external/wpt/webtransport/sendorder.https.any.serviceworker-expected.txt
      • M third_party/blink/web_tests/external/wpt/webtransport/sendorder.https.any.sharedworker-expected.txt
      • M third_party/blink/web_tests/external/wpt/webtransport/sendorder.https.any.worker-expected.txt
      • M third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
      • M third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
      • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
      • M third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt
      Change size: L
      Delta: 27 files changed, 693 insertions(+), 164 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Adam Rice, +1 by suresh potti
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I1c16f6f2e5729b4beac6f4b1fa520ef2ff2e4ba9
      Gerrit-Change-Number: 7679612
      Gerrit-PatchSet: 13
      Gerrit-Owner: krishna dheeraj Pannala <kpan...@microsoft.com>
      Gerrit-Reviewer: Adam Rice <ri...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
      Gerrit-Reviewer: krishna dheeraj Pannala <kpan...@microsoft.com>
      Gerrit-Reviewer: suresh potti <sures...@microsoft.com>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      open
      diffy
      satisfied_requirement

      Julia Sobiech (Gerrit)

      unread,
      5:15 AM (1 hour ago) 5:15 AM
      to Chromium LUCI CQ, krishna dheeraj Pannala, Blink W3C Test Autoroller, Adam Rice, suresh potti, Nidhi Jaju, AyeAye, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, horo+...@chromium.org, jmedle...@chromium.org, kenjibah...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org

      Julia Sobiech has created a revert of this change

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: revert
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages