Remove generated migration assignment operator for IDL enumerations [chromium/src : main]

0 views
Skip to first unread message

Fredrik Söderquist (Gerrit)

unread,
Sep 23, 2025, 4:33:19 AM (13 days ago) Sep 23
to Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, mattreyno...@chromium.org
Attention needed from Yuki Shiino

Fredrik Söderquist voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Yuki Shiino
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2163642a563f2de4363bf9a7ca22517bdfb3a666
Gerrit-Change-Number: 6973446
Gerrit-PatchSet: 1
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Yuki Shiino <yukis...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Sep 2025 08:32:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yuki Shiino (Gerrit)

unread,
Sep 23, 2025, 5:30:28 AM (13 days ago) Sep 23
to Fredrik Söderquist, Yuki Shiino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, mattreyno...@chromium.org
Attention needed from Fredrik Söderquist

Yuki Shiino voted and added 1 comment

Votes added by Yuki Shiino

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Yuki Shiino . resolved

LGTM. Thank you for completing the migration.

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2163642a563f2de4363bf9a7ca22517bdfb3a666
    Gerrit-Change-Number: 6973446
    Gerrit-PatchSet: 1
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Comment-Date: Tue, 23 Sep 2025 09:29:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 23, 2025, 5:49:44 AM (13 days ago) Sep 23
    to Fredrik Söderquist, Yuki Shiino, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, mattreyno...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove generated migration assignment operator for IDL enumerations

    It only had a single user (Gamepad::SetMapping).
    Bug: 430171134
    Change-Id: I2163642a563f2de4363bf9a7ca22517bdfb3a666
    Auto-Submit: Fredrik Söderquist <f...@opera.com>
    Reviewed-by: Yuki Shiino <yukis...@chromium.org>
    Commit-Queue: Yuki Shiino <yukis...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1519226}
    Files:
    • M third_party/blink/renderer/bindings/scripts/bind_gen/enumeration.py
    • M third_party/blink/renderer/modules/gamepad/gamepad.cc
    Change size: S
    Delta: 2 files changed, 3 insertions(+), 25 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Yuki Shiino
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2163642a563f2de4363bf9a7ca22517bdfb3a666
    Gerrit-Change-Number: 6973446
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Yuki Shiino <yukis...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages