[<login>] Introduce the skeleton of the <login> element [chromium/src : main]

0 views
Skip to first unread message

Christian Biesinger (Gerrit)

unread,
Feb 9, 2026, 7:07:38 PM (2 days ago) Feb 9
to Sam Goto, Christian Biesinger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Sam Goto

Christian Biesinger voted and added 1 comment

Votes added by Christian Biesinger

Code-Review+1

1 comment

Commit Message
Line 10, Patchset 3 (Latest):consolidates its children (currently, only<federation>) under the
Christian Biesinger . unresolved

missing space

Open in Gerrit

Related details

Attention is currently required from:
  • Sam Goto
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I62110a1ac4e1eba0247ee3b5db2a0c3b08eb3dc4
Gerrit-Change-Number: 7558995
Gerrit-PatchSet: 3
Gerrit-Owner: Sam Goto <go...@chromium.org>
Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
Gerrit-Reviewer: Sam Goto <go...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Sam Goto <go...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Feb 2026 00:07:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sam Goto (Gerrit)

unread,
Feb 9, 2026, 7:13:29 PM (2 days ago) Feb 9
to Christian Biesinger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Sam Goto voted and added 1 comment

Votes added by Sam Goto

Commit-Queue+1

1 comment

Commit Message
Line 10, Patchset 3:consolidates its children (currently, only<federation>) under the
Christian Biesinger . resolved

missing space

Sam Goto

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I62110a1ac4e1eba0247ee3b5db2a0c3b08eb3dc4
    Gerrit-Change-Number: 7558995
    Gerrit-PatchSet: 4
    Gerrit-Owner: Sam Goto <go...@chromium.org>
    Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
    Gerrit-Reviewer: Sam Goto <go...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 00:13:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Christian Biesinger <cbies...@chromium.org>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 9, 2026, 8:29:15 PM (2 days ago) Feb 9
    to Sam Goto, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    3 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [<login>] Introduce the skeleton of the <login> element

    This CL introduces just a skeleton of the <login> element and

    consolidates its children (currently, only <federation>) under the
    Bug: 477699742
    Change-Id: I62110a1ac4e1eba0247ee3b5db2a0c3b08eb3dc4
    Commit-Queue: Sam Goto <go...@chromium.org>
    Reviewed-by: Christian Biesinger <cbies...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1582167}
    Files:
    • M third_party/blink/renderer/bindings/generated_in_core.gni
    • M third_party/blink/renderer/bindings/idl_in_core.gni
    • M third_party/blink/renderer/core/html/build.gni
    • M third_party/blink/renderer/core/html/html_federation_element.idl
    • A third_party/blink/renderer/core/html/html_login_element.cc
    • A third_party/blink/renderer/core/html/html_login_element.h
    • A third_party/blink/renderer/core/html/html_login_element.idl
    • A third_party/blink/renderer/core/html/html_login_element_test.cc
    • M third_party/blink/renderer/core/html/html_tag_names.json5
    • M third_party/blink/renderer/platform/runtime_enabled_features.json5
    • M third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
    • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
    Change size: M
    Delta: 12 files changed, 91 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Christian Biesinger
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I62110a1ac4e1eba0247ee3b5db2a0c3b08eb3dc4
    Gerrit-Change-Number: 7558995
    Gerrit-PatchSet: 6
    Gerrit-Owner: Sam Goto <go...@chromium.org>
    Gerrit-Reviewer: Christian Biesinger <cbies...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Sam Goto <go...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages