[FedCM] Add Identity Handler (Service Worker interception) infrastructure [chromium/src : main]

0 views
Skip to first unread message

Dominic Farolino (Gerrit)

unread,
Apr 21, 2026, 2:04:30 PM (6 days ago) Apr 21
to suresh potti, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Hiroki Nakagawa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, yigu+...@chromium.org
Attention needed from suresh potti

Dominic Farolino added 1 comment

File third_party/blink/renderer/modules/credentialmanagement/identity_request_respond_with_observer.cc
Line 166, Patchset 31 (Latest): DummyExceptionStateForTesting exception_state;
Dominic Farolino . unresolved
Open in Gerrit

Related details

Attention is currently required from:
  • suresh potti
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4032f122ad824122fcc3b378e367821b11490d96
Gerrit-Change-Number: 7675225
Gerrit-PatchSet: 31
Gerrit-Owner: suresh potti <sures...@microsoft.com>
Gerrit-Reviewer: suresh potti <sures...@microsoft.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Dominic Farolino <d...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: suresh potti <sures...@microsoft.com>
Gerrit-Comment-Date: Tue, 21 Apr 2026 18:04:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dominic Farolino (Gerrit)

unread,
Apr 21, 2026, 3:47:25 PM (6 days ago) Apr 21
to suresh potti, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Hiroki Nakagawa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, yigu+...@chromium.org
Attention needed from suresh potti

Dominic Farolino added 1 comment

File third_party/blink/renderer/modules/credentialmanagement/identity_request_endpoint.idl
Line 7, Patchset 31 (Latest):enum IdentityRequestEndpoint { "accounts", "id_assertion", "disconnect" };
Dominic Farolino . unresolved

Note we'll want to rename `id_assertion` to `id-assertion` like the PR.

Gerrit-Comment-Date: Tue, 21 Apr 2026 19:47:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages