[FedCM] Add Identity Handler (Service Worker interception) infrastructure [chromium/src : main]

0 views

Skip to first unread message

Dominic Farolino (Gerrit)

unread,

Apr 21, 2026, 2:04:30 PM (6 days ago) Apr 21

to suresh potti, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Hiroki Nakagawa, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, yigu+...@chromium.org

Attention needed from suresh potti

Dominic Farolino added 1 comment

File third_party/blink/renderer/modules/credentialmanagement/identity_request_respond_with_observer.cc

Line 166, Patchset 31 (Latest): DummyExceptionStateForTesting exception_state;

Dominic Farolino . unresolved

We definitely can't use this here—what's the plan to replace this? Should we use something like https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/platform/bindings/exception_state.h;l=270;drc=6feeccc93dd4bcea783aeed1534a126b9d18ca63?

Open in Gerrit

Related details

Attention is currently required from:

suresh potti

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Farolino (Gerrit)

unread,

Apr 21, 2026, 3:47:25 PM (6 days ago) Apr 21

Attention needed from suresh potti

Dominic Farolino added 1 comment

File third_party/blink/renderer/modules/credentialmanagement/identity_request_endpoint.idl

Line 7, Patchset 31 (Latest):enum IdentityRequestEndpoint { "accounts", "id_assertion", "disconnect" };

Dominic Farolino . unresolved

Note we'll want to rename `id_assertion` to `id-assertion` like the PR.

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages