Implement iterationComposite for CSS animations [chromium/src : main]

75 views
Skip to first unread message

Felipe Erias (Gerrit)

unread,
Oct 24, 2025, 3:28:15 AM (9 days ago) Oct 24
to Robert Flack, Kevin Ellis, Alan Cutter, Stephen McGruer, David Awogbemila, Chromium Metrics Reviews, chromium...@chromium.org, Chromium LUCI CQ, Alexis Menard, Kentaro Hara, Raphael Kubo da Costa, Olga Gerchikov, AyeAye, asvitkine...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Alan Cutter, David Awogbemila, Kevin Ellis, Robert Flack and Stephen McGruer

Felipe Erias added 1 comment

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Felipe Erias . resolved

Hello,

This CL is an initial implementation of the iterationComposite property from Web Animations Level 2, which controls how animation values accumulate across multiple iterations.

https://drafts.csswg.org/web-animations-2/#iteration-composite-operation

I hope that the CL description provides a good starting point, but please don't hesitate to ask me to clarify any point. I have already updated the existing WPT and unit tests, and I am currently working to add additional unit tests for this feature.

Thank you for your review.

Best regards,
Felipe


https://issues.chromium.org/issues/41133485

https://chromestatus.com/feature/5198590821662720

Open in Gerrit

Related details

Attention is currently required from:
  • Alan Cutter
  • David Awogbemila
  • Kevin Ellis
  • Robert Flack
  • Stephen McGruer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I65ccf6fd646243012ca64b5c8207246a215d1d7b
Gerrit-Change-Number: 7047878
Gerrit-PatchSet: 11
Gerrit-Owner: Felipe Erias <felip...@igalia.com>
Gerrit-Reviewer: Alan Cutter <alanc...@google.com>
Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-Reviewer: Stephen McGruer <smcg...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Kevin Ellis <kev...@chromium.org>
Gerrit-Attention: David Awogbemila <awogb...@chromium.org>
Gerrit-Attention: Stephen McGruer <smcg...@chromium.org>
Gerrit-Attention: Robert Flack <fla...@chromium.org>
Gerrit-Attention: Alan Cutter <alanc...@google.com>
Gerrit-Comment-Date: Fri, 24 Oct 2025 07:27:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alan Cutter (Gerrit)

unread,
Oct 28, 2025, 12:50:56 AM (5 days ago) Oct 28
to Felipe Erias, Robert Flack, Kevin Ellis, David Awogbemila, Chromium Metrics Reviews, chromium...@chromium.org, Chromium LUCI CQ, Alexis Menard, Kentaro Hara, Raphael Kubo da Costa, Olga Gerchikov, AyeAye, asvitkine...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from David Awogbemila, Felipe Erias, Kevin Ellis and Robert Flack

Alan Cutter added 1 comment

File third_party/blink/renderer/core/animation/invalidatable_interpolation.cc
Line 259, Patchset 11 (Latest):bool InvalidatableInterpolation::ApplyIterationAccumulation() const {
Alan Cutter . unresolved

Should we be using this return value?

Open in Gerrit

Related details

Attention is currently required from:
  • David Awogbemila
  • Felipe Erias
  • Kevin Ellis
  • Robert Flack
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I65ccf6fd646243012ca64b5c8207246a215d1d7b
    Gerrit-Change-Number: 7047878
    Gerrit-PatchSet: 11
    Gerrit-Owner: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Alan Cutter <alanc...@google.com>
    Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Kevin Ellis <kev...@chromium.org>
    Gerrit-Attention: David Awogbemila <awogb...@chromium.org>
    Gerrit-Attention: Felipe Erias <felip...@igalia.com>
    Gerrit-Attention: Robert Flack <fla...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Oct 2025 04:50:21 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alan Cutter (Gerrit)

    unread,
    Oct 28, 2025, 12:55:10 AM (5 days ago) Oct 28
    to Felipe Erias, Robert Flack, Kevin Ellis, David Awogbemila, Chromium Metrics Reviews, chromium...@chromium.org, Chromium LUCI CQ, Alexis Menard, Kentaro Hara, Raphael Kubo da Costa, Olga Gerchikov, AyeAye, asvitkine...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from David Awogbemila, Felipe Erias, Kevin Ellis and Robert Flack

    Alan Cutter added 2 comments

    Patchset-level comments
    Alan Cutter . resolved

    I don't count myself as an owner of this code anymore but this looks pretty good to me!

    File third_party/blink/web_tests/external/wpt/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt
    Line 3, Patchset 11 (Latest): assert_equals: Animated filter list at 50s of the third iteration expected "contrast(4) brightness(4)" but got "contrast(2) brightness(2)"
    Alan Cutter . unresolved

    What's going wrong for this test?

    Gerrit-Comment-Date: Tue, 28 Oct 2025 04:54:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Felipe Erias (Gerrit)

    unread,
    Oct 29, 2025, 8:42:59 AM (4 days ago) Oct 29
    to Kevin Ellis, Alan Cutter, David Awogbemila, Chromium Metrics Reviews, chromium...@chromium.org, Chromium LUCI CQ, Menard, Alexis, Kentaro Hara, Raphael Kubo da Costa, Olga Gerchikov, AyeAye, asvitkine...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, kinuko...@chromium.org, blink-revie...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Alan Cutter, David Awogbemila and Kevin Ellis

    Felipe Erias added 1 comment

    File third_party/blink/renderer/core/animation/invalidatable_interpolation.cc
    Line 259, Patchset 11:bool InvalidatableInterpolation::ApplyIterationAccumulation() const {
    Alan Cutter . resolved

    Should we be using this return value?

    Felipe Erias

    Thank you for your review.

    Good point. That return value is unused and not particularly informative (it would be false in most cases, for different reasons) so I have removed it:

    `void InvalidatableInterpolation::ApplyIterationAccumulation() const`

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alan Cutter
    • David Awogbemila
    • Kevin Ellis
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I65ccf6fd646243012ca64b5c8207246a215d1d7b
    Gerrit-Change-Number: 7047878
    Gerrit-PatchSet: 12
    Gerrit-Owner: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Alan Cutter <alanc...@google.com>
    Gerrit-Reviewer: David Awogbemila <awogb...@chromium.org>
    Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Kevin Ellis <kev...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Kevin Ellis <kev...@chromium.org>
    Gerrit-Attention: David Awogbemila <awogb...@chromium.org>
    Gerrit-Attention: Alan Cutter <alanc...@google.com>
    Gerrit-Comment-Date: Wed, 29 Oct 2025 12:42:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Alan Cutter <alanc...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages