Rename <federation> element to <credential> [chromium/src : main]
0 views
Skip to first unread message
Christian Biesinger (Gerrit)
Feb 9, 2026, 3:13:18 PM (2 days ago) Feb 9
to Sam Goto, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Sam Goto
Christian Biesinger voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Sam Goto
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Goto (Gerrit)
Feb 9, 2026, 7:23:55 PM (2 days ago) Feb 9
to Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Sam Goto voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Biesinger (Gerrit)
Feb 10, 2026, 12:01:35 PM (22 hours ago) Feb 10
to Sam Goto, Christian Biesinger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Sam Goto
Christian Biesinger voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Sam Goto
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Goto (Gerrit)
Feb 10, 2026, 12:20:46 PM (22 hours ago) Feb 10
to Christian Biesinger, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Sam Goto voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 10, 2026, 12:25:38 PM (22 hours ago) Feb 10
to Sam Goto, Christian Biesinger, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[<login>] Rename <federation> element to <credential>
Explainer:
https://github.com/fedidcg/declarative-login
Intent To Prototype:
https://groups.google.com/a/chromium.org/g/blink-dev/c/uXmdPPN2NUI/m/DpbG_eKBCQAJ
Bug: 477699742
Change-Id: I2e4d37674679dc65227709f0d9cc2f792e1b3250
Reviewed-by: Christian Biesinger <cbies...@chromium.org>
Commit-Queue: Sam Goto <go...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1582591}
Files:
- M third_party/blink/renderer/bindings/generated_in_core.gni
- M third_party/blink/renderer/bindings/idl_in_core.gni
- M third_party/blink/renderer/core/html/build.gni
- A third_party/blink/renderer/core/html/html_credential_element.cc
- A third_party/blink/renderer/core/html/html_credential_element.h
- R third_party/blink/renderer/core/html/html_credential_element.idl
- A third_party/blink/renderer/core/html/html_credential_element_test.cc
- D third_party/blink/renderer/core/html/html_federation_element.cc
- D third_party/blink/renderer/core/html/html_federation_element.h
- M third_party/blink/renderer/core/html/html_tag_names.json5
- M third_party/blink/renderer/core/sanitizer/builtins_generate_config.py
- M third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
- M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
Change size: M
Delta: 13 files changed, 76 insertions(+), 53 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Christian Biesinger
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages