Adds the WebTransportReceiveStream interface surface from the W3C WebTransport spec section 9: [chromium/src : main]
71 views
Skip to first unread message
Himanshu Panwar (Gerrit)
May 7, 2026, 1:38:03 PM (12 days ago) May 7
to Adam Rice, Daniel Cheng, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, kenjibah...@chromium.org, servicewor...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, shimazu+se...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Adam Rice and Daniel Cheng
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Adam Rice
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
May 8, 2026, 10:45:07 AM (11 days ago) May 8
to Himanshu Panwar, Daniel Cheng, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, kenjibah...@chromium.org, servicewor...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, shimazu+se...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Himanshu Panwar
Adam Rice added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/webtransport/web_transport_receive_stream.cc
Line 22, Patchset 15 (Latest):
void ForgetStream(WebTransport* transport,Adam Rice . unresolved
I think this will still be called if the WebTransport has been garbage collected, in which case `transport` will be nullptr, so you should return early in that case. It would be good to have a unit test for this case, but unfortunately writing tests for garbage collection is quite difficult.
Related details
Attention is currently required from:
- Himanshu Panwar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Himanshu Panwar (Gerrit)
May 12, 2026, 4:08:27 PM (7 days ago) May 12
to Adam Rice, Daniel Cheng, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, kenjibah...@chromium.org, servicewor...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, shimazu+se...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Adam Rice
Himanshu Panwar added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/webtransport/web_transport_receive_stream.cc
I think this will still be called if the WebTransport has been garbage collected, in which case `transport` will be nullptr, so you should return early in that case. It would be good to have a unit test for this case, but unfortunately writing tests for garbage collection is quite difficult.
Himanshu Panwar
Aadded the if (!transport) return; guard in this CL.
For the unit test,As you menitoned GC tests are tricky here. I have one working locally that exercises the exact path: construct WebTransportReceiveStream directly (bypassing the accept flow so it's not in incoming_stream_map_),break the mojo connection, GC, then trigger AbortAndReset to fire on_abort_ with a now-null transport. Verified it works as expected by removing the guard, passes with the guard restored.Since the test depends on the wire-up Cl, I would prefer to land it in next CL2 if thats okay with you.
Related details
Attention is currently required from:
- Adam Rice
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nidhi Jaju (Gerrit)
May 15, 2026, 1:02:58 AM (4 days ago) May 15
to Himanshu Panwar, Adam Rice, Daniel Cheng, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, kenjibah...@chromium.org, servicewor...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, shimazu+se...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Adam Rice and Himanshu Panwar
Nidhi Jaju voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Adam Rice
- Himanshu Panwar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
May 15, 2026, 1:38:11 AM (4 days ago) May 15
to Himanshu Panwar, Daniel Cheng, Nidhi Jaju, Adam Rice, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, kenjibah...@chromium.org, servicewor...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, shimazu+se...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Adam Rice and Himanshu Panwar
Daniel Cheng voted and added 2 comments![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Code-Review | +1 |
2 comments
Patchset-level comments
Daniel Cheng . resolved
LGTM
File third_party/blink/renderer/modules/webtransport/web_transport_receive_stream.h
Line 66, Patchset 16 (Latest):
WebTransportReceiveStream::GetStaticWrapperTypeInfo();Daniel Cheng . resolved
This is clever I guess... but also kind of mixed feelings about this.
Related details
Attention is currently required from:
- Adam Rice
- Himanshu Panwar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Himanshu Panwar (Gerrit)
May 15, 2026, 1:47:00 AM (4 days ago) May 15
to Daniel Cheng, Nidhi Jaju, Adam Rice, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, kenjibah...@chromium.org, servicewor...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, shimazu+se...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Adam Rice
Himanshu Panwar voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Adam Rice
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 15, 2026, 3:35:01 AM (4 days ago) May 15
to Himanshu Panwar, Daniel Cheng, Nidhi Jaju, Adam Rice, Hiroki Nakagawa, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-bu...@system.gserviceaccount.com, kenjibah...@chromium.org, servicewor...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, horo+...@chromium.org, kinuko+ser...@chromium.org, shimazu+se...@chromium.org, jmedle...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Adds the WebTransportReceiveStream interface surface from the W3C WebTransport spec section 9:
https://w3c.github.io/webtransport/#webtransportreceivestream
WebTransportReceiveStream is a ReadableStream subclass with a getStats()method returning WebTransportReceiveStreamStats. The interface is gated behind the new experimental WebTransportReceiveStream runtime flag.
This CL only adds the class, IDL, runtime flag, bindings/build
registration, and test expectations. It intentionally does not construct WebTransportReceiveStream objects yet. The follow-up CL, wires ReceiveStreamVendor and BidirectionalStream to construct WebTransportReceiveStream when the flag is enabled.
getStats() returns zeroed stats for now, matching the current
WebTransportSendStream stub pattern. Real Mojo-backed receive-stream stats are tracked separately. [Transferable] is also deferred until stream subclass transfer support exists.
Change-Id: Iba4250b8a797ae692b171687cdeec1b59b18ce34
Bug: 510589920
Reviewed-by: Nidhi Jaju <nidh...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Himanshu Panwar <himp...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1631131}
Files:
- M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
- M third_party/blink/renderer/bindings/generated_in_modules.gni
- M third_party/blink/renderer/bindings/idl_in_modules.gni
- M third_party/blink/renderer/modules/webtransport/BUILD.gn
- A third_party/blink/renderer/modules/webtransport/web_transport_receive_stream.cc
- A third_party/blink/renderer/modules/webtransport/web_transport_receive_stream.h
- A third_party/blink/renderer/modules/webtransport/web_transport_receive_stream.idl
- A third_party/blink/renderer/modules/webtransport/web_transport_receive_stream_stats.idl
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M third_party/blink/web_tests/external/wpt/webtransport/idlharness.https.sub.any-expected.txt
- M third_party/blink/web_tests/external/wpt/webtransport/idlharness.https.sub.any.serviceworker-expected.txt
- M third_party/blink/web_tests/external/wpt/webtransport/idlharness.https.sub.any.sharedworker-expected.txt
- M third_party/blink/web_tests/external/wpt/webtransport/idlharness.https.sub.any.worker-expected.txt
- M third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
- M third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
- M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
- M third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt
Change size: L
Delta: 17 files changed, 211 insertions(+), 60 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng, +1 by Nidhi Jaju
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages