Wrap mixin contents in @result. [chromium/src : main]

38 views
Skip to first unread message

Steinar H Gunderson (Gerrit)

unread,
Feb 9, 2026, 9:28:11 AM (2 days ago) Feb 9
to Anders Hartvoll Ruud, Raphael Kubo da Costa, chromium...@chromium.org, Menard, Alexis, Kentaro Hara, blink-re...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Anders Hartvoll Ruud

Steinar H Gunderson has uploaded the change for review

Steinar H Gunderson would like Anders Hartvoll Ruud to review this change.

Commit message

Wrap mixin contents in @result.

This is the first step towards supporting locals in mixins.
We don't yet support @result within conditionals (though conditionals
within @result keeps being supported).
Bug: 460744905
Change-Id: Iffba644917fe0b84a82cca5efb88cd4f0c728f6a

Change diff


Change information

Files:
  • M third_party/blink/renderer/bindings/generated_in_core.gni
  • M third_party/blink/renderer/bindings/idl_in_core.gni
  • M third_party/blink/renderer/core/css/build.gni
  • M third_party/blink/renderer/core/css/css_grouping_rule.h
  • A third_party/blink/renderer/core/css/css_result_rule.cc
  • A third_party/blink/renderer/core/css/css_result_rule.h
  • A third_party/blink/renderer/core/css/css_result_rule.idl
  • M third_party/blink/renderer/core/css/css_rule.h
  • M third_party/blink/renderer/core/css/parser/at_rule_descriptor_parser.cc
  • M third_party/blink/renderer/core/css/parser/css_at_rule_id.cc
  • M third_party/blink/renderer/core/css/parser/css_at_rule_id.h
  • M third_party/blink/renderer/core/css/parser/css_parser_impl.cc
  • M third_party/blink/renderer/core/css/parser/css_parser_impl.h
  • M third_party/blink/renderer/core/css/rule_set.cc
  • M third_party/blink/renderer/core/css/style_rule.cc
  • M third_party/blink/renderer/core/css/style_rule.h
  • M third_party/blink/renderer/core/css/style_sheet_contents.cc
  • M third_party/blink/renderer/core/frame/frame_serializer.cc
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/apply-nested-declarations.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/apply-top-level.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/apply-within-mixin.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/contents-nested-declarations-fallback.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/contents-nested-declarations.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/contents-rule.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-basic.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-cross-stylesheet.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-cssom.tentative.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-cycle.tentative.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-declarations.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-invalidation.tentative.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-layers.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-media-query-invalidation-2.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-media-query-invalidation.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-parameters.tentative.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-parsing.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-shadow-dom.html
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/resources/imported-sheet-with-mixin.css
  • M third_party/blink/web_tests/external/wpt/css/css-mixins/resources/imported-sheet-with-red-mixin.css
Change size: L
Delta: 38 files changed, 472 insertions(+), 119 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iffba644917fe0b84a82cca5efb88cd4f0c728f6a
Gerrit-Change-Number: 7557419
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Anders Hartvoll Ruud (Gerrit)

unread,
Feb 10, 2026, 3:53:02 AM (yesterday) Feb 10
to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org
Attention needed from Steinar H Gunderson

Anders Hartvoll Ruud voted and added 1 comment

Votes added by Anders Hartvoll Ruud

Code-Review+1

1 comment

File third_party/blink/renderer/core/css/css_result_rule.cc
Line 1, Patchset 1 (Latest):// Copyright 2025 The Chromium Authors
Anders Hartvoll Ruud . unresolved

nit!

Open in Gerrit

Related details

Attention is currently required from:
  • Steinar H Gunderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iffba644917fe0b84a82cca5efb88cd4f0c728f6a
Gerrit-Change-Number: 7557419
Gerrit-PatchSet: 1
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Feb 2026 08:52:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Steinar H Gunderson (Gerrit)

unread,
Feb 10, 2026, 5:05:08 AM (yesterday) Feb 10
to Anders Hartvoll Ruud, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, devtools-re...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org
Attention needed from Anders Hartvoll Ruud

Steinar H Gunderson voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iffba644917fe0b84a82cca5efb88cd4f0c728f6a
Gerrit-Change-Number: 7557419
Gerrit-PatchSet: 2
Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Feb 2026 10:04:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Steinar H Gunderson (Gerrit)

unread,
Feb 10, 2026, 5:12:25 AM (yesterday) Feb 10
to Chromium LUCI CQ, Anders Hartvoll Ruud, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, devtools-re...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org
Attention needed from Anders Hartvoll Ruud and Steinar H Gunderson

Steinar H Gunderson voted and added 1 comment

Votes added by Steinar H Gunderson

Commit-Queue+1

1 comment

File third_party/blink/renderer/core/css/css_result_rule.cc
Line 1, Patchset 1:// Copyright 2025 The Chromium Authors
Anders Hartvoll Ruud . resolved

nit!

Steinar H Gunderson

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
  • Steinar H Gunderson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iffba644917fe0b84a82cca5efb88cd4f0c728f6a
    Gerrit-Change-Number: 7557419
    Gerrit-PatchSet: 2
    Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 10:12:13 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Anders Hartvoll Ruud <and...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Steinar H Gunderson (Gerrit)

    unread,
    Feb 10, 2026, 5:12:37 AM (yesterday) Feb 10
    to Chromium LUCI CQ, Anders Hartvoll Ruud, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, devtools-re...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org
    Attention needed from Anders Hartvoll Ruud

    Steinar H Gunderson voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Anders Hartvoll Ruud
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iffba644917fe0b84a82cca5efb88cd4f0c728f6a
    Gerrit-Change-Number: 7557419
    Gerrit-PatchSet: 3
    Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 10:12:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Steinar H Gunderson (Gerrit)

    unread,
    Feb 10, 2026, 6:01:26 AM (yesterday) Feb 10
    to Chromium LUCI CQ, Anders Hartvoll Ruud, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, devtools-re...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org
    Attention needed from Anders Hartvoll Ruud

    Steinar H Gunderson voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Anders Hartvoll Ruud
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iffba644917fe0b84a82cca5efb88cd4f0c728f6a
    Gerrit-Change-Number: 7557419
    Gerrit-PatchSet: 4
    Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 11:01:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Anders Hartvoll Ruud (Gerrit)

    unread,
    Feb 10, 2026, 11:25:49 AM (23 hours ago) Feb 10
    to Steinar H Gunderson, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, devtools-re...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org
    Attention needed from Steinar H Gunderson

    Anders Hartvoll Ruud added 2 comments

    File third_party/blink/renderer/core/css/parser/css_parser_impl.cc
    Line 1313, Patchset 4 (Latest): if (rule_type == StyleRule::kMixin) {
    // We do not accept declarations directly in @mixin; they need to be wrapped
    // in @result.
    Anders Hartvoll Ruud . unresolved

    Yes, we do. They should be wrapped in some bespoke nested declarations rule, see `StyleRuleFunctionDeclarations` on line 1294.

    Line 3081, Patchset 4 (Latest): if (rule_type != StyleRule::kMixin) {
    Anders Hartvoll Ruud . unresolved

    This doesn't seem right either.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Steinar H Gunderson
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iffba644917fe0b84a82cca5efb88cd4f0c728f6a
      Gerrit-Change-Number: 7557419
      Gerrit-PatchSet: 4
      Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
      Gerrit-Comment-Date: Tue, 10 Feb 2026 16:25:36 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Steinar H Gunderson (Gerrit)

      unread,
      Feb 10, 2026, 12:17:44 PM (22 hours ago) Feb 10
      to Chromium LUCI CQ, Anders Hartvoll Ruud, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, devtools-re...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org
      Attention needed from Anders Hartvoll Ruud

      Steinar H Gunderson added 1 comment

      File third_party/blink/renderer/core/css/parser/css_parser_impl.cc
      Line 1313, Patchset 4 (Latest): if (rule_type == StyleRule::kMixin) {
      // We do not accept declarations directly in @mixin; they need to be wrapped
      // in @result.
      Anders Hartvoll Ruud . unresolved

      Yes, we do. They should be wrapped in some bespoke nested declarations rule, see `StyleRuleFunctionDeclarations` on line 1294.

      Steinar H Gunderson

      For the time being, allowing this will crash. This restriction is loosened again in the next CL.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Anders Hartvoll Ruud
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iffba644917fe0b84a82cca5efb88cd4f0c728f6a
      Gerrit-Change-Number: 7557419
      Gerrit-PatchSet: 4
      Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Comment-Date: Tue, 10 Feb 2026 17:17:31 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Anders Hartvoll Ruud (Gerrit)

      unread,
      8:46 AM (2 hours ago) 8:46 AM
      to Steinar H Gunderson, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, devtools-re...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org
      Attention needed from Steinar H Gunderson

      Anders Hartvoll Ruud voted and added 2 comments

      Votes added by Anders Hartvoll Ruud

      Code-Review+1

      2 comments

      File third_party/blink/renderer/core/css/parser/css_parser_impl.cc
      Line 1313, Patchset 4 (Latest): if (rule_type == StyleRule::kMixin) {
      // We do not accept declarations directly in @mixin; they need to be wrapped
      // in @result.
      Anders Hartvoll Ruud . resolved

      Yes, we do. They should be wrapped in some bespoke nested declarations rule, see `StyleRuleFunctionDeclarations` on line 1294.

      Steinar H Gunderson

      For the time being, allowing this will crash. This restriction is loosened again in the next CL.

      Anders Hartvoll Ruud

      Acknowledged

      Line 3081, Patchset 4 (Latest): if (rule_type != StyleRule::kMixin) {
      Anders Hartvoll Ruud . resolved

      This doesn't seem right either.

      Anders Hartvoll Ruud

      Closing, see other issue.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Steinar H Gunderson
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iffba644917fe0b84a82cca5efb88cd4f0c728f6a
      Gerrit-Change-Number: 7557419
      Gerrit-PatchSet: 4
      Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Steinar H Gunderson <se...@chromium.org>
      Gerrit-Comment-Date: Wed, 11 Feb 2026 13:46:34 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Anders Hartvoll Ruud <and...@chromium.org>
      Comment-In-Reply-To: Steinar H Gunderson <se...@chromium.org>
      satisfied_requirement
      open
      diffy

      Steinar H Gunderson (Gerrit)

      unread,
      9:06 AM (1 hour ago) 9:06 AM
      to Anders Hartvoll Ruud, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, devtools-re...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org

      Steinar H Gunderson voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iffba644917fe0b84a82cca5efb88cd4f0c728f6a
      Gerrit-Change-Number: 7557419
      Gerrit-PatchSet: 4
      Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Menard, Alexis <alexis...@intel.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Comment-Date: Wed, 11 Feb 2026 14:06:45 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      10:02 AM (22 minutes ago) 10:02 AM
      to Steinar H Gunderson, Anders Hartvoll Ruud, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, android-web...@chromium.org, ashleynewson+w...@chromium.org, devtools-re...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Wrap mixin contents in @result.

      This is the first step towards supporting locals in mixins.
      We don't yet support @result within conditionals (though conditionals
      within @result keeps being supported).
      Bug: 460744905
      Change-Id: Iffba644917fe0b84a82cca5efb88cd4f0c728f6a
      Commit-Queue: Steinar H Gunderson <se...@chromium.org>
      Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1583205}
      Files:
      • M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
      • M third_party/blink/renderer/bindings/generated_in_core.gni
      • M third_party/blink/renderer/bindings/idl_in_core.gni
      • M third_party/blink/renderer/core/css/build.gni
      • M third_party/blink/renderer/core/css/css_grouping_rule.h
      • A third_party/blink/renderer/core/css/css_result_rule.cc
      • A third_party/blink/renderer/core/css/css_result_rule.h
      • A third_party/blink/renderer/core/css/css_result_rule.idl
      • M third_party/blink/renderer/core/css/css_rule.h
      • M third_party/blink/renderer/core/css/parser/at_rule_descriptor_parser.cc
      • M third_party/blink/renderer/core/css/parser/css_at_rule_id.cc
      • M third_party/blink/renderer/core/css/parser/css_at_rule_id.h
      • M third_party/blink/renderer/core/css/parser/css_parser_impl.cc
      • M third_party/blink/renderer/core/css/parser/css_parser_impl.h
      • M third_party/blink/renderer/core/css/rule_set.cc
      • M third_party/blink/renderer/core/css/style_rule.cc
      • M third_party/blink/renderer/core/css/style_rule.h
      • M third_party/blink/renderer/core/css/style_sheet_contents.cc
      • M third_party/blink/renderer/core/frame/frame_serializer.cc
      • M third_party/blink/renderer/core/inspector/inspector_css_parser_observer_test.cc
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/apply-nested-declarations.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/apply-top-level.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/apply-within-mixin.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/contents-nested-declarations-fallback.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/contents-nested-declarations.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/contents-rule.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-basic.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-cross-stylesheet.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-cssom.tentative.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-cycle.tentative.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-declarations.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-invalidation.tentative.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-layers.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-media-query-invalidation-2.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-media-query-invalidation.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-parameters.tentative.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-parsing.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/mixin-shadow-dom.html
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/resources/imported-sheet-with-mixin.css
      • M third_party/blink/web_tests/external/wpt/css/css-mixins/resources/imported-sheet-with-red-mixin.css
      • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
      Change size: L
      Delta: 41 files changed, 488 insertions(+), 120 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Anders Hartvoll Ruud
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iffba644917fe0b84a82cca5efb88cd4f0c728f6a
      Gerrit-Change-Number: 7557419
      Gerrit-PatchSet: 5
      Gerrit-Owner: Steinar H Gunderson <se...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Steinar H Gunderson <se...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages