Remove Attribution Reporting API code in the Blink renderer [chromium/src : main]
Nan Lin (Gerrit)
Nan Lin added 1 comment![]( "Open in Gerrit")
Related details
- Andrew Paseltiner
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Paseltiner (Gerrit)
Andrew Paseltiner added 1 comment![]( "Open in Gerrit")
- HTML attributes (`attributionsrc`), `window.open` features, and `fetch()` parameters (`attributionReporting`) will be ignored silently.To clarify, we're intentionally keeping [`HTMLAttributionSrcElementUtils`](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/html_attributionsrc_element_utils.idl;drc=d6ce47b18166dbf01895ad5278fdff11c79b3ee2) and the code that includes it?
Related details
- Nan Lin
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nan Lin (Gerrit)
Nan Lin added 1 comment![]( "Open in Gerrit")
- HTML attributes (`attributionsrc`), `window.open` features, and `fetch()` parameters (`attributionReporting`) will be ignored silently.To clarify, we're intentionally keeping [`HTMLAttributionSrcElementUtils`](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/html_attributionsrc_element_utils.idl;drc=d6ce47b18166dbf01895ad5278fdff11c79b3ee2) and the code that includes it?
Yes, that's intentional and is to avoid breaking JS code that accesses the attributionsrc attribution (e.g. element.attributionsrc.length). Updated the cl description. Thanks.
Related details
- Andrew Paseltiner
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Paseltiner (Gerrit)
Andrew Paseltiner voted Code-Review+1![]( "Open in Gerrit")
- Nan Lin
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nan Lin (Gerrit)
Nan Lin added 1 comment![]( "Open in Gerrit")
- Nate Chapin
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Chapin (Gerrit)
Nate Chapin voted and added 5 comments![]( "Open in Gerrit")
Votes added by Nate Chapin
| Code-Review | +1 |
5 comments
LGTM % a few questions about when additional things are getting deleted.
Nit: I think this needs another `git cl format` run - there are unnecessary newlines in a several files.
DO NOT SUBMIT until M152.Please include a link to the chromestatus or blink-dev thread for this deprecation, for thoroughness 😊
frame_request.SetImpression(impression);I think we can remove `FrameLoadRequest::impression_` ... or will that be in a followup?
request.SetAttributionReportingSupport(When will fields on `ResourceRequest` be removed?
[RuntimeEnabled=AttributionReporting, SecureContext, MeasureAs=AttributionReportingXhr, DeprecateAs=AttributionReportingAPIAll] void setAttributionReporting(any options);When will this be removed?
Related details
- Nan Lin
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nan Lin (Gerrit)
Nan Lin added 6 comments![]( "Open in Gerrit")
LGTM % a few questions about when additional things are getting deleted.
Nit: I think this needs another `git cl format` run - there are unnecessary newlines in a several files.
Done
Please include a link to the chromestatus or blink-dev thread for this deprecation, for thoroughness 😊
Done
frame_request.SetImpression(impression);I think we can remove `FrameLoadRequest::impression_` ... or will that be in a followup?
This will be in a follow up. Thanks.
request.SetAttributionReportingSupport(When will fields on `ResourceRequest` be removed?
This will be in a follow up. Thanks.
[RuntimeEnabled=AttributionReporting, SecureContext, MeasureAs=AttributionReportingXhr, DeprecateAs=AttributionReportingAPIAll] void setAttributionReporting(any options);When will this be removed?
Heres's the plan mentioned in the blink-dev thread: https://groups.google.com/a/chromium.org/g/blink-dev/c/4K2RRt6VYCQ/m/otZSnBaGBAAJ
1. M150: Remove all Ads API-related entries from Chrome settings and UI surfaces (e.g., chrome://settings/adPrivacy) via field trial. After this point, all API invocations for field-trial enabled browsers will always reject. Since the API can already be disabled for one of many reasons, scripts must already handle such rejections (or they’re already significantly broken).
2. M152: Permanently remove the underlying implementation code for the API, and replace it with a lightweight stub API. The stub will remain removable via field trial.
3. M152 Canary/Beta: Begin a controlled rollout of the stub API removal via a field trial.
4. M152 Stable: Assuming there are no regressions or breakage after reaching 1% stable, we will request additional approval for full removal at this stage.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |