[M144-LTS] [bindings] Perform detach check when passing span instead of retaining underlying array buffer [chromium/src : refs/branch-heads/7559]

1 view
Skip to first unread message

Tiago Vignatti (xWF) (Gerrit)

unread,
May 7, 2026, 9:43:56 AM (12 days ago) May 7
to Andrey Kosyakov, Victor Gabriel Savu, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, jshin...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Andrey Kosyakov and Victor Gabriel Savu

Tiago Vignatti (xWF) added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Tiago Vignatti (xWF) . resolved

The bug was approved for M144 LTS. PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Victor Gabriel Savu
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7559
Gerrit-Change-Id: I3fd8c25f19b839ed64099b1f54e7770af345a589
Gerrit-Change-Number: 7755304
Gerrit-PatchSet: 4
Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Victor Gabriel Savu <vs...@google.com>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Comment-Date: Thu, 07 May 2026 13:43:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Victor Gabriel Savu (Gerrit)

unread,
May 7, 2026, 9:54:02 AM (12 days ago) May 7
to Tiago Vignatti (xWF), Andrey Kosyakov, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, jshin...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Andrey Kosyakov and Victor Gabriel Savu

Victor Gabriel Savu added 2 comments

Commit Message
Line 18, Patchset 4 (Latest):(cherry picked from commit 0e84e9b32b74e72de294c58fa03042cb6cffc715)
Victor Gabriel Savu . unresolved

Something is wrong, Gerrit does not see this as a cherry-pick. Maybe swapping this and the next line might help.

Ideally create the merge first with the UI (including conflicts) and then rebase; it's easier to reveiw.

File third_party/blink/web_tests/external/wpt/encoding/textdecoder-arguments.any.js
File-level comment, Patchset 4 (Parent):
Victor Gabriel Savu . unresolved

Why are you making changes to this file when it's not present in the original CL?

Mention it in the CL description

Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
  • Victor Gabriel Savu
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedLint
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7559
    Gerrit-Change-Id: I3fd8c25f19b839ed64099b1f54e7770af345a589
    Gerrit-Change-Number: 7755304
    Gerrit-PatchSet: 4
    Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
    Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
    Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Victor Gabriel Savu <vs...@google.com>
    Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-Comment-Date: Thu, 07 May 2026 13:53:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Tiago Vignatti (xWF) (Gerrit)

    unread,
    May 7, 2026, 2:57:56 PM (12 days ago) May 7
    to Andrey Kosyakov, Victor Gabriel Savu, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, jshin...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Andrey Kosyakov and Victor Gabriel Savu

    Tiago Vignatti (xWF) added 3 comments

    Tiago Vignatti (xWF) . resolved

    PTAL.

    Commit Message
    Line 18, Patchset 4:(cherry picked from commit 0e84e9b32b74e72de294c58fa03042cb6cffc715)
    Victor Gabriel Savu . resolved

    Something is wrong, Gerrit does not see this as a cherry-pick. Maybe swapping this and the next line might help.

    Ideally create the merge first with the UI (including conflicts) and then rebase; it's easier to reveiw.

    Tiago Vignatti (xWF)

    Thank you, Victor. The current CL was part of a chain and AFAIK there's no way to use UI to cherry-pick CLs with dependencies on other CLs. So specifically for this I've used the [manual process](https://chromium.googlesource.com/chromium/src.git/+/refs/heads/main/docs/process/merge_request.md#using-git-manual).

    Thanks for the suggestion on swapping the lines; it's done now.

    File third_party/blink/web_tests/external/wpt/encoding/textdecoder-arguments.any.js
    Victor Gabriel Savu . resolved

    Why are you making changes to this file when it's not present in the original CL?

    Mention it in the CL description

    Tiago Vignatti (xWF)

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrey Kosyakov
    • Victor Gabriel Savu
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedLint
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7559
      Gerrit-Change-Id: I3fd8c25f19b839ed64099b1f54e7770af345a589
      Gerrit-Change-Number: 7755304
      Gerrit-PatchSet: 6
      Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
      Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
      Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
      Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Victor Gabriel Savu <vs...@google.com>
      Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
      Gerrit-Comment-Date: Thu, 07 May 2026 18:57:49 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Victor Gabriel Savu <vs...@google.com>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Victor Gabriel Savu (Gerrit)

      unread,
      May 8, 2026, 3:48:22 AM (11 days ago) May 8
      to Tiago Vignatti (xWF), Andrey Kosyakov, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, jshin...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Andrey Kosyakov and Tiago Vignatti (xWF)

      Victor Gabriel Savu voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andrey Kosyakov
      • Tiago Vignatti (xWF)
      Submit Requirements:
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement satisfiedLint
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: refs/branch-heads/7559
        Gerrit-Change-Id: I3fd8c25f19b839ed64099b1f54e7770af345a589
        Gerrit-Change-Number: 7755304
        Gerrit-PatchSet: 6
        Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
        Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
        Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
        Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
        Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
        Gerrit-Attention: Tiago Vignatti (xWF) <vign...@google.com>
        Gerrit-Comment-Date: Fri, 08 May 2026 07:47:56 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Victor Gabriel Savu (Gerrit)

        unread,
        May 8, 2026, 3:48:29 AM (11 days ago) May 8
        to Tiago Vignatti (xWF), Andrey Kosyakov, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, jshin...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
        Attention needed from Andrey Kosyakov and Tiago Vignatti (xWF)

        Victor Gabriel Savu added 1 comment

        Patchset-level comments
        Victor Gabriel Savu . resolved

        Ping me if you need owners override here.

        Gerrit-Comment-Date: Fri, 08 May 2026 07:48:11 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Tiago Vignatti (xWF) (Gerrit)

        unread,
        May 12, 2026, 1:10:07 PM (7 days ago) May 12
        to Code Review Nudger, Victor Gabriel Savu, Andrey Kosyakov, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, jshin...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
        Attention needed from Andrey Kosyakov

        Tiago Vignatti (xWF) added 1 comment

        Patchset-level comments
        Tiago Vignatti (xWF) . resolved

        caseq@ could you PTAL? The bug was approved for M144 LTS.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Andrey Kosyakov
        Submit Requirements:
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement satisfiedLint
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: refs/branch-heads/7559
        Gerrit-Change-Id: I3fd8c25f19b839ed64099b1f54e7770af345a589
        Gerrit-Change-Number: 7755304
        Gerrit-PatchSet: 6
        Gerrit-Owner: Tiago Vignatti (xWF) <vign...@google.com>
        Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
        Gerrit-Reviewer: Tiago Vignatti (xWF) <vign...@google.com>
        Gerrit-Reviewer: Victor Gabriel Savu <vs...@google.com>
        Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
        Gerrit-CC: Kentaro Hara <har...@chromium.org>
        Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
        Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
        Gerrit-Comment-Date: Tue, 12 May 2026 17:09:59 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages