Extract PassAsSpan support into a file of its own [chromium/src : main]

72 views
Skip to first unread message

Andrey Kosyakov (Gerrit)

unread,
Jun 18, 2024, 4:13:49 PM (11 days ago) Jun 18
to Nate Chapin, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Nate Chapin

Andrey Kosyakov voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nate Chapin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie0086ec159b137934645d4af793369a734b013d1
Gerrit-Change-Number: 5640348
Gerrit-PatchSet: 2
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Tue, 18 Jun 2024 20:13:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Chapin (Gerrit)

unread,
Jun 21, 2024, 6:56:58 PM (8 days ago) Jun 21
to Andrey Kosyakov, Code Review Nudger, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Andrey Kosyakov

Nate Chapin voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Andrey Kosyakov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie0086ec159b137934645d4af793369a734b013d1
Gerrit-Change-Number: 5640348
Gerrit-PatchSet: 2
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Comment-Date: Fri, 21 Jun 2024 22:56:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 21, 2024, 7:47:53 PM (8 days ago) Jun 21
to Andrey Kosyakov, Nate Chapin, Code Review Nudger, chromium...@chromium.org, Kentaro Hara, blink-revie...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Extract PassAsSpan support into a file of its own

No logic changes, just moving lines around.
Change-Id: Ie0086ec159b137934645d4af793369a734b013d1
Reviewed-by: Nate Chapin <jap...@chromium.org>
Commit-Queue: Nate Chapin <jap...@chromium.org>
Auto-Submit: Andrey Kosyakov <ca...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1318219}
Files:
  • M third_party/blink/renderer/bindings/bindings.gni
  • M third_party/blink/renderer/bindings/core/v8/native_value_traits_impl.h
  • A third_party/blink/renderer/bindings/core/v8/pass_as_span.h
Change size: L
Delta: 3 files changed, 143 insertions(+), 126 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nate Chapin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie0086ec159b137934645d4af793369a734b013d1
Gerrit-Change-Number: 5640348
Gerrit-PatchSet: 3
Gerrit-Owner: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages