Remove SystemEntropy code from Blink [chromium/src : main]

[Mike Jackson (Gerrit)]

Attention needed from Yoav Weiss (@Shopify)

Mike Jackson added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Mike Jackson . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

• Yoav Weiss (@Shopify)

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I38a232c8df0fa6fb952465a901af36d19d21b730

Gerrit-Change-Number: 6274057

Gerrit-PatchSet: 9

Gerrit-Owner: Mike Jackson <mjac...@microsoft.com>

Gerrit-Reviewer: Mike Jackson <mjac...@microsoft.com>

Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-Comment-Date: Tue, 04 Nov 2025 00:54:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Yoav Weiss (@Shopify) (Gerrit)]

Attention needed from Mike Jackson

Yoav Weiss (@Shopify) voted and added 1 comment

Votes added by Yoav Weiss (@Shopify)

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Yoav Weiss (@Shopify) . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Mike Jackson

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I38a232c8df0fa6fb952465a901af36d19d21b730

Gerrit-Change-Number: 6274057

Gerrit-PatchSet: 11

Gerrit-Owner: Mike Jackson <mjac...@microsoft.com>

Gerrit-Reviewer: Mike Jackson <mjac...@microsoft.com>

Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mike Jackson <mjac...@microsoft.com>

Gerrit-Comment-Date: Wed, 19 Nov 2025 07:27:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[gwsq (Gerrit)]

Attention needed from Alex Gough

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: aj...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): aj...@chromium.org

Reviewer source(s):
aj...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Alex Gough

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I38a232c8df0fa6fb952465a901af36d19d21b730

Gerrit-Change-Number: 6274057

Gerrit-PatchSet: 12

Gerrit-Owner: Mike Jackson <mjac...@microsoft.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: Mike Jackson <mjac...@microsoft.com>

Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Alex Gough <aj...@chromium.org>

Gerrit-Comment-Date: Wed, 19 Nov 2025 16:23:24 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Alex Gough (Gerrit)]

Attention needed from Mike Jackson

Alex Gough voted and added 1 comment

Votes added by Alex Gough

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Alex Gough . resolved

lgtm mojom deletion thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Mike Jackson

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I38a232c8df0fa6fb952465a901af36d19d21b730

Gerrit-Change-Number: 6274057

Gerrit-PatchSet: 12

Gerrit-Owner: Mike Jackson <mjac...@microsoft.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: Mike Jackson <mjac...@microsoft.com>

Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Mike Jackson <mjac...@microsoft.com>

Gerrit-Comment-Date: Wed, 19 Nov 2025 16:57:06 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Mike Jackson (Gerrit)]

Mike Jackson voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Gerrit-Comment-Date: Wed, 19 Nov 2025 17:24:43 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Remove SystemEntropy code from Blink

Cleanup code related to 'SystemEntropy', which has been replaced by
'Confidence'. This is the last of 3 changes.

Explainer:
https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/PerformanceNavigationTiming%20for%20User%20Agent%20Launch/explainer.md
Chrome Status: https://chromestatus.com/feature/5186950448283648 Dev
Design:
https://docs.google.com/document/d/1D6DqptsCEd3wPRsZ0q1iwVBAXXmhxZuLV-KKFI0ptCg/edit?usp=sharing
I2P:
https://groups.google.com/a/chromium.org/g/blink-dev/c/o0F7nBKsgg0/m/bJSp3ekfAAAJ
W3C Issue: https://github.com/w3c/navigation-timing/issues/202

Change-Id: I38a232c8df0fa6fb952465a901af36d19d21b730

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6274057

Reviewed-by: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Reviewed-by: Alex Gough <aj...@chromium.org>

Commit-Queue: Mike Jackson <mjac...@microsoft.com>

Cr-Commit-Position: refs/heads/main@{#1547289}

Files:

• M third_party/blink/public/mojom/BUILD.gn
• M third_party/blink/public/mojom/navigation/navigation_params.mojom
• D third_party/blink/public/mojom/navigation/system_entropy.mojom
• M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
• M third_party/blink/public/web/web_navigation_timings.h
• M third_party/blink/renderer/bindings/generated_in_core.gni
• M third_party/blink/renderer/core/loader/document_load_timing.h
• M third_party/blink/renderer/core/loader/document_loader.cc
• M third_party/blink/renderer/core/timing/performance_navigation_timing.cc
• M third_party/blink/renderer/core/timing/performance_navigation_timing.h
• M third_party/blink/renderer/core/timing/performance_navigation_timing.idl
• M third_party/blink/renderer/platform/runtime_enabled_features.json5
• M tools/metrics/histograms/metadata/blink/enums.xml

Change size: M

Delta: 13 files changed, 2 insertions(+), 96 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Yoav Weiss (@Shopify), +1 by Alex Gough

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I38a232c8df0fa6fb952465a901af36d19d21b730

Gerrit-Change-Number: 6274057

Gerrit-PatchSet: 13

Gerrit-Owner: Mike Jackson <mjac...@microsoft.com>

Gerrit-Reviewer: Alex Gough <aj...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Mike Jackson <mjac...@microsoft.com>

Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>