Revert "[heap] Record GrowingMode in GC Cycle UKM" [chromium/src : main]
0 views
Skip to first unread message
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Jun 19, 2026, 7:45:18 PM (8 days ago) Jun 19
to rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Michael Lippautz, Robert Kaplow, Etienne Pierre-Doray, Raphael Kubo da Costa, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, blink-...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org
Attention needed from Etienne Pierre-Doray, Michael Lippautz and Robert Kaplow
Message from luci-bi...@appspot.gserviceaccount.com![]( "Open in Gerrit")
LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Michael Lippautz
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Jun 19, 2026, 7:45:21 PM (8 days ago) Jun 19
to luci-bi...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Michael Lippautz, Robert Kaplow, Etienne Pierre-Doray, Raphael Kubo da Costa, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, blink-...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org
Attention needed from Etienne Pierre-Doray, Michael Lippautz and Robert Kaplow
rubber-...@appspot.gserviceaccount.com voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Michael Lippautz
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fergal Daly (Gerrit)
Jun 21, 2026, 11:21:18 PM (6 days ago) Jun 21
to luci-bi...@appspot.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Michael Lippautz, Robert Kaplow, Etienne Pierre-Doray, Raphael Kubo da Costa, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, blink-...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org
Attention needed from Etienne Pierre-Doray, Michael Lippautz and Robert Kaplow
Fergal Daly voted and added 1 comment![]( "Open in Gerrit")
Votes added by Fergal Daly
| Owners-Override | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Fergal Daly . resolved
Yes, I also found this as the culprit for MSAN breakage.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Michael Lippautz
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fergal Daly (Gerrit)
Jun 21, 2026, 11:22:31 PM (6 days ago) Jun 21
to luci-bi...@appspot.gserviceaccount.com, Fergal Daly, Fergal Daly, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Michael Lippautz, Robert Kaplow, Etienne Pierre-Doray, Raphael Kubo da Costa, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, blink-...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org
Attention needed from Etienne Pierre-Doray, Michael Lippautz and Robert Kaplow
Fergal Daly voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
- Michael Lippautz
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 21, 2026, 11:25:51 PM (6 days ago) Jun 21
to luci-bi...@appspot.gserviceaccount.com, Fergal Daly, Fergal Daly, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Michael Lippautz, Robert Kaplow, Etienne Pierre-Doray, Raphael Kubo da Costa, chromium...@chromium.org, Kentaro Hara, Chromium Metrics Reviews, blink-...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[heap] Record GrowingMode in GC Cycle UKM"
This reverts commit 115fe532a838027a6c1dc679441547ae39c3c2a8.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5644029657088000
Sample build with failed test: https://ci.chromium.org/b/8678535567764500897
Affected test(s):
[://\:blink_web_tests!webtest::accessibility#adopt-node-causes-crash.html](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_web_tests%21webtest::accessibility%23adopt-node-causes-crash.html?q=VHash%3Ac1eb693277f13041)
[://\:blink_web_tests!webtest::accessibility#table-cell-for-column-and-row-crash.html](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_web_tests%21webtest::accessibility%23table-cell-for-column-and-row-crash.html?q=VHash%3Ac1eb693277f13041)
[://\:blink_web_tests!webtest::animations#animation-finish-promise-gc.html](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_web_tests%21webtest::animations%23animation-finish-promise-gc.html?q=VHash%3Ac1eb693277f13041)
[://\:blink_web_tests!webtest::animations/custom-properties#element-animate-crash.html](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_web_tests%21webtest::animations%2Fcustom-properties%23element-animate-crash.html?q=VHash%3Ac1eb693277f13041)
[://\:blink_web_tests!webtest::clipboard/async-clipboard#clipboard-garbage-collection-race-condition.html](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_web_tests%21webtest::clipboard%2Fasync-clipboard%23clipboard-garbage-collection-race-condition.html?q=VHash%3Ac1eb693277f13041)
and 112 more ...
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5644029657088000&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7962922&type=BUG
Original change's description:
> [heap] Record GrowingMode in GC Cycle UKM
>
> Growing mode informs on heap limit heuristics.
> Following https://chromium-review.git.corp.google.com/c/v8/v8/+/7957808
>
> Bug: 477484620
> Change-Id: Ie5da39bf7ca048939660a616ee9d07fbecd521c0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7962922
> Reviewed-by: Robert Kaplow <rka...@chromium.org>
> Reviewed-by: Michael Lippautz <mlip...@chromium.org>
> Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1649766}
>
Bug: 477484620
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I25a96d13f2c9b5768c59a21b42297f625283ebd6
Reviewed-by: Fergal Daly <fer...@chromium.org>
Owners-Override: Fergal Daly <fer...@google.com>
Commit-Queue: Fergal Daly <fer...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1650121}
Files:
- M third_party/blink/renderer/bindings/core/v8/v8_metrics.cc
- M tools/metrics/histograms/metadata/v8/enums.xml
- M tools/metrics/ukm/ukm.xml
Change size: S
Delta: 3 files changed, 0 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Fergal Daly, Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages