[BRP] Enforce raw_ptr/ref in Renderer code [chromium/src : main]

0 views
Skip to first unread message

Bartek Nowierski (Gerrit)

unread,
Jun 26, 2024, 9:51:58 AM (3 days ago) Jun 26
to Takuto Ikuta, Keishi Hattori, Kentaro Hara, Nate Chapin, Stephen Chenney, Dirk Schulze, AyeAye, Kalvin Lee, Chromium LUCI CQ, chromium...@chromium.org, gogerald+pa...@chromium.org, rouslan+...@chromium.org, nburris+pa...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, loading-re...@chromium.org, fmalit...@chromium.org, android-web...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, feature-me...@chromium.org, blink-reviews-p...@chromium.org, blink-revie...@chromium.org, video-networking...@google.com, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Keishi Hattori, Kentaro Hara and Takuto Ikuta

Bartek Nowierski added 1 comment

Patchset-level comments
File-level comment, Patchset 2:
Bartek Nowierski . unresolved

Note to self: Safe to land only after clang plugin change in crrev.com/c/5600329 has been rolled and had enough time to bake

Bartek Nowierski

@kei...@chromium.org if you believe that the clang plugin had enough time to bake, please resolve this comment

Open in Gerrit

Related details

Attention is currently required from:
  • Keishi Hattori
  • Kentaro Hara
  • Takuto Ikuta
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If2f9d566af735f101c085c523037c2e1e4c47125
Gerrit-Change-Number: 5624392
Gerrit-PatchSet: 17
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kalvin Lee <kd...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Attention: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Takuto Ikuta <tik...@chromium.org>
Gerrit-Comment-Date: Wed, 26 Jun 2024 13:51:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bartek Nowierski <bar...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Kentaro Hara (Gerrit)

unread,
Jun 26, 2024, 7:05:28 PM (3 days ago) Jun 26
to Bartek Nowierski, Takuto Ikuta, Keishi Hattori, Nate Chapin, Stephen Chenney, Dirk Schulze, AyeAye, Kalvin Lee, Chromium LUCI CQ, chromium...@chromium.org, gogerald+pa...@chromium.org, rouslan+...@chromium.org, nburris+pa...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, loading-re...@chromium.org, fmalit...@chromium.org, android-web...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, feature-me...@chromium.org, blink-reviews-p...@chromium.org, blink-revie...@chromium.org, video-networking...@google.com, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski, Keishi Hattori and Takuto Ikuta

Kentaro Hara voted and added 1 comment

Votes added by Kentaro Hara

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Bartek Nowierski
  • Keishi Hattori
  • Takuto Ikuta
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If2f9d566af735f101c085c523037c2e1e4c47125
Gerrit-Change-Number: 5624392
Gerrit-PatchSet: 17
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kalvin Lee <kd...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Attention: Bartek Nowierski <bar...@chromium.org>
Gerrit-Attention: Takuto Ikuta <tik...@chromium.org>
Gerrit-Comment-Date: Wed, 26 Jun 2024 23:05:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Takuto Ikuta (Gerrit)

unread,
Jun 26, 2024, 10:33:58 PM (3 days ago) Jun 26
to Bartek Nowierski, Takuto Ikuta, Kentaro Hara, Keishi Hattori, Nate Chapin, Stephen Chenney, Dirk Schulze, AyeAye, Kalvin Lee, Chromium LUCI CQ, chromium...@chromium.org, gogerald+pa...@chromium.org, rouslan+...@chromium.org, nburris+pa...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, loading-re...@chromium.org, fmalit...@chromium.org, android-web...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, feature-me...@chromium.org, blink-reviews-p...@chromium.org, blink-revie...@chromium.org, video-networking...@google.com, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski and Keishi Hattori

Takuto Ikuta voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Bartek Nowierski
  • Keishi Hattori
Gerrit-Comment-Date: Thu, 27 Jun 2024 02:33:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keishi Hattori (Gerrit)

unread,
Jun 27, 2024, 5:01:20 AM (2 days ago) Jun 27
to Bartek Nowierski, Takuto Ikuta, Kentaro Hara, Nate Chapin, Stephen Chenney, Dirk Schulze, AyeAye, Kalvin Lee, Chromium LUCI CQ, chromium...@chromium.org, gogerald+pa...@chromium.org, rouslan+...@chromium.org, nburris+pa...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, loading-re...@chromium.org, fmalit...@chromium.org, android-web...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, feature-me...@chromium.org, blink-reviews-p...@chromium.org, blink-revie...@chromium.org, video-networking...@google.com, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski

Keishi Hattori voted and added 1 comment

Votes added by Keishi Hattori

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Keishi Hattori . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Bartek Nowierski
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If2f9d566af735f101c085c523037c2e1e4c47125
Gerrit-Change-Number: 5624392
Gerrit-PatchSet: 17
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kalvin Lee <kd...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Bartek Nowierski <bar...@chromium.org>
Gerrit-Comment-Date: Thu, 27 Jun 2024 09:01:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Bartek Nowierski (Gerrit)

unread,
Jun 28, 2024, 9:34:44 AM (yesterday) Jun 28
to Keishi Hattori, Takuto Ikuta, Kentaro Hara, Nate Chapin, Stephen Chenney, Dirk Schulze, AyeAye, Kalvin Lee, Chromium LUCI CQ, chromium...@chromium.org, gogerald+pa...@chromium.org, rouslan+...@chromium.org, nburris+pa...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, loading-re...@chromium.org, fmalit...@chromium.org, android-web...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, feature-me...@chromium.org, blink-reviews-p...@chromium.org, blink-revie...@chromium.org, video-networking...@google.com, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Keishi Hattori, Kentaro Hara and Takuto Ikuta

Bartek Nowierski voted and added 1 comment

Votes added by Bartek Nowierski

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 18 (Latest):
Bartek Nowierski . resolved

Not sure why but all +1s went to trash after rebasing

Open in Gerrit

Related details

Attention is currently required from:
  • Keishi Hattori
  • Kentaro Hara
  • Takuto Ikuta
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If2f9d566af735f101c085c523037c2e1e4c47125
Gerrit-Change-Number: 5624392
Gerrit-PatchSet: 18
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kalvin Lee <kd...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Attention: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Takuto Ikuta <tik...@chromium.org>
Gerrit-Comment-Date: Fri, 28 Jun 2024 13:34:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kentaro Hara (Gerrit)

unread,
Jun 28, 2024, 10:25:52 AM (yesterday) Jun 28
to Bartek Nowierski, Keishi Hattori, Takuto Ikuta, Nate Chapin, Stephen Chenney, Dirk Schulze, AyeAye, Kalvin Lee, Chromium LUCI CQ, chromium...@chromium.org, gogerald+pa...@chromium.org, rouslan+...@chromium.org, nburris+pa...@chromium.org, gavinp...@chromium.org, loading...@chromium.org, loading-re...@chromium.org, fmalit...@chromium.org, android-web...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, feature-me...@chromium.org, blink-reviews-p...@chromium.org, blink-revie...@chromium.org, video-networking...@google.com, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Bartek Nowierski, Keishi Hattori and Takuto Ikuta

Kentaro Hara voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Bartek Nowierski
  • Keishi Hattori
  • Takuto Ikuta
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If2f9d566af735f101c085c523037c2e1e4c47125
Gerrit-Change-Number: 5624392
Gerrit-PatchSet: 18
Gerrit-Owner: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Bartek Nowierski <bar...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kalvin Lee <kd...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Attention: Bartek Nowierski <bar...@chromium.org>
Gerrit-Attention: Takuto Ikuta <tik...@chromium.org>
Gerrit-Comment-Date: Fri, 28 Jun 2024 14:25:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages