[wip] open up for more, probably needs better IsCacheable() code [chromium/src : main]

0 views

Skip to first unread message

Steinar H Gunderson (Gerrit)

unread,

Apr 20, 2026, 4:20:36 AM (7 days ago) Apr 20

to Raphael Kubo da Costa, chromium...@chromium.org, (Julie)Jeongeun Kim, Menard, Alexis, Kentaro Hara, Kevin Babbitt, blink-re...@chromium.org, kinuko...@chromium.org, lucasrada...@google.com, blink-rev...@chromium.org, jmedle...@chromium.org, nektar...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, francisjp...@google.com, josiah...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, dtseng...@chromium.org, blink-...@chromium.org

Steinar H Gunderson has uploaded the change for review

Commit message

[wip] open up for more, probably needs better IsCacheable() code

Change-Id: I9cfe9244f131d0a3731a5dcf28bdb2e45cedad53

Change diff

diff --git a/third_party/blink/renderer/core/css/resolver/style_adjuster.cc b/third_party/blink/renderer/core/css/resolver/style_adjuster.cc
index 59924b52..7d7eabe 100644
--- a/third_party/blink/renderer/core/css/resolver/style_adjuster.cc
+++ b/third_party/blink/renderer/core/css/resolver/style_adjuster.cc
@@ -1572,11 +1572,17 @@
       // The first <body> element is treated differently from the others,
       // both for touch-action and for setting a ComputedStyle flag
       // (forcing style invalidation).
-      return {ElementType::kIsNotElement};
+      if (element.GetDocument().FirstBodyElement() != element) {
+        return {ElementType::kIsNotElement};
+      }
+      return {element.GetElementType()};
 
     case ElementType::kHTMLImageElement:
-      // Checks IsCollapsed().
-      return {ElementType::kIsNotElement};
+      if (To<HTMLImageElement>(element).IsCollapsed()) {
+        // Has special display handling.
+        return {ElementType::kIsNotElement};
+      }
+      return {element.GetElementType()};
 
     case ElementType::kHTMLFrameElement:
     case ElementType::kHTMLIFrameElement:
@@ -1657,6 +1663,13 @@
     // They also have different handling of the display property,
     // but that is moot as we exclude them here anyway.
     case ElementType::kSVGSVGElement:
+      if (!To<SVGSVGElement>(element).IsOutermostSVGSVGElement()) {
+        return {ElementType::kIsNotElement};
+      } else {
+        return {element.GetElementType()};
+      }
+
+    // SVG <use> elements can refer to whatever. FIXME WRITE MORE
     case ElementType::kSVGUseElement:
       return {ElementType::kIsNotElement};

Change information

Files:

M third_party/blink/renderer/core/css/resolver/style_adjuster.cc

Change size: S

Delta: 1 file changed, 16 insertions(+), 3 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,

Apr 20, 2026, 5:29:44 AM (7 days ago) Apr 20

to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jmedle...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Steinar H Gunderson