DOM: Introduce CommandInvokerElement interface mixin [chromium/src : main]

38 views
Skip to first unread message

Dominic Farolino (Gerrit)

unread,
Jan 12, 2026, 1:14:33 PM (4 days ago) Jan 12
to Chromium LUCI CQ, Mason Freed, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Mason Freed

Dominic Farolino voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9a1cac0553e3adf9b483d634b951d7f8789f0fe6
Gerrit-Change-Number: 7454237
Gerrit-PatchSet: 1
Gerrit-Owner: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Mon, 12 Jan 2026 18:14:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Jan 13, 2026, 12:50:29 PM (3 days ago) Jan 13
to Dominic Farolino, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Dominic Farolino

Mason Freed voted and added 1 comment

Votes added by Mason Freed

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Mason Freed . resolved

Nice! Thanks for doing this.

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9a1cac0553e3adf9b483d634b951d7f8789f0fe6
    Gerrit-Change-Number: 7454237
    Gerrit-PatchSet: 3
    Gerrit-Owner: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Dominic Farolino <d...@chromium.org>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 17:50:13 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Dominic Farolino (Gerrit)

    unread,
    Jan 13, 2026, 12:50:52 PM (3 days ago) Jan 13
    to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

    Dominic Farolino voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9a1cac0553e3adf9b483d634b951d7f8789f0fe6
    Gerrit-Change-Number: 7454237
    Gerrit-PatchSet: 3
    Gerrit-Owner: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Comment-Date: Tue, 13 Jan 2026 17:50:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 13, 2026, 1:47:52 PM (3 days ago) Jan 13
    to Dominic Farolino, Mason Freed, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    DOM: Introduce CommandInvokerElement interface mixin

    This CL introduces the CommandInvokerElement WebIDL interface mixin,
    to group the `commandForElement` and `command` attributes, so that
    future elements that become command invokers do not have to manually add
    these attributes to their element definitions.

    This mirrors `InterestInvokerElement`.

    R=masonf
    Bug: N/A
    Change-Id: I9a1cac0553e3adf9b483d634b951d7f8789f0fe6
    Reviewed-by: Mason Freed <mas...@chromium.org>
    Commit-Queue: Dominic Farolino <d...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1568555}
    Files:
    • M third_party/blink/renderer/bindings/idl_in_core.gni
    • A third_party/blink/renderer/core/dom/command_invoker_element.idl
    • M third_party/blink/renderer/core/html/forms/html_button_element.idl
    • M third_party/blink/renderer/core/html/html_menu_item_element.idl
    Change size: S
    Delta: 4 files changed, 11 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mason Freed
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9a1cac0553e3adf9b483d634b951d7f8789f0fe6
    Gerrit-Change-Number: 7454237
    Gerrit-PatchSet: 4
    Gerrit-Owner: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages