PoC: Add 'ObserveMonkeypatch' IDL Attribute; Demonstrate Usage. [chromium/src : main]

0 views
Skip to first unread message

Yao Xiao (Gerrit)

unread,
Oct 8, 2025, 8:08:04 PMOct 8
to Raphael Kubo da Costa, Kentaro Hara, AyeAye, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Yao Xiao added 2 comments

File third_party/blink/renderer/bindings/core/v8/monkeypatch_helper.h
Line 32, Patchset 3: MonkeypatchScope(v8::Isolate* isolate,
AI Code Reviewer . resolved

Blink Style Guide: Naming - May leave obvious parameter names out of function declarations. The parameter name 'isolate' is obvious from its type 'v8::Isolate*' and can be omitted from the function declaration in the header file. The same applies to the other function declarations in this file.

_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Yao Xiao

Done

Line 32, Patchset 2: MonkeypatchScope(v8::Isolate* isolate,
AI Code Reviewer . resolved

Blink Style Guide: Naming - May leave obvious parameter names out of function declarations. The parameter name `isolate` is obvious from its type `v8::Isolate*` and can be omitted in the header file declaration.

_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Yao Xiao

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2ddcf52db3c9a7111e65447360421f6886503864
Gerrit-Change-Number: 7003349
Gerrit-PatchSet: 4
Gerrit-Owner: Yao Xiao <yao...@chromium.org>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Thu, 09 Oct 2025 00:07:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrey Kosyakov (Gerrit)

unread,
Oct 10, 2025, 8:47:49 PMOct 10
to Yao Xiao, Raphael Kubo da Costa, Kentaro Hara, AyeAye, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, peter+watch...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Yao Xiao

Andrey Kosyakov added 1 comment

File third_party/blink/renderer/bindings/core/v8/monkeypatch_helper.cc
Line 51, Patchset 8 (Latest): native_call_count_key_(native_call_count_key) {
Andrey Kosyakov . unresolved

So... How does this get incremented?

Open in Gerrit

Related details

Attention is currently required from:
  • Yao Xiao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2ddcf52db3c9a7111e65447360421f6886503864
    Gerrit-Change-Number: 7003349
    Gerrit-PatchSet: 8
    Gerrit-Owner: Yao Xiao <yao...@chromium.org>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Andrey Kosyakov <ca...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Yao Xiao <yao...@chromium.org>
    Gerrit-Comment-Date: Sat, 11 Oct 2025 00:47:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrey Kosyakov (Gerrit)

    unread,
    Oct 10, 2025, 9:22:18 PMOct 10
    to Yao Xiao, Raphael Kubo da Costa, Kentaro Hara, AyeAye, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, peter+watch...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
    Attention needed from Yao Xiao

    Andrey Kosyakov added 1 comment

    File third_party/blink/renderer/bindings/core/v8/monkeypatch_helper.cc
    Line 51, Patchset 8 (Latest): native_call_count_key_(native_call_count_key) {
    Andrey Kosyakov . unresolved

    So... How does this get incremented?

    Andrey Kosyakov

    Ok, I can see how. This looks fairly expensive though. Any idea on the impact of this on performance?

    Gerrit-Comment-Date: Sat, 11 Oct 2025 01:21:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Andrey Kosyakov <ca...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yao Xiao (Gerrit)

    unread,
    Nov 18, 2025, 2:36:45 PM (4 days ago) Nov 18
    to Andrey Kosyakov, Raphael Kubo da Costa, Kentaro Hara, AyeAye, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, peter+watch...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

    Yao Xiao added 1 comment

    File third_party/blink/renderer/bindings/core/v8/monkeypatch_helper.cc
    Line 51, Patchset 8 (Latest): native_call_count_key_(native_call_count_key) {
    Andrey Kosyakov . resolved

    So... How does this get incremented?

    Andrey Kosyakov

    Ok, I can see how. This looks fairly expensive though. Any idea on the impact of this on performance?

    Yao Xiao

    As long as the API isn't called on a lot on the page (which is true for history.pushState()), the performance impact should be negligible.

    (Note: This change has been deprecated because it introduced observable changes to web functions. We have transitioned to a less robust, heuristic method: https://crrev.com/c/7063870)

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I2ddcf52db3c9a7111e65447360421f6886503864
      Gerrit-Change-Number: 7003349
      Gerrit-PatchSet: 8
      Gerrit-Owner: Yao Xiao <yao...@chromium.org>
      Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
      Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
      Gerrit-CC: Andrey Kosyakov <ca...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Comment-Date: Tue, 18 Nov 2025 19:36:30 +0000
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Yao Xiao (Gerrit)

      unread,
      Nov 18, 2025, 2:36:54 PM (4 days ago) Nov 18
      to Andrey Kosyakov, Raphael Kubo da Costa, Kentaro Hara, AyeAye, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, peter+watch...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

      Yao Xiao abandoned this change

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: abandon
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages