Migrate ParkableStringManager to MemoryConsumer [chromium/src : main]
0 views
Skip to first unread message
Patrick Monette (Gerrit)
Jun 26, 2026, 10:51:52 AM (2 days ago) Jun 26
to Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Jeremy Roman
Patrick Monette added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Jun 26, 2026, 2:03:39 PM (2 days ago) Jun 26
to Patrick Monette, Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Patrick Monette
Jeremy Roman voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Patrick Monette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Monette (Gerrit)
Jun 26, 2026, 2:06:50 PM (2 days ago) Jun 26
to Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Patrick Monette voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patrick Monette
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 26, 2026, 2:11:50 PM (2 days ago) Jun 26
to Patrick Monette, Jeremy Roman, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Migrate ParkableStringManager to MemoryConsumer
base::MemoryPressureListener is deprecated in favor of the
base::MemoryConsumer API.
While this new API has support for more functionality, this migration is
completely no-op, keeping the non-stateful nature of the
MemoryPressureListener implementation, where a compression is done as a
one-time purge every time a critical memory pressure notification is
received rather than maintaining an ongoing target memory limit.
Bug: 489349561
Change-Id: I01041a91d31cc0cce1c41f56780882f6f8a6d25f
Commit-Queue: Patrick Monette <pmon...@chromium.org>
Reviewed-by: Jeremy Roman <jbr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1653285}
Files:
- M third_party/blink/renderer/platform/bindings/DEPS
- M third_party/blink/renderer/platform/bindings/parkable_string_manager.cc
- M third_party/blink/renderer/platform/bindings/parkable_string_manager.h
- M third_party/blink/renderer/platform/bindings/parkable_string_test.cc
- M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
Change size: M
Delta: 5 files changed, 64 insertions(+), 25 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jeremy Roman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages